Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(28538): add manage master user password flag #28848

Merged
merged 58 commits into from
Mar 28, 2023
Merged

feat(28538): add manage master user password flag #28848

merged 58 commits into from
Mar 28, 2023

Conversation

fergoid
Copy link
Contributor

@fergoid fergoid commented Jan 12, 2023

Description

This pull request adds the option for RDS to manage master user passwords. The default behaviour continues to be to manage passwords as the resource does today.

Relations

Closes #28538

References

Output from Acceptance Testing

$ make testacc PKG=rds TESTS=TestAccRDSInstance_basic                                                                                    <aws:default>
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_basic'  -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_basic (471.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        500.343s

$ make testacc PKG=rds TESTS=TestAccRDSInstance_manage_password                                                                          <aws:default>
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_manage_password'  -timeout 180m
=== RUN   TestAccRDSInstance_manage_password
=== PAUSE TestAccRDSInstance_manage_password
=== CONT  TestAccRDSInstance_manage_password
--- PASS: TestAccRDSInstance_manage_password (529.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        556.548s

make testacc PKG=rds TESTS=TestAccRDSInstanceDataSource_basic                                                                          <aws:default>
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceDataSource_basic'  -timeout 180m
=== RUN   TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== CONT  TestAccRDSInstanceDataSource_basic
--- PASS: TestAccRDSInstanceDataSource_basic (499.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        527.915s

$ make testacc PKG=rds TESTS=TestAccRDSInstanceDataSource_manage_password                                                                <aws:default>
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceDataSource_manage_password'  -timeout 180m
=== RUN   TestAccRDSInstanceDataSource_manage_password
=== PAUSE TestAccRDSInstanceDataSource_manage_password
=== CONT  TestAccRDSInstanceDataSource_manage_password
--- PASS: TestAccRDSInstanceDataSource_manage_password (520.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        548.706s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jan 12, 2023
@fergoid
Copy link
Contributor Author

fergoid commented Jan 13, 2023

What is the correct definition for this attribute? It fails the S019 check , although it does work as intended which is to return the secret ARN that RDS creates to the consumer.

			"master_user_secret_arn": {
				Type:     schema.TypeString,
				Optional: false,
				Required: false,
				Computed: true,
			},

Can I flag it to be ignored (//lintignore:S019) or is there another way to achieve this ?

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2023
@wedge-jarrad
Copy link
Contributor

Thanks for working on this! Very much looking forward to this functionality.

Unless I'm mistaken, similar changes are needed in cluster.go.

@fergoid
Copy link
Contributor Author

fergoid commented Jan 16, 2023

Thanks for working on this! Very much looking forward to this functionality.

Unless I'm mistaken, similar changes are needed in cluster.go.

I will take a look today , thanks.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 16, 2023
@fergoid
Copy link
Contributor Author

fergoid commented Jan 27, 2023

I keep getting GH action errors on goreleaser in my forked repo. Not sure what this means?
Screenshot 2023-01-27 at 09 07 05

@bryantbiggs
Copy link
Contributor

any update on getting this merged, anything left to do?

@bryantbiggs
Copy link
Contributor

@AdamTylerLynch / @ewbankkit would either of you have time to take a look at the PR?

@AdamTylerLynch AdamTylerLynch self-requested a review March 10, 2023 19:20
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested. I am going to make some code changes on this PR to expedite the merge.

internal/service/rds/cluster.go Outdated Show resolved Hide resolved
internal/service/rds/cluster.go Outdated Show resolved Hide resolved
internal/service/rds/cluster.go Outdated Show resolved Hide resolved
internal/service/rds/cluster_data_source_test.go Outdated Show resolved Hide resolved
internal/service/rds/cluster_data_source_test.go Outdated Show resolved Hide resolved
@AdamTylerLynch
Copy link
Collaborator

AdamTylerLynch commented Mar 23, 2023

AccTests for aws_rds_cluster

Pre-existing failures logged here: #30131

Output from acceptance testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 10 -run='TestAccRDSCluster_'  -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_disappears
=== PAUSE TestAccRDSCluster_disappears
=== RUN   TestAccRDSCluster_tags
=== PAUSE TestAccRDSCluster_tags
=== RUN   TestAccRDSCluster_identifierGenerated
=== PAUSE TestAccRDSCluster_identifierGenerated
=== RUN   TestAccRDSCluster_identifierPrefix
=== PAUSE TestAccRDSCluster_identifierPrefix
=== RUN   TestAccRDSCluster_allowMajorVersionUpgrade
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgrade
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== RUN   TestAccRDSCluster_onlyMajorVersion
=== PAUSE TestAccRDSCluster_onlyMajorVersion
=== RUN   TestAccRDSCluster_availabilityZones
=== PAUSE TestAccRDSCluster_availabilityZones
=== RUN   TestAccRDSCluster_storageType
=== PAUSE TestAccRDSCluster_storageType
=== RUN   TestAccRDSCluster_allocatedStorage
=== PAUSE TestAccRDSCluster_allocatedStorage
=== RUN   TestAccRDSCluster_iops
=== PAUSE TestAccRDSCluster_iops
=== RUN   TestAccRDSCluster_dbClusterInstanceClass
=== PAUSE TestAccRDSCluster_dbClusterInstanceClass
=== RUN   TestAccRDSCluster_backtrackWindow
=== PAUSE TestAccRDSCluster_backtrackWindow
=== RUN   TestAccRDSCluster_dbSubnetGroupName
=== PAUSE TestAccRDSCluster_dbSubnetGroupName
=== RUN   TestAccRDSCluster_pointInTimeRestore
=== PAUSE TestAccRDSCluster_pointInTimeRestore
=== RUN   TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== PAUSE TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== RUN   TestAccRDSCluster_takeFinalSnapshot
=== PAUSE TestAccRDSCluster_takeFinalSnapshot
=== RUN   TestAccRDSCluster_missingUserNameCausesError
=== PAUSE TestAccRDSCluster_missingUserNameCausesError
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSCluster_updateIAMRoles
=== PAUSE TestAccRDSCluster_updateIAMRoles
=== RUN   TestAccRDSCluster_kmsKey
=== PAUSE TestAccRDSCluster_kmsKey
=== RUN   TestAccRDSCluster_networkType
=== PAUSE TestAccRDSCluster_networkType
=== RUN   TestAccRDSCluster_encrypted
=== PAUSE TestAccRDSCluster_encrypted
=== RUN   TestAccRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot
=== RUN   TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_backupsUpdate
=== PAUSE TestAccRDSCluster_backupsUpdate
=== RUN   TestAccRDSCluster_iamAuth
=== PAUSE TestAccRDSCluster_iamAuth
=== RUN   TestAccRDSCluster_deletionProtection
=== PAUSE TestAccRDSCluster_deletionProtection
=== RUN   TestAccRDSCluster_engineMode
=== PAUSE TestAccRDSCluster_engineMode
=== RUN   TestAccRDSCluster_EngineMode_global
=== PAUSE TestAccRDSCluster_EngineMode_global
=== RUN   TestAccRDSCluster_EngineMode_multiMaster
=== PAUSE TestAccRDSCluster_EngineMode_multiMaster
=== RUN   TestAccRDSCluster_EngineMode_parallelQuery
=== PAUSE TestAccRDSCluster_EngineMode_parallelQuery
=== RUN   TestAccRDSCluster_engineVersion
=== PAUSE TestAccRDSCluster_engineVersion
=== RUN   TestAccRDSCluster_engineVersionWithPrimaryInstance
=== PAUSE TestAccRDSCluster_engineVersionWithPrimaryInstance
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managed
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managed
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== RUN   TestAccRDSCluster_port
=== PAUSE TestAccRDSCluster_port
=== RUN   TestAccRDSCluster_scaling
=== PAUSE TestAccRDSCluster_scaling
=== RUN   TestAccRDSCluster_serverlessV2ScalingConfiguration
=== PAUSE TestAccRDSCluster_serverlessV2ScalingConfiguration
=== RUN   TestAccRDSCluster_Scaling_defaultMinCapacity
=== PAUSE TestAccRDSCluster_Scaling_defaultMinCapacity
=== RUN   TestAccRDSCluster_snapshotIdentifier
=== PAUSE TestAccRDSCluster_snapshotIdentifier
=== RUN   TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless
    cluster_test.go:1898: serverless does not support snapshot restore on an empty volume
--- SKIP: TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless (0.00s)
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== RUN   TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== RUN   TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== RUN   TestAccRDSCluster_enableHTTPEndpoint
=== PAUSE TestAccRDSCluster_enableHTTPEndpoint
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_enableHTTPEndpoint
=== CONT  TestAccRDSCluster_encrypted
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
=== CONT  TestAccRDSCluster_serverlessV2ScalingConfiguration
=== CONT  TestAccRDSCluster_networkType
=== CONT  TestAccRDSCluster_updateIAMRoles
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== CONT  TestAccRDSCluster_kmsKey
--- PASS: TestAccRDSCluster_encrypted (156.00s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_basic (159.83s)
=== CONT  TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_kmsKey (162.10s)
=== CONT  TestAccRDSCluster_takeFinalSnapshot
2023-03-22T18:01:03.426Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_detail="" diagnostic_severity=ERROR
  diagnostic_summary=
  | creating RDS Cluster (tf-aurora-cluster-5818465634035343690): InvalidParameterValue: The parameter MasterUsername must be provided and must not be blank.
  | \tstatus code: 400, request id: 0dc926b6-2cda-4851-b950-eef9652ea743
   tf_rpc=ApplyResourceChange tf_resource_type=aws_rds_cluster tf_req_id=c3825cb0-8faa-7eeb-e6f4-a866bf9b5359 tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3
2023-03-22T18:01:03.442Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_working_directory=/tmp/plugintest3678831868 test_step_number=1
  error=
  | exit status 1
  | 
  | Error: creating RDS Cluster (tf-aurora-cluster-5818465634035343690): InvalidParameterValue: The parameter MasterUsername must be provided and must not be blank.
  | \tstatus code: 400, request id: 0dc926b6-2cda-4851-b950-eef9652ea743
  | 
  |   with aws_rds_cluster.default,
  |   on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "default":
  |    2: resource "aws_rds_cluster" "default" {
  | 
   test_name=TestAccRDSCluster_missingUserNameCausesError test_terraform_path=/tmp/plugintest-terraform189640480/terraform
--- PASS: TestAccRDSCluster_missingUserNameCausesError (8.28s)
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_updateIAMRoles (206.71s)
=== CONT  TestAccRDSCluster_pointInTimeRestore
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (222.68s)
=== CONT  TestAccRDSCluster_dbSubnetGroupName
--- PASS: TestAccRDSCluster_networkType (232.81s)
=== CONT  TestAccRDSCluster_backtrackWindow
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (373.20s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_tags
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (240.28s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
--- PASS: TestAccRDSCluster_dbSubnetGroupName (178.74s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
--- PASS: TestAccRDSCluster_takeFinalSnapshot (292.80s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (458.14s)
=== CONT  TestAccRDSCluster_storageType
--- PASS: TestAccRDSCluster_backtrackWindow (236.14s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (423.85s)
=== CONT  TestAccRDSCluster_iops
--- PASS: TestAccRDSCluster_pointInTimeRestore (393.02s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_availabilityZones (152.24s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (432.52s)
=== CONT  TestAccRDSCluster_onlyMajorVersion
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (472.69s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (455.81s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (435.68s)
=== CONT  TestAccRDSCluster_scaling
2023-03-22T18:13:45.516Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_detail="" diagnostic_severity=ERROR diagnostic_summary="existing RDS Clusters cannot be added to an existing RDS Global Cluster" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_resource_type=aws_rds_cluster tf_proto_version=5.3 tf_rpc=ApplyResourceChange tf_req_id=10e6e5f3-98d1-8246-b4f6-e62bae07aebb
2023-03-22T18:13:45.531Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_terraform_path=/tmp/plugintest-terraform4047039391/terraform test_step_number=2 test_working_directory=/tmp/plugintest876042364 test_name=TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
  error=
  | exit status 1
  | 
  | Error: existing RDS Clusters cannot be added to an existing RDS Global Cluster
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 8, in resource "aws_rds_cluster" "test":
  |    8: resource "aws_rds_cluster" "test" {
  | 
  
2023-03-22T18:13:45.531Z [ERROR] sdk.helper_resource: Expected an error with pattern (Existing RDS Clusters cannot be added to an existing RDS Global Cluster): test_name=TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add test_terraform_path=/tmp/plugintest-terraform4047039391/terraform test_step_number=2
  error=
  | Error running apply: exit status 1
  | 
  | Error: existing RDS Clusters cannot be added to an existing RDS Global Cluster
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 8, in resource "aws_rds_cluster" "test":
  |    8: resource "aws_rds_cluster" "test" {
  | 
   test_working_directory=/tmp/plugintest876042364
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
    cluster_test.go:1245: Step 2/2, expected an error with pattern, no match on: Error running apply: exit status 1
        
        Error: existing RDS Clusters cannot be added to an existing RDS Global Cluster
        
          with aws_rds_cluster.test,
          on terraform_plugin_test.tf line 8, in resource "aws_rds_cluster" "test":
           8: resource "aws_rds_cluster" "test" {
        
2023-03-22T18:14:59.931Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_severity=ERROR tf_rpc=ApplyResourceChange tf_resource_type=aws_rds_global_cluster tf_provider_addr=registry.terraform.io/hashicorp/aws tf_req_id=6fae8c7a-a25f-3594-fa08-2cb2c8a29ca1 tf_proto_version=5.3
  diagnostic_summary=
  | removing RDS DB Cluster () from Global Cluster (tf-acc-test-1134909169130696077): InvalidParameterValue: Db cluster identifier  is not a valid arn
  | \tstatus code: 400, request id: 7ef3d447-ae6b-406b-9913-2fc5c5527da5
   diagnostic_detail=""
2023-03-22T18:14:59.944Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_name=TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add test_terraform_path=/tmp/plugintest-terraform4047039391/terraform test_step_number=2
  error=
  | exit status 1
  | 
  | Error: removing RDS DB Cluster () from Global Cluster (tf-acc-test-1134909169130696077): InvalidParameterValue: Db cluster identifier  is not a valid arn
  | \tstatus code: 400, request id: 7ef3d447-ae6b-406b-9913-2fc5c5527da5
  | 
   test_working_directory=/tmp/plugintest876042364
2023-03-22T18:14:59.944Z [ERROR] sdk.helper_resource: Error running post-test destroy, there may be dangling resources: test_step_number=2 test_working_directory=/tmp/plugintest876042364 test_name=TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
  error=
  | exit status 1
  | 
  | Error: removing RDS DB Cluster () from Global Cluster (tf-acc-test-1134909169130696077): InvalidParameterValue: Db cluster identifier  is not a valid arn
  | \tstatus code: 400, request id: 7ef3d447-ae6b-406b-9913-2fc5c5527da5
  | 
   test_terraform_path=/tmp/plugintest-terraform4047039391/terraform
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: removing RDS DB Cluster () from Global Cluster (tf-acc-test-1134909169130696077): InvalidParameterValue: Db cluster identifier  is not a valid arn
        	status code: 400, request id: 7ef3d447-ae6b-406b-9913-2fc5c5527da5
        
--- FAIL: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (158.12s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
--- PASS: TestAccRDSCluster_scaling (409.21s)
=== CONT  TestAccRDSCluster_port
2023-03-22T18:20:04.104Z [ERROR] sdk.proto: Response contains error diagnostic: tf_req_id=9226141d-6ccf-3519-099b-dd1b884afd75 tf_proto_version=5.3 tf_rpc=ApplyResourceChange diagnostic_detail="" diagnostic_severity=ERROR
  diagnostic_summary=
  | creating RDS Cluster (tf-acc-test-7324134314835416017): InvalidParameterCombination: The Parameter Group default.aurora-postgresql13 with DBParameterGroupFamily aurora-postgresql13 cannot be used for this instance. Please use a Parameter Group with DBParameterGroupFamily aurora-postgresql14
  | \tstatus code: 400, request id: a2507e48-8dc0-406c-97ae-e3e812662f17
   tf_resource_type=aws_rds_cluster tf_provider_addr=registry.terraform.io/hashicorp/aws
2023-03-22T18:20:04.135Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_name=TestAccRDSCluster_port test_terraform_path=/tmp/plugintest-terraform195080357/terraform test_working_directory=/tmp/plugintest3400407291 test_step_number=1
  error=
  | exit status 1
  | 
  | Error: creating RDS Cluster (tf-acc-test-7324134314835416017): InvalidParameterCombination: The Parameter Group default.aurora-postgresql13 with DBParameterGroupFamily aurora-postgresql13 cannot be used for this instance. Please use a Parameter Group with DBParameterGroupFamily aurora-postgresql14
  | \tstatus code: 400, request id: a2507e48-8dc0-406c-97ae-e3e812662f17
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "test":
  |    2: resource "aws_rds_cluster" "test" {
  | 
  
2023-03-22T18:20:04.135Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccRDSCluster_port test_terraform_path=/tmp/plugintest-terraform195080357/terraform test_working_directory=/tmp/plugintest3400407291 test_step_number=1
  error=
  | Error running apply: exit status 1
  | 
  | Error: creating RDS Cluster (tf-acc-test-7324134314835416017): InvalidParameterCombination: The Parameter Group default.aurora-postgresql13 with DBParameterGroupFamily aurora-postgresql13 cannot be used for this instance. Please use a Parameter Group with DBParameterGroupFamily aurora-postgresql14
  | \tstatus code: 400, request id: a2507e48-8dc0-406c-97ae-e3e812662f17
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "test":
  |    2: resource "aws_rds_cluster" "test" {
  | 
  
    cluster_test.go:1616: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating RDS Cluster (tf-acc-test-7324134314835416017): InvalidParameterCombination: The Parameter Group default.aurora-postgresql13 with DBParameterGroupFamily aurora-postgresql13 cannot be used for this instance. Please use a Parameter Group with DBParameterGroupFamily aurora-postgresql14
        	status code: 400, request id: a2507e48-8dc0-406c-97ae-e3e812662f17
        
          with aws_rds_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "test":
           2: resource "aws_rds_cluster" "test" {
        
--- FAIL: TestAccRDSCluster_port (9.09s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (461.75s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (481.99s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (199.44s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
2023-03-22T18:23:31.313Z [ERROR] sdk.proto: Response contains error diagnostic: tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 diagnostic_severity=ERROR
  diagnostic_summary=
  | creating RDS Cluster (tf-acc-test-6692667182441941694-source): InvalidParameterCombination: Cannot find version null for aurora
  | \tstatus code: 400, request id: 0a45989c-e96b-4f4a-bc09-85abeafd98f3
   diagnostic_detail="" tf_rpc=ApplyResourceChange tf_resource_type=aws_rds_cluster tf_req_id=f721bc04-7171-a72f-a27a-6c5fdda606fc
2023-03-22T18:23:31.327Z [WARN]  sdk.helper_resource: Error running Terraform CLI command:
  error=
  | exit status 1
  | 
  | Error: creating RDS Cluster (tf-acc-test-6692667182441941694-source): InvalidParameterCombination: Cannot find version null for aurora
  | \tstatus code: 400, request id: 0a45989c-e96b-4f4a-bc09-85abeafd98f3
  | 
  |   with aws_rds_cluster.source,
  |   on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "source":
  |    2: resource "aws_rds_cluster" "source" {
  | 
   test_terraform_path=/tmp/plugintest-terraform2507108413/terraform test_name=TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery test_working_directory=/tmp/plugintest2190935850 test_step_number=1
2023-03-22T18:23:31.327Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery test_working_directory=/tmp/plugintest2190935850 test_step_number=1 test_terraform_path=/tmp/plugintest-terraform2507108413/terraform
  error=
  | Error running apply: exit status 1
  | 
  | Error: creating RDS Cluster (tf-acc-test-6692667182441941694-source): InvalidParameterCombination: Cannot find version null for aurora
  | \tstatus code: 400, request id: 0a45989c-e96b-4f4a-bc09-85abeafd98f3
  | 
  |   with aws_rds_cluster.source,
  |   on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "source":
  |    2: resource "aws_rds_cluster" "source" {
  | 
  
    cluster_test.go:1843: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating RDS Cluster (tf-acc-test-6692667182441941694-source): InvalidParameterCombination: Cannot find version null for aurora
        	status code: 400, request id: 0a45989c-e96b-4f4a-bc09-85abeafd98f3
        
          with aws_rds_cluster.source,
          on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "source":
           2: resource "aws_rds_cluster" "source" {
        
--- FAIL: TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery (7.68s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (145.84s)
=== CONT  TestAccRDSCluster_EngineMode_global
--- PASS: TestAccRDSCluster_onlyMajorVersion (836.12s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
2023-03-22T18:26:08.862Z [ERROR] sdk.proto: Response contains error diagnostic: tf_resource_type=aws_rds_global_cluster tf_req_id=45971fda-bf5e-fe29-89ca-4faee2650946 tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3
  diagnostic_summary=
  | creating RDS Global Cluster: InvalidParameterValue: The requested engine version was not found or does not support global functionality
  | \tstatus code: 400, request id: a3c0f15b-01ce-41d7-973e-6f4efe4af680
   diagnostic_detail="" diagnostic_severity=ERROR tf_rpc=ApplyResourceChange
2023-03-22T18:26:10.784Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_step_number=1 test_name=TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
  error=
  | exit status 1
  | 
  | Error: creating RDS Global Cluster: InvalidParameterValue: The requested engine version was not found or does not support global functionality
  | \tstatus code: 400, request id: a3c0f15b-01ce-41d7-973e-6f4efe4af680
  | 
  |   with aws_rds_global_cluster.test,
  |   on terraform_plugin_test.tf line 18, in resource "aws_rds_global_cluster" "test":
  |   18: resource "aws_rds_global_cluster" "test" {
  | 
   test_terraform_path=/tmp/plugintest-terraform2322725888/terraform test_working_directory=/tmp/plugintest871236905
2023-03-22T18:26:10.784Z [ERROR] sdk.helper_resource: Unexpected error: test_step_number=1
  error=
  | Error running apply: exit status 1
  | 
  | Error: creating RDS Global Cluster: InvalidParameterValue: The requested engine version was not found or does not support global functionality
  | \tstatus code: 400, request id: a3c0f15b-01ce-41d7-973e-6f4efe4af680
  | 
  |   with aws_rds_global_cluster.test,
  |   on terraform_plugin_test.tf line 18, in resource "aws_rds_global_cluster" "test":
  |   18: resource "aws_rds_global_cluster" "test" {
  | 
   test_name=TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding test_terraform_path=/tmp/plugintest-terraform2322725888/terraform test_working_directory=/tmp/plugintest871236905
    cluster_test.go:1443: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating RDS Global Cluster: InvalidParameterValue: The requested engine version was not found or does not support global functionality
        	status code: 400, request id: a3c0f15b-01ce-41d7-973e-6f4efe4af680
        
          with aws_rds_global_cluster.test,
          on terraform_plugin_test.tf line 18, in resource "aws_rds_global_cluster" "test":
          18: resource "aws_rds_global_cluster" "test" {
        
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (191.71s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- FAIL: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (14.22s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
--- PASS: TestAccRDSCluster_EngineMode_global (171.16s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (165.55s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (527.81s)
=== CONT  TestAccRDSCluster_engineVersionWithPrimaryInstance
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (1964.47s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (451.79s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (431.29s)
=== CONT  TestAccRDSCluster_engineVersion
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2283.99s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
--- PASS: TestAccRDSCluster_storageType (2051.02s)
=== CONT  TestAccRDSCluster_EngineMode_parallelQuery
2023-03-22T18:40:12.299Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_detail="" diagnostic_severity=ERROR
  diagnostic_summary=
  | creating RDS Cluster (tf-acc-test-2725944744424757039): InvalidParameterCombination: Cannot find version null for aurora
  | \tstatus code: 400, request id: 9916b686-335c-402c-834e-191529fffc36
   tf_resource_type=aws_rds_cluster tf_proto_version=5.3 tf_provider_addr=registry.terraform.io/hashicorp/aws tf_req_id=f7f800df-c51f-dbcd-bf4a-6120c39b4fdb tf_rpc=ApplyResourceChange
2023-03-22T18:40:12.315Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_name=TestAccRDSCluster_EngineMode_parallelQuery test_terraform_path=/tmp/plugintest-terraform1697211343/terraform test_working_directory=/tmp/plugintest4272168342 test_step_number=1
  error=
  | exit status 1
  | 
  | Error: creating RDS Cluster (tf-acc-test-2725944744424757039): InvalidParameterCombination: Cannot find version null for aurora
  | \tstatus code: 400, request id: 9916b686-335c-402c-834e-191529fffc36
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "test":
  |    2: resource "aws_rds_cluster" "test" {
  | 
  
2023-03-22T18:40:12.315Z [ERROR] sdk.helper_resource: Unexpected error: test_step_number=1 test_name=TestAccRDSCluster_EngineMode_parallelQuery test_terraform_path=/tmp/plugintest-terraform1697211343/terraform test_working_directory=/tmp/plugintest4272168342
  error=
  | Error running apply: exit status 1
  | 
  | Error: creating RDS Cluster (tf-acc-test-2725944744424757039): InvalidParameterCombination: Cannot find version null for aurora
  | \tstatus code: 400, request id: 9916b686-335c-402c-834e-191529fffc36
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "test":
  |    2: resource "aws_rds_cluster" "test" {
  | 
  
    cluster_test.go:1125: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating RDS Cluster (tf-acc-test-2725944744424757039): InvalidParameterCombination: Cannot find version null for aurora
        	status code: 400, request id: 9916b686-335c-402c-834e-191529fffc36
        
          with aws_rds_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_rds_cluster" "test":
           2: resource "aws_rds_cluster" "test" {
        
--- FAIL: TestAccRDSCluster_EngineMode_parallelQuery (7.79s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (443.51s)
=== CONT  TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_allocatedStorage (1876.72s)
=== CONT  TestAccRDSCluster_EngineMode_multiMaster
--- PASS: TestAccRDSCluster_iops (2038.77s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (153.96s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
2023/03/22 18:42:51 [WARN] WaitForState timeout after 5m0s
2023/03/22 18:42:51 [WARN] WaitForState starting 30s refresh grace period
2023-03-22T18:42:51.146Z [ERROR] sdk.proto: Response contains error diagnostic: tf_rpc=ApplyResourceChange tf_resource_type=aws_rds_cluster tf_req_id=981381e4-944b-c157-ae8a-93f2ba511e94 tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 diagnostic_detail="" diagnostic_severity=ERROR
  diagnostic_summary=
  | updating RDS Cluster (tf-acc-test-5679252069249504503): InvalidDBClusterStateFault: Cannot modify engine version without a healthy primary instance in DB cluster: tf-acc-test-5679252069249504503
  | \tstatus code: 400, request id: bc0b511e-a96c-49e9-bb49-f4ec14758fee
  
2023-03-22T18:42:51.160Z [WARN]  sdk.helper_resource: Error running Terraform CLI command:
  error=
  | exit status 1
  | 
  | Error: updating RDS Cluster (tf-acc-test-5679252069249504503): InvalidDBClusterStateFault: Cannot modify engine version without a healthy primary instance in DB cluster: tf-acc-test-5679252069249504503
  | \tstatus code: 400, request id: bc0b511e-a96c-49e9-bb49-f4ec14758fee
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 17, in resource "aws_rds_cluster" "test":
  |   17: resource "aws_rds_cluster" "test" {
  | 
   test_working_directory=/tmp/plugintest1024455226 test_step_number=2 test_name=TestAccRDSCluster_engineVersion test_terraform_path=/tmp/plugintest-terraform862763699/terraform

--- PASS: TestAccRDSCluster_identifierPrefix (150.66s)
=== CONT  TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_engineVersion (473.63s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
2023-03-22T18:44:11.666Z [ERROR] sdk.proto: Response contains error diagnostic: tf_rpc=ApplyResourceChange tf_resource_type=aws_rds_cluster diagnostic_detail="" diagnostic_severity=ERROR diagnostic_summary="existing RDS Clusters cannot be migrated between existing RDS Global Clusters" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_req_id=c7988ee5-1aee-9f7e-2274-8f9a4146715b tf_proto_version=5.3
2023-03-22T18:44:11.683Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_working_directory=/tmp/plugintest2240563109 test_step_number=2
  error=
  | exit status 1
  | 
  | Error: existing RDS Clusters cannot be migrated between existing RDS Global Clusters
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 9, in resource "aws_rds_cluster" "test":
  |    9: resource "aws_rds_cluster" "test" {
  | 
   test_name=TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update test_terraform_path=/tmp/plugintest-terraform4232136089/terraform
2023-03-22T18:44:11.683Z [ERROR] sdk.helper_resource: Expected an error with pattern (Existing RDS Clusters cannot be migrated between existing RDS Global Clusters): test_name=TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update test_terraform_path=/tmp/plugintest-terraform4232136089/terraform test_working_directory=/tmp/plugintest2240563109 test_step_number=2
  error=
  | Error running apply: exit status 1
  | 
  | Error: existing RDS Clusters cannot be migrated between existing RDS Global Clusters
  | 
  |   with aws_rds_cluster.test,
  |   on terraform_plugin_test.tf line 9, in resource "aws_rds_cluster" "test":
  |    9: resource "aws_rds_cluster" "test" {
  | 
  
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
    cluster_test.go:1307: Step 2/2, expected an error with pattern, no match on: Error running apply: exit status 1
        
        Error: existing RDS Clusters cannot be migrated between existing RDS Global Clusters
        
          with aws_rds_cluster.test,
          on terraform_plugin_test.tf line 9, in resource "aws_rds_cluster" "test":
           9: resource "aws_rds_cluster" "test" {
        
--- PASS: TestAccRDSCluster_EngineMode_multiMaster (168.16s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (513.83s)
=== CONT  TestAccRDSCluster_identifierGenerated
--- FAIL: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (162.10s)
=== CONT  TestAccRDSCluster_iamAuth
--- PASS: TestAccRDSCluster_tags (189.72s)
=== CONT  TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2473.07s)
=== CONT  TestAccRDSCluster_engineMode
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (158.59s)
=== CONT  TestAccRDSCluster_deletionProtection
--- PASS: TestAccRDSCluster_identifierGenerated (181.67s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSCluster_iamAuth (150.45s)
=== CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
2023/03/22 18:49:44 [WARN] RDS Cluster (tf-acc-test-1847113501320024564) not found, removing from state
--- PASS: TestAccRDSCluster_disappears (178.49s)
=== CONT  TestAccRDSCluster_backupsUpdate
--- PASS: TestAccRDSCluster_deletionProtection (245.63s)
=== CONT  TestAccRDSCluster_copyTagsToSnapshot
--- PASS: TestAccRDSCluster_backupsUpdate (184.78s)
=== CONT  TestAccRDSCluster_snapshotIdentifier
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (422.31s)
=== CONT  TestAccRDSCluster_Scaling_defaultMinCapacity
--- PASS: TestAccRDSCluster_engineMode (491.38s)
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (250.75s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1791.39s)
--- PASS: TestAccRDSCluster_snapshotIdentifier (421.87s)
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (333.87s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2605.78s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (2695.79s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (2169.84s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2310.13s)
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2147.34s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	5132.054s
FAIL
make: *** [testacc] Error 1

@AdamTylerLynch
Copy link
Collaborator

AccTests for rds_cluster_data_source

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 10 -run='TestAccRDSClusterDataSource_'  -timeout 180m
=== RUN   TestAccRDSClusterDataSource_basic
=== PAUSE TestAccRDSClusterDataSource_basic
=== RUN   TestAccRDSClusterDataSource_ManagedMasterPassword_managed
=== PAUSE TestAccRDSClusterDataSource_ManagedMasterPassword_managed
=== CONT  TestAccRDSClusterDataSource_basic
=== CONT  TestAccRDSClusterDataSource_ManagedMasterPassword_managed
--- PASS: TestAccRDSClusterDataSource_ManagedMasterPassword_managed (171.14s)
--- PASS: TestAccRDSClusterDataSource_basic (211.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	212.094s

@fergoid fergoid changed the title [WIP] feat(28538): add manage master user password flag feat(28538): add manage master user password flag Mar 23, 2023
@AdamTylerLynch
Copy link
Collaborator

AdamTylerLynch commented Mar 24, 2023

AccTests for TestAccRDSInstance_Managed*

Output from acceptance testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 10 -run='TestAccRDSInstance_Managed'  -timeout 180m
=== RUN   TestAccRDSInstance_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managed
=== RUN   TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== CONT  TestAccRDSInstance_ManagedMasterPassword_managed
=== CONT  TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== CONT  TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey (527.76s)
--- PASS: TestAccRDSInstance_ManagedMasterPassword_managed (551.44s)
--- PASS: TestAccRDSInstance_ManagedMasterPassword_convertToManaged (684.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	684.529s

@AdamTylerLynch
Copy link
Collaborator

AccTests for TestAccRDSInstance_

note, tests do not fully run due to timeout issues on my side. Recommend running full tests.

Output from acceptance tests

TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 10 -run='TestAccRDSInstance_'  -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_manage_password
=== PAUSE TestAccRDSInstance_manage_password
=== RUN   TestAccRDSInstance_identifierPrefix
=== PAUSE TestAccRDSInstance_identifierPrefix
=== RUN   TestAccRDSInstance_identifierGenerated
=== PAUSE TestAccRDSInstance_identifierGenerated
=== RUN   TestAccRDSInstance_disappears
=== PAUSE TestAccRDSInstance_disappears
=== RUN   TestAccRDSInstance_tags
=== PAUSE TestAccRDSInstance_tags
=== RUN   TestAccRDSInstance_nameDeprecated
=== PAUSE TestAccRDSInstance_nameDeprecated
=== RUN   TestAccRDSInstance_onlyMajorVersion
=== PAUSE TestAccRDSInstance_onlyMajorVersion
=== RUN   TestAccRDSInstance_kmsKey
=== PAUSE TestAccRDSInstance_kmsKey
=== RUN   TestAccRDSInstance_customIAMInstanceProfile
=== PAUSE TestAccRDSInstance_customIAMInstanceProfile
=== RUN   TestAccRDSInstance_subnetGroup
=== PAUSE TestAccRDSInstance_subnetGroup
=== RUN   TestAccRDSInstance_networkType
=== PAUSE TestAccRDSInstance_networkType
=== RUN   TestAccRDSInstance_optionGroup
=== PAUSE TestAccRDSInstance_optionGroup
=== RUN   TestAccRDSInstance_iamAuth
=== PAUSE TestAccRDSInstance_iamAuth
=== RUN   TestAccRDSInstance_allowMajorVersionUpgrade
=== PAUSE TestAccRDSInstance_allowMajorVersionUpgrade
=== RUN   TestAccRDSInstance_dbSubnetGroupName
=== PAUSE TestAccRDSInstance_dbSubnetGroupName
=== RUN   TestAccRDSInstance_DBSubnetGroupName_ramShared
=== PAUSE TestAccRDSInstance_DBSubnetGroupName_ramShared
=== RUN   TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_deletionProtection
=== PAUSE TestAccRDSInstance_deletionProtection
=== RUN   TestAccRDSInstance_finalSnapshotIdentifier
=== PAUSE TestAccRDSInstance_finalSnapshotIdentifier
=== RUN   TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
=== PAUSE TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
=== RUN   TestAccRDSInstance_isAlreadyBeingDeleted
=== PAUSE TestAccRDSInstance_isAlreadyBeingDeleted
=== RUN   TestAccRDSInstance_maxAllocatedStorage
=== PAUSE TestAccRDSInstance_maxAllocatedStorage
=== RUN   TestAccRDSInstance_password
=== PAUSE TestAccRDSInstance_password
=== RUN   TestAccRDSInstance_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managed
=== RUN   TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== RUN   TestAccRDSInstance_ReplicateSourceDB_basic
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_basic
=== RUN   TestAccRDSInstance_ReplicateSourceDB_namePrefix
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_namePrefix
=== RUN   TestAccRDSInstance_ReplicateSourceDB_nameGenerated
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_nameGenerated
=== RUN   TestAccRDSInstance_ReplicateSourceDB_addLater
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_addLater
=== RUN   TestAccRDSInstance_ReplicateSourceDB_allocatedStorage
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_allocatedStorage
=== RUN   TestAccRDSInstance_ReplicateSourceDB_iops
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_iops
=== RUN   TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops
=== RUN   TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade
=== RUN   TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade
=== RUN   TestAccRDSInstance_ReplicateSourceDB_availabilityZone
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_availabilityZone
=== RUN   TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod
=== RUN   TestAccRDSInstance_ReplicateSourceDB_backupWindow
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_backupWindow
=== RUN   TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName
=== RUN   TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_ramShared
=== PAUSE TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_ramShared
=== RUN   TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_ReplicateSourceDB_deletionProtection
    acctest.go:75: CreateDBInstanceReadReplica API currently ignores DeletionProtection=true with SourceDBInstanceIdentifier set
--- SKIP: TestAccRDSInstance_ReplicateSourceDB_deletionProtection (0.00s)
=== RUN   TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled
=== RUN   TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow
=== RUN   TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage
=== RUN   TestAccRDSInstance_ReplicateSourceDB_monitoring
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_monitoring
=== RUN   TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists
=== RUN   TestAccRDSInstance_ReplicateSourceDB_multiAZ
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_multiAZ
=== RUN   TestAccRDSInstance_ReplicateSourceDB_networkType
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_networkType
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica
=== RUN   TestAccRDSInstance_ReplicateSourceDB_port
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_port
=== RUN   TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier
=== RUN   TestAccRDSInstance_ReplicateSourceDB_replicaMode
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_replicaMode
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep
=== RUN   TestAccRDSInstance_S3Import_basic
    acctest.go:75: RestoreDBInstanceFromS3 cannot restore from MySQL version 5.6
--- SKIP: TestAccRDSInstance_S3Import_basic (0.00s)
=== RUN   TestAccRDSInstance_SnapshotIdentifier_basic
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_basic
=== RUN   TestAccRDSInstance_SnapshotIdentifier_namePrefix
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_namePrefix
=== RUN   TestAccRDSInstance_SnapshotIdentifier_nameGenerated
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_nameGenerated
=== RUN   TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
=== RUN   TestAccRDSInstance_SnapshotIdentifier_allocatedStorage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_allocatedStorage
=== RUN   TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== RUN   TestAccRDSInstance_SnapshotIdentifier_allowMajorVersionUpgrade
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_allowMajorVersionUpgrade
=== RUN   TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade
=== RUN   TestAccRDSInstance_SnapshotIdentifier_availabilityZone
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_availabilityZone
=== RUN   TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride
=== RUN   TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset
=== RUN   TestAccRDSInstance_SnapshotIdentifier_backupWindow
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_backupWindow
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
=== RUN   TestAccRDSInstance_SnapshotIdentifier_deletionProtection
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_deletionProtection
=== RUN   TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled
=== RUN   TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow
=== RUN   TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage
=== RUN   TestAccRDSInstance_SnapshotIdentifier_monitoring
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_monitoring
=== RUN   TestAccRDSInstance_SnapshotIdentifier_multiAZ
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_multiAZ
=== RUN   TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer
=== RUN   TestAccRDSInstance_SnapshotIdentifier_parameterGroupName
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_parameterGroupName
=== RUN   TestAccRDSInstance_SnapshotIdentifier_port
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_port
=== RUN   TestAccRDSInstance_SnapshotIdentifier_tags
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_tags
=== RUN   TestAccRDSInstance_SnapshotIdentifier_tagsRemove
    acctest.go:75: To be fixed: https://github.com/hashicorp/terraform-provider-aws/issues/26808
--- SKIP: TestAccRDSInstance_SnapshotIdentifier_tagsRemove (0.00s)
=== RUN   TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags
=== RUN   TestAccRDSInstance_monitoringInterval
=== PAUSE TestAccRDSInstance_monitoringInterval
=== RUN   TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled
=== PAUSE TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled
=== RUN   TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved
=== PAUSE TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved
=== RUN   TestAccRDSInstance_MonitoringRoleARN_removedToEnabled
=== PAUSE TestAccRDSInstance_MonitoringRoleARN_removedToEnabled
=== RUN   TestAccRDSInstance_separateIopsUpdate
=== PAUSE TestAccRDSInstance_separateIopsUpdate
=== RUN   TestAccRDSInstance_portUpdate
=== PAUSE TestAccRDSInstance_portUpdate
=== RUN   TestAccRDSInstance_MSSQL_tz
=== PAUSE TestAccRDSInstance_MSSQL_tz
=== RUN   TestAccRDSInstance_MSSQL_domain
=== PAUSE TestAccRDSInstance_MSSQL_domain
=== RUN   TestAccRDSInstance_MSSQL_domainSnapshotRestore
=== PAUSE TestAccRDSInstance_MSSQL_domainSnapshotRestore
=== RUN   TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion
=== PAUSE TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion
=== RUN   TestAccRDSInstance_minorVersion
=== PAUSE TestAccRDSInstance_minorVersion
=== RUN   TestAccRDSInstance_cloudWatchLogsExport
=== PAUSE TestAccRDSInstance_cloudWatchLogsExport
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSInstance_noDeleteAutomatedBackups
=== PAUSE TestAccRDSInstance_noDeleteAutomatedBackups
=== RUN   TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled
=== PAUSE TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled
=== RUN   TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled
=== PAUSE TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled
=== RUN   TestAccRDSInstance_performanceInsightsKMSKeyID
=== PAUSE TestAccRDSInstance_performanceInsightsKMSKeyID
=== RUN   TestAccRDSInstance_performanceInsightsRetentionPeriod
=== PAUSE TestAccRDSInstance_performanceInsightsRetentionPeriod
=== RUN   TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled
=== RUN   TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled
=== RUN   TestAccRDSInstance_caCertificateIdentifier
=== PAUSE TestAccRDSInstance_caCertificateIdentifier
=== RUN   TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== RUN   TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
=== RUN   TestAccRDSInstance_RestoreToPointInTime_monitoring
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_monitoring
=== RUN   TestAccRDSInstance_NationalCharacterSet_oracle
=== PAUSE TestAccRDSInstance_NationalCharacterSet_oracle
=== RUN   TestAccRDSInstance_NoNationalCharacterSet_oracle
=== PAUSE TestAccRDSInstance_NoNationalCharacterSet_oracle
=== RUN   TestAccRDSInstance_coIPEnabled
=== PAUSE TestAccRDSInstance_coIPEnabled
=== RUN   TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== PAUSE TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== RUN   TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== PAUSE TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== RUN   TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== PAUSE TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== RUN   TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== PAUSE TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== RUN   TestAccRDSInstance_license
=== PAUSE TestAccRDSInstance_license
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
=== RUN   TestAccRDSInstance_BlueGreenDeployment_tags
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_tags
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
=== RUN   TestAccRDSInstance_BlueGreenDeployment_deletionProtection
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_deletionProtection
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== RUN   TestAccRDSInstance_gp3MySQL
=== PAUSE TestAccRDSInstance_gp3MySQL
=== RUN   TestAccRDSInstance_gp3Postgres
=== PAUSE TestAccRDSInstance_gp3Postgres
=== RUN   TestAccRDSInstance_gp3SQLServer
=== PAUSE TestAccRDSInstance_gp3SQLServer
=== RUN   TestAccRDSInstance_storageThroughput
=== PAUSE TestAccRDSInstance_storageThroughput
=== RUN   TestAccRDSInstance_storageTypePostgres
=== PAUSE TestAccRDSInstance_storageTypePostgres
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== CONT  TestAccRDSInstance_storageTypePostgres
=== CONT  TestAccRDSInstance_storageThroughput
=== CONT  TestAccRDSInstance_gp3SQLServer
=== CONT  TestAccRDSInstance_gp3Postgres
=== CONT  TestAccRDSInstance_gp3MySQL
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== CONT  TestAccRDSInstance_BlueGreenDeployment_deletionProtection
=== CONT  TestAccRDSInstance_CoIPEnabled_disabledToEnabled
    acctest.go:1046: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_disabledToEnabled (1.03s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
--- PASS: TestAccRDSInstance_basic (560.18s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_basic
--- PASS: TestAccRDSInstance_storageThroughput (781.51s)
=== CONT  TestAccRDSInstance_coIPEnabled
    acctest.go:1046: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_coIPEnabled (0.43s)
=== CONT  TestAccRDSInstance_NoNationalCharacterSet_oracle
2023-03-23T16:28:02.884Z [ERROR] sdk.proto: Response contains error diagnostic: tf_data_source_type=aws_rds_orderable_db_instance tf_rpc=ReadDataSource diagnostic_detail="" diagnostic_severity=ERROR
  diagnostic_summary=
  | reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 085251e1-f182-4687-968f-80a56b1e3c13
   tf_req_id=ed63eede-6444-acbb-37d4-882fbf8edc6e tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3
2023-03-23T16:28:02.898Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_name=TestAccRDSInstance_NoNationalCharacterSet_oracle test_terraform_path=/tmp/plugintest-terraform2919067110/terraform test_working_directory=/tmp/plugintest2744196579
  error=
  | exit status 1
  | 
  | Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 085251e1-f182-4687-968f-80a56b1e3c13
  | 
  |   with data.aws_rds_orderable_db_instance.test,
  |   on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
  |    2: data "aws_rds_orderable_db_instance" "test" {
  | 
   test_step_number=1
2023-03-23T16:28:02.898Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccRDSInstance_NoNationalCharacterSet_oracle test_terraform_path=/tmp/plugintest-terraform2919067110/terraform test_working_directory=/tmp/plugintest2744196579 test_step_number=1
  error=
  | Error running pre-apply refresh: exit status 1
  | 
  | Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 085251e1-f182-4687-968f-80a56b1e3c13
  | 
  |   with data.aws_rds_orderable_db_instance.test,
  |   on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
  |    2: data "aws_rds_orderable_db_instance" "test" {
  | 
  
    instance_test.go:4405: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
        	status code: 400, request id: 085251e1-f182-4687-968f-80a56b1e3c13
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
           2: data "aws_rds_orderable_db_instance" "test" {
        
--- FAIL: TestAccRDSInstance_NoNationalCharacterSet_oracle (3.18s)
=== CONT  TestAccRDSInstance_NationalCharacterSet_oracle
2023-03-23T16:28:06.159Z [ERROR] sdk.proto: Response contains error diagnostic: tf_data_source_type=aws_rds_orderable_db_instance
  diagnostic_summary=
  | reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 3af66988-6472-43f9-937f-57e401011a35
   diagnostic_detail="" diagnostic_severity=ERROR tf_proto_version=5.3 tf_req_id=635c299b-476b-07d8-3927-dc83c0068b16 tf_provider_addr=registry.terraform.io/hashicorp/aws tf_rpc=ReadDataSource
2023-03-23T16:28:06.172Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_working_directory=/tmp/plugintest1078431847 test_step_number=1
  error=
  | exit status 1
  | 
  | Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 3af66988-6472-43f9-937f-57e401011a35
  | 
  |   with data.aws_rds_orderable_db_instance.test,
  |   on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
  |    2: data "aws_rds_orderable_db_instance" "test" {
  | 
   test_name=TestAccRDSInstance_NationalCharacterSet_oracle test_terraform_path=/tmp/plugintest-terraform1352344593/terraform
2023-03-23T16:28:06.172Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccRDSInstance_NationalCharacterSet_oracle test_terraform_path=/tmp/plugintest-terraform1352344593/terraform test_working_directory=/tmp/plugintest1078431847 test_step_number=1
  error=
  | Error running pre-apply refresh: exit status 1
  | 
  | Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 3af66988-6472-43f9-937f-57e401011a35
  | 
  |   with data.aws_rds_orderable_db_instance.test,
  |   on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
  |    2: data "aws_rds_orderable_db_instance" "test" {
  | 
  
    instance_test.go:4365: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
        	status code: 400, request id: 3af66988-6472-43f9-937f-57e401011a35
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
           2: data "aws_rds_orderable_db_instance" "test" {
        
--- FAIL: TestAccRDSInstance_NationalCharacterSet_oracle (3.28s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_monitoring
--- PASS: TestAccRDSInstance_storageTypePostgres (823.74s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
--- PASS: TestAccRDSInstance_gp3Postgres (886.88s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
--- PASS: TestAccRDSInstance_gp3MySQL (891.78s)
=== CONT  TestAccRDSInstance_caCertificateIdentifier
2023-03-23T16:29:52.731Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_summary="multiple RDS Certificates match the criteria; try changing search query" diagnostic_detail="" diagnostic_severity=ERROR tf_proto_version=5.3 tf_data_source_type=aws_rds_certificate tf_req_id=307ea1ee-5240-0e19-d520-7d0789d06414 tf_rpc=ReadDataSource tf_provider_addr=registry.terraform.io/hashicorp/aws
2023-03-23T16:29:53.757Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_name=TestAccRDSInstance_caCertificateIdentifier test_terraform_path=/tmp/plugintest-terraform3067436789/terraform test_step_number=1
  error=
  | exit status 1
  | 
  | Error: multiple RDS Certificates match the criteria; try changing search query
  | 
  |   with data.aws_rds_certificate.latest,
  |   on terraform_plugin_test.tf line 15, in data "aws_rds_certificate" "latest":
  |   15: data "aws_rds_certificate" "latest" {
  | 
   test_working_directory=/tmp/plugintest1687245069
2023-03-23T16:29:53.757Z [ERROR] sdk.helper_resource: Unexpected error: test_working_directory=/tmp/plugintest1687245069 test_name=TestAccRDSInstance_caCertificateIdentifier test_terraform_path=/tmp/plugintest-terraform3067436789/terraform test_step_number=1
  error=
  | Error running pre-apply refresh: exit status 1
  | 
  | Error: multiple RDS Certificates match the criteria; try changing search query
  | 
  |   with data.aws_rds_certificate.latest,
  |   on terraform_plugin_test.tf line 15, in data "aws_rds_certificate" "latest":
  |   15: data "aws_rds_certificate" "latest" {
  | 
  
    instance_test.go:4224: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: multiple RDS Certificates match the criteria; try changing search query
        
          with data.aws_rds_certificate.latest,
          on terraform_plugin_test.tf line 15, in data "aws_rds_certificate" "latest":
          15: data "aws_rds_certificate" "latest" {
        
--- FAIL: TestAccRDSInstance_caCertificateIdentifier (4.20s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled
--- PASS: TestAccRDSInstance_gp3SQLServer (1105.17s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled
--- PASS: TestAccRDSInstance_SnapshotIdentifier_basic (1132.42s)
=== CONT  TestAccRDSInstance_performanceInsightsRetentionPeriod
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceResourceID (1242.98s)
=== CONT  TestAccRDSInstance_performanceInsightsKMSKeyID
--- PASS: TestAccRDSInstance_BlueGreenDeployment_deletionProtection (2095.56s)
=== CONT  TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled
--- PASS: TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled (1347.29s)
=== CONT  TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier (1487.14s)
=== CONT  TestAccRDSInstance_noDeleteAutomatedBackups
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups (2518.56s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSInstance_RestoreToPointInTime_monitoring (1734.72s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle
2023-03-23T16:57:03.937Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_severity=ERROR
  diagnostic_summary=
  | reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 364bb184-4c74-4b6d-b651-39507fdc8f95
   tf_proto_version=5.3 tf_data_source_type=aws_rds_orderable_db_instance tf_provider_addr=registry.terraform.io/hashicorp/aws tf_rpc=ReadDataSource tf_req_id=cd3a5ef7-16c2-4fb1-d736-f67f5ab6a535 diagnostic_detail=""
2023-03-23T16:57:03.949Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_working_directory=/tmp/plugintest1893070033 test_step_number=1
  error=
  | exit status 1
  | 
  | Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 364bb184-4c74-4b6d-b651-39507fdc8f95
  | 
  |   with data.aws_rds_orderable_db_instance.test,
  |   on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
  |    2: data "aws_rds_orderable_db_instance" "test" {
  | 
   test_name=TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle test_terraform_path=/tmp/plugintest-terraform198294670/terraform
2023-03-23T16:57:03.950Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle test_terraform_path=/tmp/plugintest-terraform198294670/terraform test_working_directory=/tmp/plugintest1893070033 test_step_number=1
  error=
  | Error running pre-apply refresh: exit status 1
  | 
  | Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
  | \tstatus code: 400, request id: 364bb184-4c74-4b6d-b651-39507fdc8f95
  | 
  |   with data.aws_rds_orderable_db_instance.test,
  |   on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
  |    2: data "aws_rds_orderable_db_instance" "test" {
  | 
  
    instance_test.go:3846: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterCombination: The license model 'bring-your-own-license' is restricted.
        	status code: 400, request id: 364bb184-4c74-4b6d-b651-39507fdc8f95
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 2, in data "aws_rds_orderable_db_instance" "test":
           2: data "aws_rds_orderable_db_instance" "test" {
        
--- FAIL: TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle (3.10s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL
--- PASS: TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled (1503.26s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSInstance_performanceInsightsRetentionPeriod (994.93s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
--- PASS: TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled (858.33s)
=== CONT  TestAccRDSInstance_cloudWatchLogsExport
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
--- PASS: TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled (722.09s)
--- PASS: TestAccRDSInstance_noDeleteAutomatedBackups (719.01s)
=== CONT  TestAccRDSInstance_minorVersion
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql (639.39s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_tags
--- PASS: TestAccRDSInstance_performanceInsightsKMSKeyID (1125.11s)
=== CONT  TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica (3346.39s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
--- PASS: TestAccRDSInstance_cloudWatchLogsExport (477.73s)
=== CONT  TestAccRDSInstance_MSSQL_domainSnapshotRestore
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL (981.74s)
=== CONT  TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
    acctest.go:1046: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_snapshotIdentifier (0.37s)
=== CONT  TestAccRDSInstance_MSSQL_domain
--- PASS: TestAccRDSInstance_minorVersion (483.55s)
=== CONT  TestAccRDSInstance_license
2023-03-23T17:14:37.407Z [ERROR] sdk.proto: Response contains error diagnostic: tf_req_id=f051a056-47a7-38f5-8484-fd783e8c6332 tf_proto_version=5.3 tf_data_source_type=aws_rds_engine_version
  diagnostic_summary=
  | reading RDS engine versions: InvalidParameterValue: Unrecognized engine name: oracle-se2
  | \tstatus code: 400, request id: cdb31174-c75a-4cd9-a0f2-24bb8abd3fcf
   diagnostic_detail="" diagnostic_severity=ERROR tf_rpc=ReadDataSource tf_provider_addr=registry.terraform.io/hashicorp/aws
2023-03-23T17:14:37.420Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_terraform_path=/tmp/plugintest-terraform626089886/terraform test_working_directory=/tmp/plugintest2709073628 test_step_number=1
  error=
  | exit status 1
  | 
  | Error: reading RDS engine versions: InvalidParameterValue: Unrecognized engine name: oracle-se2
  | \tstatus code: 400, request id: cdb31174-c75a-4cd9-a0f2-24bb8abd3fcf
  | 
  |   with data.aws_rds_engine_version.default,
  |   on terraform_plugin_test.tf line 2, in data "aws_rds_engine_version" "default":
  |    2: data "aws_rds_engine_version" "default" {
  | 
   test_name=TestAccRDSInstance_license
2023-03-23T17:14:37.420Z [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccRDSInstance_license test_terraform_path=/tmp/plugintest-terraform626089886/terraform test_working_directory=/tmp/plugintest2709073628 test_step_number=1
  error=
  | Error running pre-apply refresh: exit status 1
  | 
  | Error: reading RDS engine versions: InvalidParameterValue: Unrecognized engine name: oracle-se2
  | \tstatus code: 400, request id: cdb31174-c75a-4cd9-a0f2-24bb8abd3fcf
  | 
  |   with data.aws_rds_engine_version.default,
  |   on terraform_plugin_test.tf line 2, in data "aws_rds_engine_version" "default":
  |    2: data "aws_rds_engine_version" "default" {
  | 
  
    instance_test.go:4619: Step 1/3 error: Error running pre-apply refresh: exit status 1
        
        Error: reading RDS engine versions: InvalidParameterValue: Unrecognized engine name: oracle-se2
        	status code: 400, request id: cdb31174-c75a-4cd9-a0f2-24bb8abd3fcf
        
          with data.aws_rds_engine_version.default,
          on terraform_plugin_test.tf line 2, in data "aws_rds_engine_version" "default":
           2: data "aws_rds_engine_version" "default" {
        
--- FAIL: TestAccRDSInstance_license (3.05s)
=== CONT  TestAccRDSInstance_MSSQL_tz
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL (1090.94s)
=== CONT  TestAccRDSInstance_portUpdate
--- PASS: TestAccRDSInstance_BlueGreenDeployment_tags (744.02s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection (4209.47s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSInstance_portUpdate (674.27s)
=== CONT  TestAccRDSInstance_separateIopsUpdate
--- PASS: TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion (1813.54s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
--- PASS: TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled (1132.75s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_removedToEnabled
--- PASS: TestAccRDSInstance_separateIopsUpdate (789.51s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
2023-03-23T17:41:21.180Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_detail="" tf_proto_version=5.3 tf_rpc=ApplyResourceChange tf_req_id=d07c1ddb-4ae9-7e00-1adc-60a4121802f1 tf_provider_addr=registry.terraform.io/hashicorp/awsalternate tf_resource_type=aws_ram_principal_association diagnostic_severity=ERROR diagnostic_summary="associating principal with RAM resource share: UnknownResourceException: Organization o-77777mmmmm could not be found."
2023-03-23T17:41:22.417Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_severity=ERROR diagnostic_summary="associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress." tf_req_id=56496723-a8ea-ab96-1825-0d6d69cac415 tf_provider_addr=registry.terraform.io/hashicorp/awsalternate tf_proto_version=5.3 tf_rpc=ApplyResourceChange tf_resource_type=aws_ram_resource_association diagnostic_detail=""
2023-03-23T17:41:22.435Z [ERROR] sdk.proto: Response contains error diagnostic: tf_proto_version=5.3 tf_rpc=ApplyResourceChange tf_resource_type=aws_ram_resource_association diagnostic_severity=ERROR diagnostic_summary="associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress." diagnostic_detail="" tf_req_id=d650e01d-0dc7-52b5-239e-aeba4ded85bc tf_provider_addr=registry.terraform.io/hashicorp/awsalternate
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion (2545.77s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup (2027.51s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
--- PASS: TestAccRDSInstance_MSSQL_tz (1835.81s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled
--- PASS: TestAccRDSInstance_SnapshotIdentifier_deletionProtection (1366.96s)
=== CONT  TestAccRDSInstance_monitoringInterval
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass (2716.27s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags
2023-03-23T17:49:47.479Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_name=TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared test_terraform_path=/tmp/plugintest-terraform3676145125/terraform test_working_directory=/tmp/plugintest2690536488 test_step_number=1
  error=
  | exit status 1
  | 
  | Error: associating principal with RAM resource share: UnknownResourceException: Organization o-77777mmmmm could not be found.
  | 
  |   with aws_ram_principal_association.test,
  |   on terraform_plugin_test.tf line 63, in resource "aws_ram_principal_association" "test":
  |   63: resource "aws_ram_principal_association" "test" {
  | 
  | 
  | Error: associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
  | 
  |   with aws_ram_resource_association.test[0],
  |   on terraform_plugin_test.tf line 70, in resource "aws_ram_resource_association" "test":
  |   70: resource "aws_ram_resource_association" "test" {
  | 
  | 
  | Error: associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
  | 
  |   with aws_ram_resource_association.test[1],
  |   on terraform_plugin_test.tf line 70, in resource "aws_ram_resource_association" "test":
  |   70: resource "aws_ram_resource_association" "test" {
  | 
  
2023-03-23T17:49:47.479Z [ERROR] sdk.helper_resource: Unexpected error:
  error=
  | Error running apply: exit status 1
  | 
  | Error: associating principal with RAM resource share: UnknownResourceException: Organization o-77777mmmmm could not be found.
  | 
  |   with aws_ram_principal_association.test,
  |   on terraform_plugin_test.tf line 63, in resource "aws_ram_principal_association" "test":
  |   63: resource "aws_ram_principal_association" "test" {
  | 
  | 
  | Error: associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
  | 
  |   with aws_ram_resource_association.test[0],
  |   on terraform_plugin_test.tf line 70, in resource "aws_ram_resource_association" "test":
  |   70: resource "aws_ram_resource_association" "test" {
  | 
  | 
  | Error: associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
  | 
  |   with aws_ram_resource_association.test[1],
  |   on terraform_plugin_test.tf line 70, in resource "aws_ram_resource_association" "test":
  |   70: resource "aws_ram_resource_association" "test" {
  | 
   test_name=TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared test_terraform_path=/tmp/plugintest-terraform3676145125/terraform test_working_directory=/tmp/plugintest2690536488 test_step_number=1
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
    instance_test.go:2738: Step 1/1 error: Error running apply: exit status 1
        
        Error: associating principal with RAM resource share: UnknownResourceException: Organization o-77777mmmmm could not be found.
        
          with aws_ram_principal_association.test,
          on terraform_plugin_test.tf line 63, in resource "aws_ram_principal_association" "test":
          63: resource "aws_ram_principal_association" "test" {
        
        
        Error: associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
        
          with aws_ram_resource_association.test[0],
          on terraform_plugin_test.tf line 70, in resource "aws_ram_resource_association" "test":
          70: resource "aws_ram_resource_association" "test" {
        
        
        Error: associating RAM Resource Share: InvalidParameterException: The resource you are attempting to share can only be shared within your AWS Organization. This error may also occur if you have not enabled sharing with your AWS organization, or that onboarding process is still in progress.
        
          with aws_ram_resource_association.test[1],
          on terraform_plugin_test.tf line 70, in resource "aws_ram_resource_association" "test":
          70: resource "aws_ram_resource_association" "test" {
        
--- PASS: TestAccRDSInstance_MonitoringRoleARN_removedToEnabled (803.08s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_backupWindow
--- FAIL: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared (805.45s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved (775.07s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_tags
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs (1272.76s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset
--- PASS: TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled (936.20s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_port
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName (1196.13s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride
--- PASS: TestAccRDSInstance_MSSQL_domain (3469.61s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_parameterGroupName
--- PASS: TestAccRDSInstance_monitoringInterval (1410.88s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_availabilityZone
--- PASS: TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags (1326.39s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer
--- PASS: TestAccRDSInstance_MSSQL_domainSnapshotRestore (3634.32s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupWindow (1233.41s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_multiAZ

@AdamTylerLynch
Copy link
Collaborator

AccTests for TestAccRDSClusterDataSource_

Output for acceptance tests

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 10 -run='TestAccRDSInstanceDataSource_'  -timeout 180m
=== RUN   TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== RUN   TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
=== CONT  TestAccRDSInstanceDataSource_basic
=== CONT  TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
2023-03-22T22:12:55.516Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 tf_resource_type=aws_db_instance diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" tf_req_id=5d229db6-4fc9-c82b-d657-e4700bb4c1ef tf_rpc=ValidateResourceTypeConfig diagnostic_attribute="AttributeName(\"name\")" diagnostic_detail="Use db_name instead"
2023-03-22T22:12:55.531Z [WARN]  sdk.proto: Response contains warning diagnostic: diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" tf_req_id=79efa4d8-078b-f28d-d2fb-c3fb5c21f0bf tf_proto_version=5.3 tf_resource_type=aws_db_instance diagnostic_detail="Use db_name instead" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_rpc=ValidateResourceTypeConfig diagnostic_attribute="AttributeName(\"name\")"
2023-03-22T22:13:00.244Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_rpc=ValidateResourceTypeConfig tf_resource_type=aws_db_instance tf_proto_version=5.3 diagnostic_detail="Use db_name instead" tf_req_id=a3de543c-6818-3e65-1a91-617b06fa8ab9 tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_attribute="AttributeName(\"name\")" diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated"
2023-03-22T22:13:00.378Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_rpc=ValidateResourceTypeConfig tf_req_id=c0d43cf8-7c65-ee27-7145-67b2d661a0fd tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 tf_resource_type=aws_db_instance diagnostic_detail="Use db_name instead" diagnostic_attribute="AttributeName(\"name\")" diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated"
2023-03-22T22:13:01.075Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_attribute="AttributeName(\"name\")" diagnostic_detail="Use db_name instead" diagnostic_severity=WARNING tf_proto_version=5.3 tf_rpc=ValidateResourceTypeConfig tf_req_id=236ff0b1-5aa2-9705-6cf4-8e72b7c4be2c tf_resource_type=aws_db_instance diagnostic_summary="Argument is deprecated"
2023-03-22T22:13:01.227Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_resource_type=aws_db_instance tf_proto_version=5.3 diagnostic_detail="Use db_name instead" diagnostic_summary="Argument is deprecated" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_req_id=12a33047-64b8-1d7b-5a95-dc962bb13f6c diagnostic_severity=WARNING diagnostic_attribute="AttributeName(\"name\")" tf_rpc=ValidateResourceTypeConfig
2023-03-22T22:13:06.116Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_resource_type=aws_db_instance tf_req_id=fd24db2b-e9db-475b-a5e7-7989061fe414 tf_proto_version=5.3 diagnostic_summary="Argument is deprecated" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_rpc=ValidateResourceTypeConfig diagnostic_detail="Use db_name instead" diagnostic_severity=WARNING diagnostic_attribute="AttributeName(\"name\")"
2023-03-22T22:13:06.172Z [WARN]  sdk.proto: Response contains warning diagnostic: diagnostic_summary="Argument is deprecated" diagnostic_attribute="AttributeName(\"name\")" tf_proto_version=5.3 tf_resource_type=aws_db_instance tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_severity=WARNING tf_rpc=ValidateResourceTypeConfig tf_req_id=0b983d4b-c2ba-7cca-33c4-f0f7d2cd12e4 diagnostic_detail="Use db_name instead"
2023-03-22T22:13:12.457Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_proto_version=5.3 tf_rpc=ValidateResourceTypeConfig tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_detail="Use db_name instead" diagnostic_summary="Argument is deprecated" tf_req_id=64a1ff8f-8dd2-05c8-e4c1-86be6b53ba78 tf_resource_type=aws_db_instance diagnostic_severity=WARNING diagnostic_attribute="AttributeName(\"name\")"
2023-03-22T22:13:12.580Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_rpc=ValidateResourceTypeConfig tf_req_id=8590b24d-cb2b-b349-e458-9ae23ce1288a tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_attribute="AttributeName(\"name\")" tf_proto_version=5.3 tf_resource_type=aws_db_instance diagnostic_detail="Use db_name instead" diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated"
2023-03-22T22:16:59.769Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_resource_type=aws_db_instance tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 diagnostic_severity=WARNING tf_req_id=71ef8509-8a3b-ca5c-1225-67d1684a931c tf_rpc=ValidateResourceTypeConfig diagnostic_detail="Use db_name instead" diagnostic_summary="Argument is deprecated" diagnostic_attribute="AttributeName(\"name\")"
2023-03-22T22:17:04.638Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_req_id=09e5b4b8-a42c-dd44-4be9-31a961e60750 tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 diagnostic_detail="Use db_name instead" diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" tf_rpc=ValidateResourceTypeConfig tf_resource_type=aws_db_instance diagnostic_attribute="AttributeName(\"name\")"
2023-03-22T22:17:06.364Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_proto_version=5.3 tf_rpc=ValidateResourceTypeConfig diagnostic_detail="Use db_name instead" diagnostic_severity=WARNING tf_req_id=470b9c24-01dd-356f-f70e-89887290fe1e tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_attribute="AttributeName(\"name\")" tf_resource_type=aws_db_instance diagnostic_summary="Argument is deprecated"
2023-03-22T22:17:10.830Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_rpc=ValidateResourceTypeConfig tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_attribute="AttributeName(\"name\")" tf_proto_version=5.3 tf_resource_type=aws_db_instance tf_req_id=1cb2c9da-780d-e8a9-014c-156666888753 diagnostic_detail="Use db_name instead" diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated"
2023-03-22T22:17:11.938Z [WARN]  sdk.proto: Response contains warning diagnostic: diagnostic_detail="Use db_name instead" diagnostic_summary="Argument is deprecated" tf_req_id=c42f462e-d1ed-370b-2bb1-ff0b597ad08b tf_proto_version=5.3 tf_rpc=ValidateResourceTypeConfig diagnostic_attribute="AttributeName(\"name\")" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_resource_type=aws_db_instance diagnostic_severity=WARNING
2023-03-22T22:17:14.502Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_resource_type=aws_db_instance diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" tf_req_id=e4b56d94-c2ca-590c-1a60-61d2ac4b5b64 tf_proto_version=5.3 diagnostic_detail="Use db_name instead" diagnostic_attribute="AttributeName(\"name\")" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_rpc=ValidateResourceTypeConfig
2023-03-22T22:17:16.890Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_proto_version=5.3 tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" tf_req_id=4cf91b89-7f96-124e-dc20-467b45eb3082 tf_rpc=ValidateResourceTypeConfig tf_resource_type=aws_db_instance diagnostic_detail="Use db_name instead" diagnostic_attribute="AttributeName(\"name\")"
2023-03-22T22:17:18.024Z [WARN]  sdk.helper_schema: Previously configured provider being re-configured. This can cause issues in concurrent testing if the configurations are not equal.: tf_provider_addr=registry.terraform.io/hashicorp/aws tf_rpc=ConfigureProvider tf_mux_provider="*schema.GRPCProviderServer" tf_req_id=97a7a1b8-e917-8be6-c7f6-a76f904434e1
2023-03-22T22:17:39.559Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 tf_resource_type=aws_db_instance diagnostic_severity=WARNING tf_req_id=4dbce32e-cfe3-3434-eecd-391f1c813fb5 tf_rpc=ValidateResourceTypeConfig diagnostic_detail="Use db_name instead" diagnostic_summary="Argument is deprecated" diagnostic_attribute="AttributeName(\"name\")"
2023-03-22T22:17:44.410Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_proto_version=5.3 tf_resource_type=aws_db_instance tf_req_id=2b15c0a4-ea42-49eb-aa30-4088d30fe6e5 diagnostic_summary="Argument is deprecated" diagnostic_attribute="AttributeName(\"name\")" tf_provider_addr=registry.terraform.io/hashicorp/aws diagnostic_detail="Use db_name instead" diagnostic_severity=WARNING tf_rpc=ValidateResourceTypeConfig
2023-03-22T22:17:46.143Z [WARN]  sdk.proto: Response contains warning diagnostic: diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" tf_req_id=1f3e2ede-aa49-8149-b97c-8ada32be21fb tf_provider_addr=registry.terraform.io/hashicorp/aws tf_rpc=ValidateResourceTypeConfig tf_resource_type=aws_db_instance diagnostic_detail="Use db_name instead" tf_proto_version=5.3 diagnostic_attribute="AttributeName(\"name\")"
2023-03-22T22:17:51.846Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_rpc=ValidateResourceTypeConfig diagnostic_attribute="AttributeName(\"name\")" tf_proto_version=5.3 tf_provider_addr=registry.terraform.io/hashicorp/aws tf_resource_type=aws_db_instance diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" diagnostic_detail="Use db_name instead" tf_req_id=fdf46825-c9b9-8e99-8148-ce212779845d
2023-03-22T22:17:52.919Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_provider_addr=registry.terraform.io/hashicorp/aws tf_resource_type=aws_db_instance diagnostic_summary="Argument is deprecated" diagnostic_attribute="AttributeName(\"name\")" diagnostic_detail="Use db_name instead" tf_req_id=3e1cec5b-03aa-6601-0e33-056a5094b79f tf_proto_version=5.3 tf_rpc=ValidateResourceTypeConfig diagnostic_severity=WARNING
2023-03-22T22:17:57.614Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_proto_version=5.3 diagnostic_attribute="AttributeName(\"name\")" diagnostic_detail="Use db_name instead" diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" tf_resource_type=aws_db_instance tf_rpc=ValidateResourceTypeConfig tf_req_id=bc4476eb-c0b6-4355-a9bc-9eaffea9841e tf_provider_addr=registry.terraform.io/hashicorp/aws
2023-03-22T22:17:59.976Z [WARN]  sdk.proto: Response contains warning diagnostic: tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 tf_resource_type=aws_db_instance diagnostic_severity=WARNING diagnostic_summary="Argument is deprecated" tf_req_id=a961ed52-b169-0c78-a3fa-6a740895eff0 diagnostic_attribute="AttributeName(\"name\")" diagnostic_detail="Use db_name instead" tf_rpc=ValidateResourceTypeConfig
2023-03-22T22:18:01.142Z [WARN]  sdk.helper_schema: Previously configured provider being re-configured. This can cause issues in concurrent testing if the configurations are not equal.: tf_provider_addr=registry.terraform.io/hashicorp/aws tf_rpc=ConfigureProvider tf_mux_provider="*schema.GRPCProviderServer" tf_req_id=14d7d7aa-49f0-38db-8a6a-fb200a52a22d
--- PASS: TestAccRDSInstanceDataSource_ManagedMasterPassword_managed (572.29s)
--- PASS: TestAccRDSInstanceDataSource_basic (574.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	574.444s

@AdamTylerLynch
Copy link
Collaborator

Ready for review.

@ewbankkit ewbankkit added the partner Contribution from a partner. label Mar 27, 2023
@ewbankkit ewbankkit self-assigned this Mar 27, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccRDSInstance_basic\|TestAccRDSInstance_manage_password\|TestAccRDSInstance_ManagedMasterPassword_\|TestAccRDSInstance_password\|TestAccRDSInstanceDataSource_\|TestAccRDSClusterDataSource_\|TestAccRDSCluster_ManagedMasterPassword_\|TestAccRDSCluster_basic\|TestAccRDSCluster_SnapshotIdentifier_master' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSInstance_basic\|TestAccRDSInstance_manage_password\|TestAccRDSInstance_ManagedMasterPassword_\|TestAccRDSInstance_password\|TestAccRDSInstanceDataSource_\|TestAccRDSClusterDataSource_\|TestAccRDSCluster_ManagedMasterPassword_\|TestAccRDSCluster_basic\|TestAccRDSCluster_SnapshotIdentifier_master -timeout 360m
=== RUN   TestAccRDSClusterDataSource_basic
=== PAUSE TestAccRDSClusterDataSource_basic
=== RUN   TestAccRDSClusterDataSource_ManagedMasterPassword_managed
=== PAUSE TestAccRDSClusterDataSource_ManagedMasterPassword_managed
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managed
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managed
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== RUN   TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== RUN   TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_manage_password
=== PAUSE TestAccRDSInstance_manage_password
=== RUN   TestAccRDSInstance_password
=== PAUSE TestAccRDSInstance_password
=== RUN   TestAccRDSInstance_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managed
=== RUN   TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== CONT  TestAccRDSClusterDataSource_basic
=== CONT  TestAccRDSInstanceDataSource_basic
=== CONT  TestAccRDSInstance_password
--- PASS: TestAccRDSClusterDataSource_basic (179.12s)
=== CONT  TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSInstanceDataSource_basic (468.10s)
=== CONT  TestAccRDSInstance_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSInstance_password (582.65s)
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey (513.79s)
=== CONT  TestAccRDSInstance_manage_password        
--- PASS: TestAccRDSInstance_basic (404.12s)
=== CONT  TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
--- PASS: TestAccRDSInstance_ManagedMasterPassword_convertToManaged (682.88s)
=== CONT  TestAccRDSInstance_ManagedMasterPassword_managed
--- PASS: TestAccRDSInstance_manage_password (540.26s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (158.38s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSInstanceDataSource_ManagedMasterPassword_managed (543.98s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterPassword
--- PASS: TestAccRDSInstance_ManagedMasterPassword_managed (524.43s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (184.19s)
=== CONT  TestAccRDSCluster_basic
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (439.00s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (388.45s)
=== CONT  TestAccRDSClusterDataSource_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_basic (171.62s)
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (170.96s)
--- PASS: TestAccRDSClusterDataSource_ManagedMasterPassword_managed (210.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2134.054s

@ewbankkit
Copy link
Contributor

@fergoid @AdamTylerLynch Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a883aba into hashicorp:main Mar 28, 2023
@github-actions github-actions bot added this to the v4.61.0 milestone Mar 28, 2023
@github-actions
Copy link

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jurajseffer
Copy link
Contributor

Do these tests cover that Terraform picks up master_user_secret as computed attribute for outputs? I'm not sure if I'm doing something wrong but simply using aws_rds_cluster.this.master_user_secret[0].secret_arn in an output for an existing/provisioned cluster which hasn't had manage_master_user_password = true applied yet results in plan failure: The given key does not identify an element in this collection value: the collection has no elements.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: RDS support for storing master user password in Secrets Manager
8 participants