Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add capacity-reservation-options flag to on-demand-options in Resource aws_ec2_fleet #28828

Closed
dkheyman opened this issue Jan 11, 2023 · 4 comments · Fixed by #29181
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@dkheyman
Copy link

Description

Currently, the aws_ec2_fleet on-demand-options specification only supports allocation_strategy flags. Support for capacity-reservation-options was released a good amount of time ago to specify that the EC2 fleet needs to take advantage of capacity reservations specified in the Launch Template of the fleet specification.

I would like to add support for capacity_reservation_options as indicated in the EC2 CreateFleet API.

Affected Resource(s) and/or Data Source(s)

aws_ec2_fleet

Potential Terraform Configuration

resource "aws_ec2_fleet" "example" {
  type = "instant"
  launch_template_config {
    launch_template_specification {
      launch_template_id = aws_launch_template.example.id
      version            = aws_launch_template.example.latest_version
    }
  }

  target_capacity_specification {
    default_target_capacity_type = "on-demand"
    total_target_capacity        = 3
  }

  on_demand_options {
    capacity_reservation_options = {
        "usage-strategy" = "use-capacity-reservations-first"
    }
  }
}

References

https://docs.aws.amazon.com/cli/latest/reference/ec2/create-fleet.html
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ec2fleet-ondemandoptionsrequest.html#cfn-ec2-ec2fleet-ondemandoptionsrequest-capacityreservationoptions

Would you like to implement a fix?

No

@dkheyman dkheyman added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jan 11, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jan 11, 2023
@dkheyman
Copy link
Author

dkheyman commented Jan 11, 2023

Is also relevant to #9007 and #28830 for instant mode type support of EC2 Fleet.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 11, 2023
@github-actions github-actions bot added this to the v4.57.0 milestone Feb 28, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants