Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sesv2_configuration_set - add vdm_options argument #28812

Merged

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Jan 10, 2023

Description

This PR adds the vdm_options argument to the aws_sesv2_configuration_set resource.

Relations

Relates #26796.
Closes #28249.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_VdmOptions.html

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccSESV2ConfigurationSet_" PKG=sesv2 ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run=TestAccSESV2ConfigurationSet_ -timeout 180m
=== RUN   TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN   TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN   TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN   TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN   TestAccSESV2ConfigurationSet_engagementMetrics
=== PAUSE TestAccSESV2ConfigurationSet_engagementMetrics
=== RUN   TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== PAUSE TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== RUN   TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== CONT  TestAccSESV2ConfigurationSet_basic
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasons
--- PASS: TestAccSESV2ConfigurationSet_basic (20.62s)
=== CONT  TestAccSESV2ConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (33.91s)
=== CONT  TestAccSESV2ConfigurationSet_sendingEnabled
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (31.14s)
=== CONT  TestAccSESV2ConfigurationSet_tlsPolicy
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (31.01s)
=== CONT  TestAccSESV2ConfigurationSet_disappears
--- PASS: TestAccSESV2ConfigurationSet_disappears (12.54s)
=== CONT  TestAccSESV2ConfigurationSet_optimizedSharedDelivery
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (31.05s)
=== CONT  TestAccSESV2ConfigurationSet_tags
--- PASS: TestAccSESV2ConfigurationSet_optimizedSharedDelivery (30.96s)
=== CONT  TestAccSESV2ConfigurationSet_engagementMetrics
--- PASS: TestAccSESV2ConfigurationSet_tags (44.08s)
--- PASS: TestAccSESV2ConfigurationSet_engagementMetrics (30.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      141.065s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/sesv2 Issues and PRs that pertain to the sesv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 10, 2023
@kamilturek kamilturek marked this pull request as ready for review January 10, 2023 20:59
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2ConfigurationSet_' PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2ConfigurationSet_ -timeout 180m
=== RUN   TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN   TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN   TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN   TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN   TestAccSESV2ConfigurationSet_engagementMetrics
=== PAUSE TestAccSESV2ConfigurationSet_engagementMetrics
=== RUN   TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== PAUSE TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== RUN   TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== CONT  TestAccSESV2ConfigurationSet_basic
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasons
=== CONT  TestAccSESV2ConfigurationSet_tags
=== CONT  TestAccSESV2ConfigurationSet_engagementMetrics
=== CONT  TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== CONT  TestAccSESV2ConfigurationSet_sendingEnabled
=== CONT  TestAccSESV2ConfigurationSet_disappears
=== CONT  TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== CONT  TestAccSESV2ConfigurationSet_tlsPolicy
--- PASS: TestAccSESV2ConfigurationSet_disappears (26.61s)
--- PASS: TestAccSESV2ConfigurationSet_basic (39.64s)
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (58.80s)
--- PASS: TestAccSESV2ConfigurationSet_engagementMetrics (60.44s)
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (60.49s)
--- PASS: TestAccSESV2ConfigurationSet_optimizedSharedDelivery (61.14s)
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (61.90s)
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (62.24s)
--- PASS: TestAccSESV2ConfigurationSet_tags (73.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	78.774s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6382335 into hashicorp:main Mar 7, 2023
@github-actions github-actions bot added this to the v4.58.0 milestone Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Amazon SES account VDM attributes
2 participants