aws_sagemaker_endpoint_configuration - add name_prefix argument

[Limess]

Description

Adds name_prefix argument to sagemaker: aws_sagemaker_endpoint_configuration.

This allows a human readable name to be used when updating aws_sagemaker_endpoint_configuration.

Prior to this change, it was not possible to use a simple name as the attributes for a given aws_sagemaker_endpoint_configuration seem to be immutable, so two could not co-exist with the same name and differing configurations.

Relations

Fixes #21811

References

Used the same approach as batch/compute_environment.go as this has similar problems with immutable resources and uses a name prefix to mitigate them.

Output from Acceptance Testing

$ make testacc TESTS=TestAccSageMakerEndpointConfiguration PKG=sagemaker

make testacc TESTS=TestAccSageMakerEndpointConfiguration PKG=sage
maker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerEndpointConfiguration'  -timeout 180m
=== RUN   TestAccSageMakerEndpointConfiguration_basic
=== PAUSE TestAccSageMakerEndpointConfiguration_basic
=== RUN   TestAccSageMakerEndpointConfiguration_nameGenerated
=== PAUSE TestAccSageMakerEndpointConfiguration_nameGenerated
=== RUN   TestAccSageMakerEndpointConfiguration_namePrefix
=== PAUSE TestAccSageMakerEndpointConfiguration_namePrefix
=== RUN   TestAccSageMakerEndpointConfiguration_shadowProductionVariants
=== PAUSE TestAccSageMakerEndpointConfiguration_shadowProductionVariants
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== RUN   TestAccSageMakerEndpointConfiguration_kmsKeyID
=== PAUSE TestAccSageMakerEndpointConfiguration_kmsKeyID
=== RUN   TestAccSageMakerEndpointConfiguration_tags
=== PAUSE TestAccSageMakerEndpointConfiguration_tags
=== RUN   TestAccSageMakerEndpointConfiguration_dataCapture
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture
=== RUN   TestAccSageMakerEndpointConfiguration_disappears
=== PAUSE TestAccSageMakerEndpointConfiguration_disappears
=== RUN   TestAccSageMakerEndpointConfiguration_async
=== PAUSE TestAccSageMakerEndpointConfiguration_async
=== RUN   TestAccSageMakerEndpointConfiguration_async_kms
=== PAUSE TestAccSageMakerEndpointConfiguration_async_kms
=== RUN   TestAccSageMakerEndpointConfiguration_Async_notif
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_notif
=== RUN   TestAccSageMakerEndpointConfiguration_Async_client
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_client
=== CONT  TestAccSageMakerEndpointConfiguration_basic
=== CONT  TestAccSageMakerEndpointConfiguration_tags
=== CONT  TestAccSageMakerEndpointConfiguration_async_kms
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== CONT  TestAccSageMakerEndpointConfiguration_async
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== CONT  TestAccSageMakerEndpointConfiguration_disappears
=== CONT  TestAccSageMakerEndpointConfiguration_namePrefix
=== CONT  TestAccSageMakerEndpointConfiguration_dataCapture
=== CONT  TestAccSageMakerEndpointConfiguration_shadowProductionVariants
=== CONT  TestAccSageMakerEndpointConfiguration_Async_notif
=== CONT  TestAccSageMakerEndpointConfiguration_Async_client
=== CONT  TestAccSageMakerEndpointConfiguration_nameGenerated
=== CONT  TestAccSageMakerEndpointConfiguration_kmsKeyID
--- PASS: TestAccSageMakerEndpointConfiguration_async_kms (47.41s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_notif (53.42s)
--- PASS: TestAccSageMakerEndpointConfiguration_async (53.91s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless (54.90s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType (56.74s)
--- PASS: TestAccSageMakerEndpointConfiguration_namePrefix (56.79s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight (60.05s)
--- PASS: TestAccSageMakerEndpointConfiguration_basic (60.47s)
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (61.20s)
--- PASS: TestAccSageMakerEndpointConfiguration_kmsKeyID (64.51s)
--- PASS: TestAccSageMakerEndpointConfiguration_disappears (65.33s)
--- PASS: TestAccSageMakerEndpointConfiguration_shadowProductionVariants (65.91s)
--- PASS: TestAccSageMakerEndpointConfiguration_nameGenerated (68.55s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client (69.46s)
--- PASS: TestAccSageMakerEndpointConfiguration_tags (105.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  105.790s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @Limess 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerEndpointConfiguration_' PKG=sagemaker ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 3  -run=TestAccSageMakerEndpointConfiguration_ -timeout 180m
=== RUN   TestAccSageMakerEndpointConfiguration_basic
=== PAUSE TestAccSageMakerEndpointConfiguration_basic
=== RUN   TestAccSageMakerEndpointConfiguration_nameGenerated
=== PAUSE TestAccSageMakerEndpointConfiguration_nameGenerated
=== RUN   TestAccSageMakerEndpointConfiguration_namePrefix
=== PAUSE TestAccSageMakerEndpointConfiguration_namePrefix
=== RUN   TestAccSageMakerEndpointConfiguration_shadowProductionVariants
=== PAUSE TestAccSageMakerEndpointConfiguration_shadowProductionVariants
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated
=== RUN   TestAccSageMakerEndpointConfiguration_kmsKeyID
=== PAUSE TestAccSageMakerEndpointConfiguration_kmsKeyID
=== RUN   TestAccSageMakerEndpointConfiguration_tags
=== PAUSE TestAccSageMakerEndpointConfiguration_tags
=== RUN   TestAccSageMakerEndpointConfiguration_dataCapture
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture
=== RUN   TestAccSageMakerEndpointConfiguration_disappears
=== PAUSE TestAccSageMakerEndpointConfiguration_disappears
=== RUN   TestAccSageMakerEndpointConfiguration_async
=== PAUSE TestAccSageMakerEndpointConfiguration_async
=== RUN   TestAccSageMakerEndpointConfiguration_async_kms
=== PAUSE TestAccSageMakerEndpointConfiguration_async_kms
=== RUN   TestAccSageMakerEndpointConfiguration_Async_notif
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_notif
=== RUN   TestAccSageMakerEndpointConfiguration_Async_client
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_client
=== RUN   TestAccSageMakerEndpointConfiguration_upgradeToEnableSSMAccess
=== PAUSE TestAccSageMakerEndpointConfiguration_upgradeToEnableSSMAccess
=== CONT  TestAccSageMakerEndpointConfiguration_basic
=== CONT  TestAccSageMakerEndpointConfiguration_async_kms
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight (37.91s)
=== CONT  TestAccSageMakerEndpointConfiguration_kmsKeyID
--- PASS: TestAccSageMakerEndpointConfiguration_basic (41.69s)
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated
--- PASS: TestAccSageMakerEndpointConfiguration_async_kms (42.55s)
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
--- PASS: TestAccSageMakerEndpointConfiguration_kmsKeyID (36.41s)
=== CONT  TestAccSageMakerEndpointConfiguration_disappears
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType (34.21s)
=== CONT  TestAccSageMakerEndpointConfiguration_async
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated (37.10s)
=== CONT  TestAccSageMakerEndpointConfiguration_dataCapture
--- PASS: TestAccSageMakerEndpointConfiguration_disappears (31.02s)
=== CONT  TestAccSageMakerEndpointConfiguration_Async_client
--- PASS: TestAccSageMakerEndpointConfiguration_async (34.46s)
=== CONT  TestAccSageMakerEndpointConfiguration_upgradeToEnableSSMAccess
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (34.36s)
=== CONT  TestAccSageMakerEndpointConfiguration_Async_notif
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client (33.88s)
=== CONT  TestAccSageMakerEndpointConfiguration_shadowProductionVariants
--- PASS: TestAccSageMakerEndpointConfiguration_Async_notif (38.48s)
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
--- PASS: TestAccSageMakerEndpointConfiguration_shadowProductionVariants (34.34s)
=== CONT  TestAccSageMakerEndpointConfiguration_namePrefix
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless (36.08s)
=== CONT  TestAccSageMakerEndpointConfiguration_nameGenerated
--- PASS: TestAccSageMakerEndpointConfiguration_namePrefix (34.96s)
=== CONT  TestAccSageMakerEndpointConfiguration_tags
--- PASS: TestAccSageMakerEndpointConfiguration_nameGenerated (36.02s)
--- PASS: TestAccSageMakerEndpointConfiguration_upgradeToEnableSSMAccess (116.52s)
--- PASS: TestAccSageMakerEndpointConfiguration_tags (65.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	282.587s

[ewbankkit]

@Limess Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.