-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_lightsail_bucket_access_key
. New Shared Resource Separator and associated functions
#28699
New Resource: aws_lightsail_bucket_access_key
. New Shared Resource Separator and associated functions
#28699
Conversation
Community NoteVoting for Prioritization
For Submitters
|
aws_lightsail_bucket_access_key
. New Shared Resource Separator and associated functions
@YakDriver Friendly bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run=TestAccLightsailBucketAccessKey -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.44.171
go: downloading github.com/aws/aws-sdk-go-v2/service/auditmanager v1.21.2
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.10.21
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.17.3
go: downloading github.com/aws/aws-sdk-go-v2/service/comprehend v1.20.2
go: downloading github.com/aws/aws-sdk-go-v2/service/computeoptimizer v1.19.0
go: downloading github.com/aws/aws-sdk-go-v2/service/fis v1.13.5
go: downloading github.com/aws/aws-sdk-go-v2/service/identitystore v1.15.10
go: downloading github.com/aws/aws-sdk-go-v2/service/inspector2 v1.10.0
go: downloading github.com/aws/aws-sdk-go-v2/service/ivschat v1.2.1
go: downloading github.com/aws/aws-sdk-go-v2/service/kendra v1.36.3
go: downloading github.com/aws/aws-sdk-go-v2/service/medialive v1.27.0
go: downloading github.com/aws/aws-sdk-go-v2/service/opensearchserverless v1.0.3
go: downloading github.com/aws/aws-sdk-go-v2/service/pipes v1.0.2
go: downloading github.com/aws/aws-sdk-go-v2/service/rds v1.38.0
go: downloading github.com/aws/aws-sdk-go-v2/service/resourceexplorer2 v1.1.0
go: downloading github.com/aws/aws-sdk-go-v2/service/rolesanywhere v1.0.14
go: downloading github.com/aws/aws-sdk-go-v2/service/route53domains v1.13.0
go: downloading github.com/aws/aws-sdk-go-v2/service/s3control v1.28.2
go: downloading github.com/aws/aws-sdk-go-v2/service/scheduler v1.0.3
go: downloading github.com/aws/aws-sdk-go-v2/service/sesv2 v1.15.3
go: downloading github.com/aws/aws-sdk-go-v2/service/ssm v1.33.4
go: downloading github.com/aws/aws-sdk-go-v2/service/ssmincidents v1.19.2
go: downloading github.com/aws/aws-sdk-go-v2/service/transcribe v1.24.0
go: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.17.7
go: downloading github.com/aws/aws-sdk-go-v2/service/iam v1.18.25
go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.11.27
=== RUN TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN TestAccLightsailBucketAccessKey_disappears
=== PAUSE TestAccLightsailBucketAccessKey_disappears
=== CONT TestAccLightsailBucketAccessKey_basic
=== CONT TestAccLightsailBucketAccessKey_disappears
--- PASS: TestAccLightsailBucketAccessKey_disappears (50.61s)
--- PASS: TestAccLightsailBucketAccessKey_basic (53.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lightsail 55.270s
This functionality has been released in v4.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This Pull request Implements a new resource:
aws_lightsail_bucket_access_key
which allows creating and managing lightsail bucket access keys.Additionally this pull request also implements a shared
ResourceSeparator
constant and theExpandResourceId
andFlattenResourceId
functions for standardizing on a common resource separator as discussed in #27843 , so that new resources can start using this new standard.Relations
Relates #27843
References
Output from Acceptance Testing