Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_instance_state #28639

Merged
merged 18 commits into from
Jan 4, 2023

Conversation

brittandeyoung
Copy link
Collaborator

Description

This Pull request adds the aws_instance_state resource which allows managing the power state of an ec2 instance. It can be used to shutdown and power off instances and track the current state.

Relations

Closes #22

References

Output from Acceptance Testing


➜ terraform-provider-aws (f-aws_instance_state) ✗ make testacc TESTARGS='-run=TestAccEC2InstanceState' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2InstanceState -timeout 180m
=== RUN   TestAccEC2InstanceState_basic
=== PAUSE TestAccEC2InstanceState_basic
=== RUN   TestAccEC2InstanceState_state
=== PAUSE TestAccEC2InstanceState_state
=== RUN   TestAccEC2InstanceState_disappears_Instance
=== PAUSE TestAccEC2InstanceState_disappears_Instance
=== CONT  TestAccEC2InstanceState_basic
=== CONT  TestAccEC2InstanceState_disappears_Instance
=== CONT  TestAccEC2InstanceState_state
--- PASS: TestAccEC2InstanceState_basic (89.22s)
--- PASS: TestAccEC2InstanceState_disappears_Instance (108.26s)
--- PASS: TestAccEC2InstanceState_state (390.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        392.830s
...

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jan 3, 2023
@brittandeyoung brittandeyoung added the new-resource Introduces a new resource. label Jan 3, 2023
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

% make testacc TESTS=TestAccEC2InstanceState_ PKG=ec2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceState_'  -timeout 180m
=== RUN   TestAccEC2InstanceState_basic
=== PAUSE TestAccEC2InstanceState_basic
=== RUN   TestAccEC2InstanceState_state
=== PAUSE TestAccEC2InstanceState_state
=== RUN   TestAccEC2InstanceState_disappears_Instance
=== PAUSE TestAccEC2InstanceState_disappears_Instance
=== CONT  TestAccEC2InstanceState_basic
=== CONT  TestAccEC2InstanceState_disappears_Instance
=== CONT  TestAccEC2InstanceState_state
--- PASS: TestAccEC2InstanceState_disappears_Instance (304.38s)
--- PASS: TestAccEC2InstanceState_basic (326.52s)
--- PASS: TestAccEC2InstanceState_state (611.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	612.652s

@YakDriver YakDriver self-assigned this Jan 4, 2023
@YakDriver YakDriver merged commit 0b7be5b into hashicorp:main Jan 4, 2023
@github-actions github-actions bot added this to the v4.49.0 milestone Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop instances
3 participants