r/servicecatalog_portfolio_share - add share_principals

[DrFaust92]

Description

Relations

Closes #20021.

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccServiceCatalogPortfolioShare_ PKG=servicecatalog

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceCatalog_serial' PKG=servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20  -run=TestAccServiceCatalog_serial -timeout 180m
=== RUN   TestAccServiceCatalog_serial
=== PAUSE TestAccServiceCatalog_serial
=== CONT  TestAccServiceCatalog_serial
=== RUN   TestAccServiceCatalog_serial/OrganizationsAccess
=== RUN   TestAccServiceCatalog_serial/OrganizationsAccess/basic
=== RUN   TestAccServiceCatalog_serial/PortfolioShare
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/basic
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit
=== RUN   TestAccServiceCatalog_serial/PortfolioShare/disappears
--- PASS: TestAccServiceCatalog_serial (302.61s)
    --- PASS: TestAccServiceCatalog_serial/OrganizationsAccess (16.73s)
        --- PASS: TestAccServiceCatalog_serial/OrganizationsAccess/basic (16.73s)
    --- PASS: TestAccServiceCatalog_serial/PortfolioShare (285.89s)
        --- PASS: TestAccServiceCatalog_serial/PortfolioShare/basic (38.11s)
        --- PASS: TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals (42.67s)
        --- PASS: TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit (24.55s)
        --- PASS: TestAccServiceCatalog_serial/PortfolioShare/disappears (180.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	307.783s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.