Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: aws_lightsail_disk_attachment crash on failure #28593

Merged

Conversation

brittandeyoung
Copy link
Collaborator

Description

This PR resolves a crash that occurs when terraform fails to attach a disk to an instance. The crash was taking place because the logs originally referenced an attribute that does not exist.

Relations

Closes #28024

References

Output from Acceptance Testing

➜ terraform-provider-aws (b-aws_lightsail_disk_attachemnt_crash) ✗ make testacc TESTARGS='-run=TestAccLightsailDiskAttachment' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDiskAttachment -timeout 180m
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== CONT  TestAccLightsailDiskAttachment_basic
=== CONT  TestAccLightsailDiskAttachment_disappears

--- PASS: TestAccLightsailDiskAttachment_disappears (168.07s)
--- PASS: TestAccLightsailDiskAttachment_basic (194.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  196.259s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lightsail Issues and PRs that pertain to the lightsail service. labels Dec 27, 2022
@brittandeyoung brittandeyoung changed the title B aws lightsail disk attachemnt crash Bugfix: aws _ightsail_disk_attachemnt crash on failure Dec 27, 2022
@brittandeyoung brittandeyoung changed the title Bugfix: aws _ightsail_disk_attachemnt crash on failure Bugfix: aws_lightsail_disk_attachment crash on failure Dec 27, 2022
@github-actions github-actions bot added service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 27, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailDiskAttachment_' PKG=lightsail ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 3  -run=TestAccLightsailDiskAttachment_ -timeout 180m
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== CONT  TestAccLightsailDiskAttachment_basic
=== CONT  TestAccLightsailDiskAttachment_disappears
--- PASS: TestAccLightsailDiskAttachment_basic (180.28s)
--- PASS: TestAccLightsailDiskAttachment_disappears (183.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	188.534s

@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2d2c0e4 into hashicorp:main Jan 3, 2023
@github-actions github-actions bot added this to the v4.49.0 milestone Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/lightsail Issues and PRs that pertain to the lightsail service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:
2 participants