Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer WithoutTimeout variants over Context variants of resource CRUD handlers #28427

Closed
ewbankkit opened this issue Dec 16, 2022 · 2 comments · Fixed by #28494
Closed

Prefer WithoutTimeout variants over Context variants of resource CRUD handlers #28427

ewbankkit opened this issue Dec 16, 2022 · 2 comments · Fixed by #28494

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Dec 16, 2022

For the reasons described here and here we should use the WithoutTimeout variants of resource (and data source) CRUD handlers over the Context variants.

  • Implement semgrep rules to catch setting of CreateContext, ReadContext, UpdateContext or DeleteContext schema.Resource fields
  • Ensure documentation uses the WithoutTimeout variants
  • Convert all existing references
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title Prefer WithoutTimeout variants over Context variants of resource CRUD handlers Prefer WithoutTimeout variants over Context variants of resource CRUD handlers Dec 16, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant