r/aws_networkmanager_core_network #28155

GlennChia · 2022-12-03T15:10:44Z

Description

Creates the Network Manager Core Network resource - introduces Create, Read and Update. Note that Delete was already implemented.

Logic of policy versioning

When the policy is updated, call PutCoreNetworkPolicy which creates the new policy labelled as LATEST
Note that the state of the policy goes from Pending generation to Ready to execute
Call the ExecuteCoreNetworkChangeSet to set the latest policy as the LIVE policy. Note that retries are included because we get a Validation exception with message Incorrect input if the policy is not in the Ready to execute state
At this time the Core Network goes into the Updating state and we wait till it becomes Available again

Gotchas

The data type for policy_document In the Update (PutCoreNetworkPolicy API) differs from that of the Create (CreateCoreNetwork API).
- PutCoreNetworkPolicy: PolicyDocument aws.JSONValue type:"jsonvalue" required:"true"
- CreateCoreNetwork: PolicyDocument *string type:"string"
There is an attribute that is computed named segments. This is populated by the data in policy_document. In the test TestAccNetworkManagerCoreNetwork_policyDocument, the contents of segments is verified at the first test step (when the Core Network is created). However, on Update in the third step, the values do not change in the test. Hence, it is commented out. However, the changes can be seen in the debugger with a d.Get("segments"), implying that the third test steps seems to use the previous schema for computed attributes.

Relations

Relates #25835

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccNetworkManagerCoreNetwork' PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20  -run=TestAccNetworkManagerCoreNetwork -timeout 180m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetwork_basic
=== PAUSE TestAccNetworkManagerCoreNetwork_basic
=== RUN   TestAccNetworkManagerCoreNetwork_disappears
=== PAUSE TestAccNetworkManagerCoreNetwork_disappears
=== RUN   TestAccNetworkManagerCoreNetwork_tags
=== PAUSE TestAccNetworkManagerCoreNetwork_tags
=== RUN   TestAccNetworkManagerCoreNetwork_description
=== PAUSE TestAccNetworkManagerCoreNetwork_description
=== RUN   TestAccNetworkManagerCoreNetwork_policyDocument
=== PAUSE TestAccNetworkManagerCoreNetwork_policyDocument
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetwork_tags
=== CONT  TestAccNetworkManagerCoreNetwork_basic
=== CONT  TestAccNetworkManagerCoreNetwork_description
=== CONT  TestAccNetworkManagerCoreNetwork_disappears
=== CONT  TestAccNetworkManagerCoreNetwork_policyDocument
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (14.54s)
--- PASS: TestAccNetworkManagerCoreNetwork_basic (55.88s)
--- PASS: TestAccNetworkManagerCoreNetwork_disappears (63.19s)
--- PASS: TestAccNetworkManagerCoreNetwork_description (85.37s)
--- PASS: TestAccNetworkManagerCoreNetwork_tags (93.06s)
--- PASS: TestAccNetworkManagerCoreNetwork_policyDocument (781.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     781.262s

...

github-actions · 2022-12-03T15:10:58Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerCoreNetwork_' PKG=networkmanager ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2 -run=TestAccNetworkManagerCoreNetwork_ -timeout 180m === RUN TestAccNetworkManagerCoreNetwork_basic === PAUSE TestAccNetworkManagerCoreNetwork_basic === RUN TestAccNetworkManagerCoreNetwork_disappears === PAUSE TestAccNetworkManagerCoreNetwork_disappears === RUN TestAccNetworkManagerCoreNetwork_tags === PAUSE TestAccNetworkManagerCoreNetwork_tags === RUN TestAccNetworkManagerCoreNetwork_description === PAUSE TestAccNetworkManagerCoreNetwork_description === RUN TestAccNetworkManagerCoreNetwork_policyDocument === PAUSE TestAccNetworkManagerCoreNetwork_policyDocument === CONT TestAccNetworkManagerCoreNetwork_basic === CONT TestAccNetworkManagerCoreNetwork_description --- PASS: TestAccNetworkManagerCoreNetwork_basic (50.55s) === CONT TestAccNetworkManagerCoreNetwork_tags --- PASS: TestAccNetworkManagerCoreNetwork_description (64.85s) === CONT TestAccNetworkManagerCoreNetwork_disappears --- PASS: TestAccNetworkManagerCoreNetwork_disappears (28.52s) === CONT TestAccNetworkManagerCoreNetwork_policyDocument --- PASS: TestAccNetworkManagerCoreNetwork_tags (64.44s) --- PASS: TestAccNetworkManagerCoreNetwork_policyDocument (778.00s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 876.679s

… Site VPN Attachments.

…uted if 'policy_document' changes. Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerCoreNetwork_policyDocument' PKG=networkmanager ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2 -run=TestAccNetworkManagerCoreNetwork_policyDocument -timeout 180m === RUN TestAccNetworkManagerCoreNetwork_policyDocument === PAUSE TestAccNetworkManagerCoreNetwork_policyDocument === CONT TestAccNetworkManagerCoreNetwork_policyDocument --- PASS: TestAccNetworkManagerCoreNetwork_policyDocument (622.08s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 630.804s

ewbankkit · 2022-12-06T16:49:26Z

@GlennChia The updates to edges and segments can be handled via using SetNewComputed in a difference customization.

…anager_core_network' in acceptance tests. Acceptance test output: % make testacc TESTARGS='-run=TestAccTransitGateway_serial/PolicyTableAssociation' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccTransitGateway_serial/PolicyTableAssociation -timeout 180m === RUN TestAccTransitGateway_serial === RUN TestAccTransitGateway_serial/PolicyTableAssociation === RUN TestAccTransitGateway_serial/PolicyTableAssociation/basic === RUN TestAccTransitGateway_serial/PolicyTableAssociation/disappears --- PASS: TestAccTransitGateway_serial (2330.46s) --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation (2330.46s) --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/basic (1068.59s) --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/disappears (1261.86s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 2335.997s

…_network' in acceptance tests. Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerConnectAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3 -run=TestAccNetworkManagerConnectAttachment_ -timeout 180m === RUN TestAccNetworkManagerConnectAttachment_basic === PAUSE TestAccNetworkManagerConnectAttachment_basic === RUN TestAccNetworkManagerConnectAttachment_basic_NoDependsOn === PAUSE TestAccNetworkManagerConnectAttachment_basic_NoDependsOn === RUN TestAccNetworkManagerConnectAttachment_disappears === PAUSE TestAccNetworkManagerConnectAttachment_disappears === RUN TestAccNetworkManagerConnectAttachment_tags === PAUSE TestAccNetworkManagerConnectAttachment_tags === CONT TestAccNetworkManagerConnectAttachment_basic === CONT TestAccNetworkManagerConnectAttachment_disappears === CONT TestAccNetworkManagerConnectAttachment_tags --- PASS: TestAccNetworkManagerConnectAttachment_disappears (1095.14s) === CONT TestAccNetworkManagerConnectAttachment_basic_NoDependsOn --- PASS: TestAccNetworkManagerConnectAttachment_tags (1156.98s) --- PASS: TestAccNetworkManagerConnectAttachment_basic (1161.74s) --- PASS: TestAccNetworkManagerConnectAttachment_basic_NoDependsOn (1107.70s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 2208.289s

…_networkmanager_core_network' in acceptance tests. Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3 -run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_ -timeout 180m === RUN TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic === PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic === RUN TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears === PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears === RUN TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags === PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags === CONT TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic === CONT TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags === CONT TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears --- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (1435.78s) --- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears (1545.42s) --- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags (1605.54s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 1610.116s

…work' in acceptance tests. Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerVPCAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3 -run=TestAccNetworkManagerVPCAttachment_ -timeout 180m === RUN TestAccNetworkManagerVPCAttachment_basic === PAUSE TestAccNetworkManagerVPCAttachment_basic === RUN TestAccNetworkManagerVPCAttachment_disappears === PAUSE TestAccNetworkManagerVPCAttachment_disappears === RUN TestAccNetworkManagerVPCAttachment_tags === PAUSE TestAccNetworkManagerVPCAttachment_tags === RUN TestAccNetworkManagerVPCAttachment_update === PAUSE TestAccNetworkManagerVPCAttachment_update === CONT TestAccNetworkManagerVPCAttachment_basic === CONT TestAccNetworkManagerVPCAttachment_tags --- PASS: TestAccNetworkManagerVPCAttachment_update (1174.65s) === CONT TestAccNetworkManagerVPCAttachment_disappears --- PASS: TestAccNetworkManagerVPCAttachment_basic (767.31s) --- PASS: TestAccNetworkManagerVPCAttachment_disappears (822.90s) --- PASS: TestAccNetworkManagerVPCAttachment_tags (973.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 1179.452s

…_core_network' in acceptance tests. Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayPeering_' PKG=networkmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3 -run=TestAccNetworkManagerTransitGatewayPeering_ -timeout 180m === RUN TestAccNetworkManagerTransitGatewayPeering_basic === PAUSE TestAccNetworkManagerTransitGatewayPeering_basic === RUN TestAccNetworkManagerTransitGatewayPeering_disappears === PAUSE TestAccNetworkManagerTransitGatewayPeering_disappears === RUN TestAccNetworkManagerTransitGatewayPeering_tags === PAUSE TestAccNetworkManagerTransitGatewayPeering_tags === CONT TestAccNetworkManagerTransitGatewayPeering_basic === CONT TestAccNetworkManagerTransitGatewayPeering_tags === CONT TestAccNetworkManagerTransitGatewayPeering_disappears --- PASS: TestAccNetworkManagerTransitGatewayPeering_tags (1210.81s) --- PASS: TestAccNetworkManagerTransitGatewayPeering_basic (1310.53s) --- PASS: TestAccNetworkManagerTransitGatewayPeering_disappears (1323.75s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 1328.536s

…ager_core_network' in acceptance tests. Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerSiteToSiteVPNAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3 -run=TestAccNetworkManagerSiteToSiteVPNAttachment_ -timeout 180m === RUN TestAccNetworkManagerSiteToSiteVPNAttachment_basic === PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_basic === RUN TestAccNetworkManagerSiteToSiteVPNAttachment_disappears === PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_disappears === RUN TestAccNetworkManagerSiteToSiteVPNAttachment_tags === PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_tags === CONT TestAccNetworkManagerSiteToSiteVPNAttachment_basic === CONT TestAccNetworkManagerSiteToSiteVPNAttachment_tags === CONT TestAccNetworkManagerSiteToSiteVPNAttachment_disappears --- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_tags (1458.00s) --- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_disappears (1465.42s) --- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_basic (1466.45s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 1470.765s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkManagerSiteToSiteVPNAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3  -run=TestAccNetworkManagerSiteToSiteVPNAttachment_ -timeout 180m
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_tags (1458.00s)
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_disappears (1465.42s)
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_basic (1466.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1470.765s
% make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayPeering_' PKG=networkmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3  -run=TestAccNetworkManagerTransitGatewayPeering_ -timeout 180m
=== RUN   TestAccNetworkManagerTransitGatewayPeering_basic
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_basic
=== RUN   TestAccNetworkManagerTransitGatewayPeering_disappears
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_disappears
=== RUN   TestAccNetworkManagerTransitGatewayPeering_tags
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_tags
=== CONT  TestAccNetworkManagerTransitGatewayPeering_basic
=== CONT  TestAccNetworkManagerTransitGatewayPeering_tags
=== CONT  TestAccNetworkManagerTransitGatewayPeering_disappears
--- PASS: TestAccNetworkManagerTransitGatewayPeering_tags (1210.81s)
--- PASS: TestAccNetworkManagerTransitGatewayPeering_basic (1310.53s)
--- PASS: TestAccNetworkManagerTransitGatewayPeering_disappears (1323.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1328.536s
% make testacc TESTARGS='-run=TestAccNetworkManagerVPCAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3  -run=TestAccNetworkManagerVPCAttachment_ -timeout 180m
=== RUN   TestAccNetworkManagerVPCAttachment_basic
=== PAUSE TestAccNetworkManagerVPCAttachment_basic
=== RUN   TestAccNetworkManagerVPCAttachment_disappears
=== PAUSE TestAccNetworkManagerVPCAttachment_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_tags
=== PAUSE TestAccNetworkManagerVPCAttachment_tags
=== RUN   TestAccNetworkManagerVPCAttachment_update
=== PAUSE TestAccNetworkManagerVPCAttachment_update
=== CONT  TestAccNetworkManagerVPCAttachment_basic
=== CONT  TestAccNetworkManagerVPCAttachment_tags
--- PASS: TestAccNetworkManagerVPCAttachment_update (1174.65s)
=== CONT  TestAccNetworkManagerVPCAttachment_disappears
--- PASS: TestAccNetworkManagerVPCAttachment_basic (767.31s)
--- PASS: TestAccNetworkManagerVPCAttachment_disappears (822.90s)
--- PASS: TestAccNetworkManagerVPCAttachment_tags (973.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1179.452s
% make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3  -run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_ -timeout 180m
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (1435.78s)
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears (1545.42s)
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags (1605.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1610.116s
% make testacc TESTARGS='-run=TestAccNetworkManagerConnectAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3  -run=TestAccNetworkManagerConnectAttachment_ -timeout 180m
=== RUN   TestAccNetworkManagerConnectAttachment_basic
=== PAUSE TestAccNetworkManagerConnectAttachment_basic
=== RUN   TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
=== PAUSE TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
=== RUN   TestAccNetworkManagerConnectAttachment_disappears
=== PAUSE TestAccNetworkManagerConnectAttachment_disappears
=== RUN   TestAccNetworkManagerConnectAttachment_tags
=== PAUSE TestAccNetworkManagerConnectAttachment_tags
=== CONT  TestAccNetworkManagerConnectAttachment_basic
=== CONT  TestAccNetworkManagerConnectAttachment_disappears
=== CONT  TestAccNetworkManagerConnectAttachment_tags
--- PASS: TestAccNetworkManagerConnectAttachment_disappears (1095.14s)
=== CONT  TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
--- PASS: TestAccNetworkManagerConnectAttachment_tags (1156.98s)
--- PASS: TestAccNetworkManagerConnectAttachment_basic (1161.74s)
--- PASS: TestAccNetworkManagerConnectAttachment_basic_NoDependsOn (1107.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	2208.289s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PolicyTableAssociation' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccTransitGateway_serial/PolicyTableAssociation -timeout 180m
=== RUN   TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation/basic
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation/disappears
--- PASS: TestAccTransitGateway_serial (2330.46s)
    --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation (2330.46s)
        --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/basic (1068.59s)
        --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/disappears (1261.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2335.997s
% make testacc TESTARGS='-run=TestAccNetworkManagerCoreNetwork_' PKG=networkmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2  -run=TestAccNetworkManagerCoreNetwork_ -timeout 180m
=== RUN   TestAccNetworkManagerCoreNetwork_basic
=== PAUSE TestAccNetworkManagerCoreNetwork_basic
=== RUN   TestAccNetworkManagerCoreNetwork_disappears
=== PAUSE TestAccNetworkManagerCoreNetwork_disappears
=== RUN   TestAccNetworkManagerCoreNetwork_tags
=== PAUSE TestAccNetworkManagerCoreNetwork_tags
=== RUN   TestAccNetworkManagerCoreNetwork_description
=== PAUSE TestAccNetworkManagerCoreNetwork_description
=== RUN   TestAccNetworkManagerCoreNetwork_policyDocument
=== PAUSE TestAccNetworkManagerCoreNetwork_policyDocument
=== CONT  TestAccNetworkManagerCoreNetwork_basic
=== CONT  TestAccNetworkManagerCoreNetwork_description
--- PASS: TestAccNetworkManagerCoreNetwork_basic (50.55s)
=== CONT  TestAccNetworkManagerCoreNetwork_tags
--- PASS: TestAccNetworkManagerCoreNetwork_description (64.85s)
=== CONT  TestAccNetworkManagerCoreNetwork_disappears
--- PASS: TestAccNetworkManagerCoreNetwork_disappears (28.52s)
=== CONT  TestAccNetworkManagerCoreNetwork_policyDocument
--- PASS: TestAccNetworkManagerCoreNetwork_tags (64.44s)
--- PASS: TestAccNetworkManagerCoreNetwork_policyDocument (778.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	876.679s

ewbankkit · 2022-12-07T00:31:39Z

@GlennChia Thanks for the contribution 🎉 👏.

NetDevAutomate · 2022-12-07T09:58:50Z

Amazing! Thank you @GlennChia and @ewbankkit 🙏

github-actions · 2022-12-08T22:00:36Z

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-01-08T02:18:17Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

GlennChia added 11 commits December 3, 2022 14:26

feat(netm): core network schema

d5bf264

feat(netm): core network read

4b95f03

feat(netm): core network create

a6d8c03

feat(netm): core network update

b4e92f6

feat(netm): core network provider

ff42c13

test(netm): core network basic

058f7cf

test(netm): core network disappears

c946440

test(netm): core network tags

4018ca6

test(netm): core network description

a878cbf

test(netm): core network policy document

1545696

docs(netm): core network

4a54b44

ci(netm): core network changelog

f5ec9f0

ci(netm): suppress golangci-lint unparam

2970f94

GlennChia force-pushed the f-aws_networkmanager_core_network branch 2 times, most recently from 828b706 to 2970f94 Compare December 3, 2022 16:27

GlennChia added 2 commits December 3, 2022 17:40

test(netm): hard coded region to client.Region

a82ed0b

docs(netm): core network timeout options

26ba2f0

ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 5, 2022

ewbankkit added 3 commits December 6, 2022 09:42

Sweep Network Manager Connect Attachments and Network Manager Site To…

9deeeb3

… Site VPN Attachments.

github-actions bot added sweeper Pertains to changes to or issues with the sweeper. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Dec 6, 2022

ewbankkit added 6 commits December 6, 2022 13:13

github-actions bot added the service/transitgateway Issues and PRs that pertain to the transitgateway service. label Dec 7, 2022

ewbankkit approved these changes Dec 7, 2022

View reviewed changes

ewbankkit merged commit 46dbaeb into hashicorp:main Dec 7, 2022

github-actions bot added this to the v4.46.0 milestone Dec 7, 2022

GlennChia mentioned this pull request Dec 14, 2022

td/aws_networkmanager_core_network-increase-default-timeout #28363

Merged

ewbankkit mentioned this pull request Dec 20, 2022

AWS Cloud WAN #25835

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_networkmanager_core_network #28155

r/aws_networkmanager_core_network #28155

GlennChia commented Dec 3, 2022

github-actions bot commented Dec 3, 2022

ewbankkit commented Dec 6, 2022

ewbankkit left a comment

ewbankkit commented Dec 7, 2022

NetDevAutomate commented Dec 7, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Jan 8, 2023

r/aws_networkmanager_core_network #28155

r/aws_networkmanager_core_network #28155

Conversation

GlennChia commented Dec 3, 2022

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Dec 3, 2022

Community Note

ewbankkit commented Dec 6, 2022

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Dec 7, 2022

NetDevAutomate commented Dec 7, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Jan 8, 2023