Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: S3 Storage Lens Advanced Metrics #28151

Closed
eddideku opened this issue Dec 2, 2022 · 2 comments · Fixed by #28564
Closed

[Enhancement]: S3 Storage Lens Advanced Metrics #28151

eddideku opened this issue Dec 2, 2022 · 2 comments · Fixed by #28564
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3control Issues and PRs that pertain to the s3control service.

Comments

@eddideku
Copy link

eddideku commented Dec 2, 2022

Description

Hello,

I'm not sure how recent Cost Optimization Metrics, Data Protection Metrics, and Status Code Metrics was implemented into S3 Storage Lens. I recently started exploring S3 Storage Lens and noticed these options tagged with "new" next to them under "Advanced metrics categories"

Working with the aws_s3control_storage_lens_configuration terraform resource, I noticed the documentation makes no mention of these. Terraform also doesn't detect drift when I enable these advanced options.

I noticed @aws-alan added documentation for Storage Lens Data Protection:
https://github.com/awsdocs/amazon-s3-userguide/commits/main/doc_source/storage-lens-data-protection.md

Glancing at AWS CLI Command Reference, I see the 3 options

  • AdvancedCostOptimizationMetrics
  • AdvancedDataProtectionMetrics
  • DetailedStatusCodesMetrics

https://awscli.amazonaws.com/v2/documentation/api/latest/reference/s3control/put-storage-lens-configuration.html

Are these not available due to a limitation with AWS?

Affected Resource(s) and/or Data Source(s)

  • aws_s3control_storage_lens_configuration

Potential Terraform Configuration

resource "aws_s3control_storage_lens_configuration" "example" {
  config_id = "example-1"

  storage_lens_configuration {
    enabled = true

    account_level {
      activity_metrics {
        enabled = true
      }

      bucket_level {
        activity_metrics {
          enabled = true
        }
        cost_optimization_metrics {
          enabled = true
        }
        data_protection_metrics {
          enabled = true        
        }
        status_codes_metrics {
          enabled = true        
        }
      }
    }
  }
}

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3control_storage_lens_configuration
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/s3control/put-storage-lens-configuration.html

Would you like to implement a fix?

No

@eddideku eddideku added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/s3control Issues and PRs that pertain to the s3control service. label Dec 2, 2022
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Dec 3, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3control Issues and PRs that pertain to the s3control service.
Projects
None yet
2 participants