Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_classfier - custom_datatype_configured and custom_datatypes #28048

Merged
merged 6 commits into from
Nov 29, 2022

Conversation

DrFaust92
Copy link
Collaborator

Description

Relations

Closes #27971

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccGlueClassifier_  PKG=glue

--- PASS: TestAccGlueClassifier_disappears (36.49s)
--- PASS: TestAccGlueClassifier_CSVClassifier_quoteSymbol (76.01s)
--- PASS: TestAccGlueClassifier_CSVClassifier_custom (76.80s)
--- PASS: TestAccGlueClassifier_csvClassifier (76.80s)
--- PASS: TestAccGlueClassifier_jsonClassifier (77.05s)
--- PASS: TestAccGlueClassifier_grokClassifier (77.84s)
--- PASS: TestAccGlueClassifier_GrokClassifier_customPatterns (77.85s)
--- PASS: TestAccGlueClassifier_xmlClassifier (77.89s)
--- PASS: TestAccGlueClassifier_typeChange (118.30s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/glue Issues and PRs that pertain to the glue service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 28, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 28, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review November 28, 2022 17:52
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 28, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlueClassifier_' PKG=glue ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 2  -run=TestAccGlueClassifier_ -timeout 180m
=== RUN   TestAccGlueClassifier_csvClassifier
=== PAUSE TestAccGlueClassifier_csvClassifier
=== RUN   TestAccGlueClassifier_CSVClassifier_quoteSymbol
=== PAUSE TestAccGlueClassifier_CSVClassifier_quoteSymbol
=== RUN   TestAccGlueClassifier_CSVClassifier_custom
=== PAUSE TestAccGlueClassifier_CSVClassifier_custom
=== RUN   TestAccGlueClassifier_grokClassifier
=== PAUSE TestAccGlueClassifier_grokClassifier
=== RUN   TestAccGlueClassifier_GrokClassifier_customPatterns
=== PAUSE TestAccGlueClassifier_GrokClassifier_customPatterns
=== RUN   TestAccGlueClassifier_jsonClassifier
=== PAUSE TestAccGlueClassifier_jsonClassifier
=== RUN   TestAccGlueClassifier_typeChange
=== PAUSE TestAccGlueClassifier_typeChange
=== RUN   TestAccGlueClassifier_xmlClassifier
=== PAUSE TestAccGlueClassifier_xmlClassifier
=== RUN   TestAccGlueClassifier_disappears
=== PAUSE TestAccGlueClassifier_disappears
=== CONT  TestAccGlueClassifier_csvClassifier
=== CONT  TestAccGlueClassifier_jsonClassifier
--- PASS: TestAccGlueClassifier_csvClassifier (37.07s)
=== CONT  TestAccGlueClassifier_disappears
--- PASS: TestAccGlueClassifier_jsonClassifier (37.27s)
=== CONT  TestAccGlueClassifier_xmlClassifier
--- PASS: TestAccGlueClassifier_disappears (15.93s)
=== CONT  TestAccGlueClassifier_typeChange
--- PASS: TestAccGlueClassifier_xmlClassifier (34.76s)
=== CONT  TestAccGlueClassifier_grokClassifier
--- PASS: TestAccGlueClassifier_grokClassifier (36.98s)
=== CONT  TestAccGlueClassifier_GrokClassifier_customPatterns
--- PASS: TestAccGlueClassifier_typeChange (61.11s)
=== CONT  TestAccGlueClassifier_CSVClassifier_custom
--- PASS: TestAccGlueClassifier_GrokClassifier_customPatterns (38.53s)
=== CONT  TestAccGlueClassifier_CSVClassifier_quoteSymbol
--- PASS: TestAccGlueClassifier_CSVClassifier_custom (36.06s)
--- PASS: TestAccGlueClassifier_CSVClassifier_quoteSymbol (33.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	185.746s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 09de012 into hashicorp:main Nov 29, 2022
@github-actions github-actions bot added this to the v4.43.0 milestone Nov 29, 2022
@github-actions
Copy link

This functionality has been released in v4.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Glue Classifier support for CustomDatatypes in CSV Classifiers
2 participants