Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update available codesigning region guards #28008

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

breathingdust
Copy link
Member

Description

Relations

Closes #27986

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccLambdaFunction_codeSigning\|TestAccLambdaFunction_tracing\|TestAccLambdaFunction_basic' PKG=lambda 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunction_codeSigning\|TestAccLambdaFunction_tracing\|TestAccLambdaFunction_basic -timeout 180m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_codeSigning
=== PAUSE TestAccLambdaFunction_codeSigning
=== RUN   TestAccLambdaFunction_tracing
=== PAUSE TestAccLambdaFunction_tracing
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_tracing
=== CONT  TestAccLambdaFunction_codeSigning
--- PASS: TestAccLambdaFunction_basic (46.56s)
--- PASS: TestAccLambdaFunction_codeSigning (66.17s)
--- PASS: TestAccLambdaFunction_tracing (68.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     72.717s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 24, 2022
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Nov 28, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 28, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

us-west-2
% make testacc TESTARGS='-run=TestAccLambdaFunction_codeSigning' PKG=lambda ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 2  -run=TestAccLambdaFunction_codeSigning -timeout 180m
=== RUN   TestAccLambdaFunction_codeSigning
=== PAUSE TestAccLambdaFunction_codeSigning
=== CONT  TestAccLambdaFunction_codeSigning
--- PASS: TestAccLambdaFunction_codeSigning (91.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	98.963s
eu-central-2
% AWS_DEFAULT_REGION=eu-central-2 make testacc TESTARGS='-run=TestAccLambdaFunction_codeSigning' PKG=lambda ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 2  -run=TestAccLambdaFunction_codeSigning -timeout 180m
=== RUN   TestAccLambdaFunction_codeSigning
    function_test.go:210: Lambda code signing config is not supported in eu-central-2 region
--- SKIP: TestAccLambdaFunction_codeSigning (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	4.389s

@ewbankkit ewbankkit merged commit 3dbcf89 into main Nov 28, 2022
@ewbankkit ewbankkit deleted the b-codesigning-region-update branch November 28, 2022 15:09
@github-actions github-actions bot added this to the v4.42.0 milestone Nov 28, 2022
github-actions bot pushed a commit that referenced this pull request Nov 28, 2022
@github-actions
Copy link

This functionality has been released in v4.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AccessDeniedException for lambda/GetFunctionCodeSigningConfig in eu-central-2
2 participants