b/aws_evidently_feature - schema change WithoutTimeout to Context, description accept empty string

[GlennChia]

Description

Since this resource has waiters, the schema should be changed to use Context instead of WithoutTimeout

Relations

Relates #27395

References

Description has valid range from 0 to 160 https://docs.aws.amazon.com/cloudwatchevidently/latest/APIReference/API_CreateFeature.html#cloudwatchevidently-CreateFeature-request-description

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccEvidentlyFeature' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyFeature -timeout 180m
=== RUN   TestAccEvidentlyFeature_basic
=== PAUSE TestAccEvidentlyFeature_basic
=== RUN   TestAccEvidentlyFeature_updateDefaultVariation
=== PAUSE TestAccEvidentlyFeature_updateDefaultVariation
=== RUN   TestAccEvidentlyFeature_updateDescription
=== PAUSE TestAccEvidentlyFeature_updateDescription
=== RUN   TestAccEvidentlyFeature_updateEntityOverrides
=== PAUSE TestAccEvidentlyFeature_updateEntityOverrides
=== RUN   TestAccEvidentlyFeature_updateEvaluationStrategy
=== PAUSE TestAccEvidentlyFeature_updateEvaluationStrategy
=== RUN   TestAccEvidentlyFeature_updateVariationsBoolValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsBoolValue
=== RUN   TestAccEvidentlyFeature_updateVariationsDoubleValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsDoubleValue
=== RUN   TestAccEvidentlyFeature_updateVariationsLongValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsLongValue
=== RUN   TestAccEvidentlyFeature_updateVariationsStringValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsStringValue
=== RUN   TestAccEvidentlyFeature_tags
=== PAUSE TestAccEvidentlyFeature_tags
=== RUN   TestAccEvidentlyFeature_disappears
=== PAUSE TestAccEvidentlyFeature_disappears
=== CONT  TestAccEvidentlyFeature_basic
=== CONT  TestAccEvidentlyFeature_updateVariationsStringValue
=== CONT  TestAccEvidentlyFeature_tags
=== CONT  TestAccEvidentlyFeature_updateVariationsBoolValue
=== CONT  TestAccEvidentlyFeature_updateDescription
=== CONT  TestAccEvidentlyFeature_updateDefaultVariation
=== CONT  TestAccEvidentlyFeature_updateVariationsLongValue
=== CONT  TestAccEvidentlyFeature_disappears
=== CONT  TestAccEvidentlyFeature_updateVariationsDoubleValue
=== CONT  TestAccEvidentlyFeature_updateEntityOverrides
=== CONT  TestAccEvidentlyFeature_updateEvaluationStrategy
--- PASS: TestAccEvidentlyFeature_disappears (34.75s)
--- PASS: TestAccEvidentlyFeature_basic (39.72s)
--- PASS: TestAccEvidentlyFeature_updateEvaluationStrategy (59.01s)
--- PASS: TestAccEvidentlyFeature_updateVariationsLongValue (59.58s)
--- PASS: TestAccEvidentlyFeature_updateVariationsDoubleValue (61.18s)
--- PASS: TestAccEvidentlyFeature_updateVariationsBoolValue (61.53s)
--- PASS: TestAccEvidentlyFeature_updateDescription (61.91s)
--- PASS: TestAccEvidentlyFeature_updateDefaultVariation (62.18s)
--- PASS: TestAccEvidentlyFeature_updateEntityOverrides (62.27s)
--- PASS: TestAccEvidentlyFeature_updateVariationsStringValue (78.32s)
--- PASS: TestAccEvidentlyFeature_tags (80.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  81.084s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccEvidentlyFeature' PKG=evidently

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyFeature -timeout 180m
=== RUN   TestAccEvidentlyFeature_basic
=== PAUSE TestAccEvidentlyFeature_basic
=== RUN   TestAccEvidentlyFeature_updateDefaultVariation
=== PAUSE TestAccEvidentlyFeature_updateDefaultVariation
=== RUN   TestAccEvidentlyFeature_updateDescription
=== PAUSE TestAccEvidentlyFeature_updateDescription
=== RUN   TestAccEvidentlyFeature_updateEntityOverrides
=== PAUSE TestAccEvidentlyFeature_updateEntityOverrides
=== RUN   TestAccEvidentlyFeature_updateEvaluationStrategy
=== PAUSE TestAccEvidentlyFeature_updateEvaluationStrategy
=== RUN   TestAccEvidentlyFeature_updateVariationsBoolValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsBoolValue
=== RUN   TestAccEvidentlyFeature_updateVariationsDoubleValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsDoubleValue
=== RUN   TestAccEvidentlyFeature_updateVariationsLongValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsLongValue
=== RUN   TestAccEvidentlyFeature_updateVariationsStringValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsStringValue
=== RUN   TestAccEvidentlyFeature_tags
=== PAUSE TestAccEvidentlyFeature_tags
=== RUN   TestAccEvidentlyFeature_disappears
=== PAUSE TestAccEvidentlyFeature_disappears
=== CONT  TestAccEvidentlyFeature_basic
=== CONT  TestAccEvidentlyFeature_updateVariationsDoubleValue
=== CONT  TestAccEvidentlyFeature_tags
=== CONT  TestAccEvidentlyFeature_updateEntityOverrides
=== CONT  TestAccEvidentlyFeature_updateVariationsBoolValue
=== CONT  TestAccEvidentlyFeature_updateEvaluationStrategy
=== CONT  TestAccEvidentlyFeature_disappears
=== CONT  TestAccEvidentlyFeature_updateVariationsStringValue
=== CONT  TestAccEvidentlyFeature_updateDescription
=== CONT  TestAccEvidentlyFeature_updateVariationsLongValue
=== CONT  TestAccEvidentlyFeature_updateDefaultVariation
--- PASS: TestAccEvidentlyFeature_disappears (22.91s)
--- PASS: TestAccEvidentlyFeature_basic (24.64s)
--- PASS: TestAccEvidentlyFeature_updateEvaluationStrategy (33.22s)
--- PASS: TestAccEvidentlyFeature_updateDescription (34.12s)
--- PASS: TestAccEvidentlyFeature_updateVariationsBoolValue (34.59s)
--- PASS: TestAccEvidentlyFeature_updateDefaultVariation (34.98s)
--- PASS: TestAccEvidentlyFeature_updateVariationsDoubleValue (35.29s)
--- PASS: TestAccEvidentlyFeature_updateEntityOverrides (35.49s)
--- PASS: TestAccEvidentlyFeature_updateVariationsLongValue (35.76s)
--- PASS: TestAccEvidentlyFeature_updateVariationsStringValue (44.41s)
--- PASS: TestAccEvidentlyFeature_tags (44.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/evidently	47.594s

[johnsonaj]

@GlennChia thanks for the contribution 🎉 👏🏾 !

[github-actions]

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.