Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resources: aws_appconfig_extension and aws_appconfig_extension_association #27860

Merged
merged 14 commits into from
Nov 17, 2022

Conversation

brittandeyoung
Copy link
Collaborator

Description

This implements the aws_appconfig_extension and aws_appconfig_extension_association resources.

Relations

References

https://docs.amazonaws.cn/en_us/appconfig/latest/userguide/working-with-appconfig-extensions-about.html

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccAppConfigExtension' PKG=appconfig
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appconfig/... -v -count 1 -parallel 20  -run=TestAccAppConfigExtension -timeout 180m
=== RUN   TestAccAppConfigExtension_basic
=== PAUSE TestAccAppConfigExtension_basic
=== RUN   TestAccAppConfigExtension_ActionPoint
=== PAUSE TestAccAppConfigExtension_ActionPoint
=== RUN   TestAccAppConfigExtension_Parameter
=== PAUSE TestAccAppConfigExtension_Parameter
=== RUN   TestAccAppConfigExtension_Name
=== PAUSE TestAccAppConfigExtension_Name
=== RUN   TestAccAppConfigExtension_Description
=== PAUSE TestAccAppConfigExtension_Description
=== RUN   TestAccAppConfigExtension_tags
=== PAUSE TestAccAppConfigExtension_tags
=== RUN   TestAccAppConfigExtension_disappears
=== PAUSE TestAccAppConfigExtension_disappears
=== RUN   TestAccAppConfigExtensionAssociation_basic
=== PAUSE TestAccAppConfigExtensionAssociation_basic
=== RUN   TestAccAppConfigExtensionAssociation_Parameters
=== PAUSE TestAccAppConfigExtensionAssociation_Parameters
=== RUN   TestAccAppConfigExtensionAssociation_disappears
=== PAUSE TestAccAppConfigExtensionAssociation_disappears
=== CONT  TestAccAppConfigExtension_basic
=== CONT  TestAccAppConfigExtension_tags
=== CONT  TestAccAppConfigExtension_Name
=== CONT  TestAccAppConfigExtension_Description
=== CONT  TestAccAppConfigExtensionAssociation_disappears
=== CONT  TestAccAppConfigExtensionAssociation_Parameters
=== CONT  TestAccAppConfigExtensionAssociation_basic
=== CONT  TestAccAppConfigExtension_disappears
=== CONT  TestAccAppConfigExtension_Parameter
=== CONT  TestAccAppConfigExtension_ActionPoint
--- PASS: TestAccAppConfigExtensionAssociation_disappears (25.62s)
--- PASS: TestAccAppConfigExtension_disappears (27.38s)
--- PASS: TestAccAppConfigExtension_basic (30.73s)
--- PASS: TestAccAppConfigExtensionAssociation_basic (32.25s)
--- PASS: TestAccAppConfigExtension_Description (44.47s)
--- PASS: TestAccAppConfigExtension_Name (45.22s)
--- PASS: TestAccAppConfigExtension_Parameter (55.93s)
--- PASS: TestAccAppConfigExtension_tags (56.60s)
--- PASS: TestAccAppConfigExtension_ActionPoint (58.29s)
--- PASS: TestAccAppConfigExtensionAssociation_Parameters (65.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  67.871s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Nov 17, 2022
@brittandeyoung brittandeyoung added the new-resource Introduces a new resource. label Nov 17, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 17, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppConfigExtension' PKG=appconfig ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appconfig/... -v -count 1 -parallel 2  -run=TestAccAppConfigExtension -timeout 180m
=== RUN   TestAccAppConfigExtension_basic
=== PAUSE TestAccAppConfigExtension_basic
=== RUN   TestAccAppConfigExtension_ActionPoint
=== PAUSE TestAccAppConfigExtension_ActionPoint
=== RUN   TestAccAppConfigExtension_Parameter
=== PAUSE TestAccAppConfigExtension_Parameter
=== RUN   TestAccAppConfigExtension_Name
=== PAUSE TestAccAppConfigExtension_Name
=== RUN   TestAccAppConfigExtension_Description
=== PAUSE TestAccAppConfigExtension_Description
=== RUN   TestAccAppConfigExtension_tags
=== PAUSE TestAccAppConfigExtension_tags
=== RUN   TestAccAppConfigExtension_disappears
=== PAUSE TestAccAppConfigExtension_disappears
=== RUN   TestAccAppConfigExtensionAssociation_basic
=== PAUSE TestAccAppConfigExtensionAssociation_basic
=== RUN   TestAccAppConfigExtensionAssociation_Parameters
=== PAUSE TestAccAppConfigExtensionAssociation_Parameters
=== RUN   TestAccAppConfigExtensionAssociation_disappears
=== PAUSE TestAccAppConfigExtensionAssociation_disappears
=== CONT  TestAccAppConfigExtension_basic
=== CONT  TestAccAppConfigExtension_tags
--- PASS: TestAccAppConfigExtension_basic (24.88s)
=== CONT  TestAccAppConfigExtensionAssociation_Parameters
--- PASS: TestAccAppConfigExtension_tags (55.85s)
=== CONT  TestAccAppConfigExtensionAssociation_disappears
--- PASS: TestAccAppConfigExtensionAssociation_disappears (20.23s)
=== CONT  TestAccAppConfigExtensionAssociation_basic
--- PASS: TestAccAppConfigExtensionAssociation_Parameters (71.11s)
=== CONT  TestAccAppConfigExtension_Name
--- PASS: TestAccAppConfigExtensionAssociation_basic (20.22s)
=== CONT  TestAccAppConfigExtension_Description
--- PASS: TestAccAppConfigExtension_Description (34.74s)
=== CONT  TestAccAppConfigExtension_Parameter
--- PASS: TestAccAppConfigExtension_Name (36.16s)
=== CONT  TestAccAppConfigExtension_disappears
--- PASS: TestAccAppConfigExtension_disappears (17.71s)
=== CONT  TestAccAppConfigExtension_ActionPoint
--- PASS: TestAccAppConfigExtension_Parameter (48.45s)
--- PASS: TestAccAppConfigExtension_ActionPoint (48.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	203.478s

@ewbankkit ewbankkit merged commit 46e145b into hashicorp:main Nov 17, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 17, 2022
@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants