Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_medialive_channel: encoder settings #27823

Merged
merged 15 commits into from
Nov 17, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Nov 15, 2022

Description

aws_medialive_channel encoder ehancements.

Relations

Relates #27824

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccMediaLiveChannel_' PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20  -run=TestAccMediaLiveChannel_ -timeout 180m
=== RUN   TestAccMediaLiveChannel_basic
=== PAUSE TestAccMediaLiveChannel_basic
=== RUN   TestAccMediaLiveChannel_hls
=== PAUSE TestAccMediaLiveChannel_hls
=== RUN   TestAccMediaLiveChannel_update
=== PAUSE TestAccMediaLiveChannel_update
=== RUN   TestAccMediaLiveChannel_updateTags
=== PAUSE TestAccMediaLiveChannel_updateTags
=== RUN   TestAccMediaLiveChannel_disappears
=== PAUSE TestAccMediaLiveChannel_disappears
=== CONT  TestAccMediaLiveChannel_basic
=== CONT  TestAccMediaLiveChannel_update
=== CONT  TestAccMediaLiveChannel_disappears
=== CONT  TestAccMediaLiveChannel_updateTags
=== CONT  TestAccMediaLiveChannel_hls
--- PASS: TestAccMediaLiveChannel_disappears (83.28s)
--- PASS: TestAccMediaLiveChannel_basic (108.90s)
--- PASS: TestAccMediaLiveChannel_updateTags (115.32s)
--- PASS: TestAccMediaLiveChannel_update (131.98s)
--- PASS: TestAccMediaLiveChannel_hls (157.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	159.945s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/medialive Issues and PRs that pertain to the medialive service. labels Nov 15, 2022
@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 16, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 17, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Nov 17, 2022
@johnsonaj johnsonaj marked this pull request as ready for review November 17, 2022 18:09
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMediaLiveChannel_' PKG=medialive ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 2  -run=TestAccMediaLiveChannel_ -timeout 180m
=== RUN   TestAccMediaLiveChannel_basic
=== PAUSE TestAccMediaLiveChannel_basic
=== RUN   TestAccMediaLiveChannel_hls
=== PAUSE TestAccMediaLiveChannel_hls
=== RUN   TestAccMediaLiveChannel_update
=== PAUSE TestAccMediaLiveChannel_update
=== RUN   TestAccMediaLiveChannel_updateTags
=== PAUSE TestAccMediaLiveChannel_updateTags
=== RUN   TestAccMediaLiveChannel_disappears
=== PAUSE TestAccMediaLiveChannel_disappears
=== CONT  TestAccMediaLiveChannel_basic
=== CONT  TestAccMediaLiveChannel_updateTags
--- PASS: TestAccMediaLiveChannel_basic (123.90s)
=== CONT  TestAccMediaLiveChannel_disappears
--- PASS: TestAccMediaLiveChannel_updateTags (146.58s)
=== CONT  TestAccMediaLiveChannel_update
--- PASS: TestAccMediaLiveChannel_disappears (84.22s)
=== CONT  TestAccMediaLiveChannel_hls
--- PASS: TestAccMediaLiveChannel_hls (85.44s)
--- PASS: TestAccMediaLiveChannel_update (150.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	305.009s

@johnsonaj johnsonaj merged commit e91cefb into main Nov 17, 2022
@johnsonaj johnsonaj deleted the f-aws_medialive_channel_encoder_settings branch November 17, 2022 19:09
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 17, 2022
github-actions bot pushed a commit that referenced this pull request Nov 17, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/medialive Issues and PRs that pertain to the medialive service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants