-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_sesv2_email_identity_feedback_attributes: use the correct attribute as the resource ID in error messages #27784
r/aws_sesv2_email_identity_feedback_attributes: use the correct attribute as the resource ID in error messages #27784
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
$ make testacc PKG=sesv2 TESTS=TestAccSESV2EmailIdentityFeedbackAttributes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityFeedbackAttributes' -timeout 180m
=== RUN TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== RUN TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== RUN TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== RUN TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
=== CONT TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== CONT TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== CONT TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== CONT TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity (15.69s)
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_disappears (17.14s)
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_basic (21.84s)
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled (31.55s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 34.341s
Nice find @kamilturek! 👍 |
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR fixes the wrong attribute used in the error messages when creating the
aws_sesv2_feedback_attributes
.Relations
Relates #26796.
Output from Acceptance Testing