-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting of 0 for sampling_rate #27778
Enable setting of 0 for sampling_rate #27778
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Resource:aws_cloudfront_response_headers_policy.server_timing_headers_config
1b51f08
to
b638969
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make t T=TestAccCloudFrontResponseHeadersPolicy_ K=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontResponseHeadersPolicy_' -timeout 180m
=== RUN TestAccCloudFrontResponseHeadersPolicy_cors
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_cors
=== RUN TestAccCloudFrontResponseHeadersPolicy_customHeaders
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_customHeaders
=== RUN TestAccCloudFrontResponseHeadersPolicy_securityHeaders
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_securityHeaders
=== RUN TestAccCloudFrontResponseHeadersPolicy_serverTimingHeaders
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_serverTimingHeaders
=== RUN TestAccCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT TestAccCloudFrontResponseHeadersPolicy_cors
=== CONT TestAccCloudFrontResponseHeadersPolicy_serverTimingHeaders
=== CONT TestAccCloudFrontResponseHeadersPolicy_securityHeaders
=== CONT TestAccCloudFrontResponseHeadersPolicy_customHeaders
=== CONT TestAccCloudFrontResponseHeadersPolicy_disappears
--- PASS: TestAccCloudFrontResponseHeadersPolicy_disappears (14.67s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_customHeaders (18.71s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_securityHeaders (29.92s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_cors (30.55s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_serverTimingHeaders (49.48s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 51.331s
This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Resource:aws_cloudfront_response_headers_policy.server_timing_headers_config
Description
Allow 0 for sampling_rate in server_timing_headers_config.
Relations
Closes #27721
References
Output from Acceptance Testing