Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting of 0 for sampling_rate #27778

Merged

Conversation

Ken-Sumi1019
Copy link
Contributor

@Ken-Sumi1019 Ken-Sumi1019 commented Nov 12, 2022

Resource:aws_cloudfront_response_headers_policy.server_timing_headers_config

Description

Allow 0 for sampling_rate in server_timing_headers_config.

Relations

Closes #27721

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig'  -timeout 180m
=== RUN   TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== CONT  TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
--- PASS: TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig (108.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 108.802s```

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Nov 12, 2022
@Ken-Sumi1019 Ken-Sumi1019 marked this pull request as ready for review November 12, 2022 01:18
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. service/cloudfront Issues and PRs that pertain to the cloudfront service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 12, 2022
Resource:aws_cloudfront_response_headers_policy.server_timing_headers_config
@YakDriver YakDriver force-pushed the Enable-setting-of-0-for-sampling_rate branch from 1b51f08 to b638969 Compare February 10, 2023 22:00
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Feb 10, 2023
@YakDriver YakDriver self-assigned this Feb 10, 2023
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make t T=TestAccCloudFrontResponseHeadersPolicy_ K=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontResponseHeadersPolicy_'  -timeout 180m
=== RUN   TestAccCloudFrontResponseHeadersPolicy_cors
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_cors
=== RUN   TestAccCloudFrontResponseHeadersPolicy_customHeaders
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_customHeaders
=== RUN   TestAccCloudFrontResponseHeadersPolicy_securityHeaders
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_securityHeaders
=== RUN   TestAccCloudFrontResponseHeadersPolicy_serverTimingHeaders
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_serverTimingHeaders
=== RUN   TestAccCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicy_cors
=== CONT  TestAccCloudFrontResponseHeadersPolicy_serverTimingHeaders
=== CONT  TestAccCloudFrontResponseHeadersPolicy_securityHeaders
=== CONT  TestAccCloudFrontResponseHeadersPolicy_customHeaders
=== CONT  TestAccCloudFrontResponseHeadersPolicy_disappears
--- PASS: TestAccCloudFrontResponseHeadersPolicy_disappears (14.67s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_customHeaders (18.71s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_securityHeaders (29.92s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_cors (30.55s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_serverTimingHeaders (49.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	51.331s

@YakDriver YakDriver merged commit f9dd569 into hashicorp:main Feb 10, 2023
@github-actions github-actions bot added this to the v4.55.0 milestone Feb 10, 2023
@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Ken-Sumi1019 Ken-Sumi1019 deleted the Enable-setting-of-0-for-sampling_rate branch February 18, 2023 12:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CF response header policy: cannot set Server-Timing header sampling_rate to 0
3 participants