Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resources: aws_lightsail_lb_certificate and aws_lightsail_lb_certificate_attachment #27462

Merged

Conversation

brittandeyoung
Copy link
Collaborator

Description

This Pull request provides the following two resources:
aws_lightsail_lb_certificate and aws_lightsail_lb_certificate_attachment

Relations

None

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccLightsailLoadBalancerCertificate_' PKG=lightsail 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailLoadBalancerCertificate_ -timeout 180m
=== RUN   TestAccLightsailLoadBalancerCertificate_basic
=== PAUSE TestAccLightsailLoadBalancerCertificate_basic
=== RUN   TestAccLightsailLoadBalancerCertificate_subjectAlternativeNames
=== PAUSE TestAccLightsailLoadBalancerCertificate_subjectAlternativeNames
=== RUN   TestAccLightsailLoadBalancerCertificate_domainValidationRecords
=== PAUSE TestAccLightsailLoadBalancerCertificate_domainValidationRecords
=== RUN   TestAccLightsailLoadBalancerCertificate_disappears
=== PAUSE TestAccLightsailLoadBalancerCertificate_disappears
=== CONT  TestAccLightsailLoadBalancerCertificate_basic
=== CONT  TestAccLightsailLoadBalancerCertificate_domainValidationRecords
=== CONT  TestAccLightsailLoadBalancerCertificate_disappears
=== CONT  TestAccLightsailLoadBalancerCertificate_subjectAlternativeNames
--- PASS: TestAccLightsailLoadBalancerCertificate_disappears (148.74s)
--- PASS: TestAccLightsailLoadBalancerCertificate_basic (158.16s)
--- PASS: TestAccLightsailLoadBalancerCertificate_domainValidationRecords (158.31s)
--- PASS: TestAccLightsailLoadBalancerCertificate_subjectAlternativeNames (160.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  162.733s

make testacc TESTARGS='-run=TestAccLightsailLoadBalancerCertificateAttachment_' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailLoadBalancerCertificateAttachment_ -timeout 180m
=== RUN   TestAccLightsailLoadBalancerCertificateAttachment_basic
=== PAUSE TestAccLightsailLoadBalancerCertificateAttachment_basic
=== CONT  TestAccLightsailLoadBalancerCertificateAttachment_basic
--- PASS: TestAccLightsailLoadBalancerCertificateAttachment_basic (184.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  186.107s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2022
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailLoadBalancerCertificate_\|TestAccLightsailLoadBalancerCertificateAttachment_' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsailLoadBalancerCertificate_\|TestAccLightsailLoadBalancerCertificateAttachment_ -timeout 180m
=== RUN   TestAccLightsailLoadBalancerCertificateAttachment_basic
=== PAUSE TestAccLightsailLoadBalancerCertificateAttachment_basic
=== RUN   TestAccLightsailLoadBalancerCertificate_basic
=== PAUSE TestAccLightsailLoadBalancerCertificate_basic
=== RUN   TestAccLightsailLoadBalancerCertificate_subjectAlternativeNames
=== PAUSE TestAccLightsailLoadBalancerCertificate_subjectAlternativeNames
=== RUN   TestAccLightsailLoadBalancerCertificate_domainValidationRecords
=== PAUSE TestAccLightsailLoadBalancerCertificate_domainValidationRecords
=== RUN   TestAccLightsailLoadBalancerCertificate_disappears
=== PAUSE TestAccLightsailLoadBalancerCertificate_disappears
=== CONT  TestAccLightsailLoadBalancerCertificateAttachment_basic
=== CONT  TestAccLightsailLoadBalancerCertificate_domainValidationRecords
--- PASS: TestAccLightsailLoadBalancerCertificateAttachment_basic (152.83s)
=== CONT  TestAccLightsailLoadBalancerCertificate_subjectAlternativeNames
--- PASS: TestAccLightsailLoadBalancerCertificate_domainValidationRecords (157.00s)
=== CONT  TestAccLightsailLoadBalancerCertificate_basic
--- PASS: TestAccLightsailLoadBalancerCertificate_subjectAlternativeNames (147.23s)
=== CONT  TestAccLightsailLoadBalancerCertificate_disappears
--- PASS: TestAccLightsailLoadBalancerCertificate_basic (155.36s)
--- PASS: TestAccLightsailLoadBalancerCertificate_disappears (157.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	464.399s

@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants