-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for updating tags in apprunner vpc connection #27345
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpena027 Thanks for the PR! Made a few suggestions. I noticed there aren't any documentation changes, but based on the issue they may not be needed - I'd recommend double-checking to be sure.
resource "aws_subnet" "test" { | ||
cidr_block = "10.1.1.0/24" | ||
vpc_id = aws_vpc.test.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there specific changes being made here? Or is this just changing the order of the resources in the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, small styling changes requested.
Co-authored-by: Glenn <[email protected]>
…orm-provider-aws into f-apprunner-vpcconn-tags
@GlennChia all set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppRunnerVPCConnector_' PKG=apprunner ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 3 -run=TestAccAppRunnerVPCConnector_ -timeout 180m
=== RUN TestAccAppRunnerVPCConnector_basic
=== PAUSE TestAccAppRunnerVPCConnector_basic
=== RUN TestAccAppRunnerVPCConnector_disappears
=== PAUSE TestAccAppRunnerVPCConnector_disappears
=== RUN TestAccAppRunnerVPCConnector_tags
=== PAUSE TestAccAppRunnerVPCConnector_tags
=== CONT TestAccAppRunnerVPCConnector_basic
=== CONT TestAccAppRunnerVPCConnector_tags
=== CONT TestAccAppRunnerVPCConnector_disappears
--- PASS: TestAccAppRunnerVPCConnector_disappears (34.35s)
--- PASS: TestAccAppRunnerVPCConnector_basic (37.88s)
--- PASS: TestAccAppRunnerVPCConnector_tags (69.28s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apprunner 73.305s
@kpena027 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the ability to modify tags for
aws_apprunner_vpc_connector
.Relations
Closes #26426
References
https://pkg.go.dev/github.com/aws/[email protected]/service/apprunner#AppRunner.TagResource
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/apprunner_vpc_connector
https://docs.aws.amazon.com/apprunner/latest/api/API_TagResource.html
Output from Acceptance Testing