Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_outposts_assets - add host id and status filters #27303

Merged
merged 22 commits into from
Oct 24, 2022

Conversation

kpena027
Copy link
Contributor

@kpena027 kpena027 commented Oct 18, 2022

Description

Provides the ability to query data source aws_outposts_assets by host id and status filters. Outpost assets API does not implement filters in the standard way e.g. aws_ami data source.

Relations

Closes #27133

References

https://docs.aws.amazon.com/outposts/latest/APIReference/API_ListAssets.html
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/outposts/list-assets.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/ami

Output from Acceptance Testing

❯ make testacc PKG=outposts TESTS=TestAccOutpostsAssetsDataSource           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/outposts/... -v -count 1 -parallel 20 -run='TestAccOutpostsAssetsDataSource'  -timeout 180m
=== RUN   TestAccOutpostsAssetsDataSource_id
=== PAUSE TestAccOutpostsAssetsDataSource_id
=== RUN   TestAccOutpostsAssetsDataSource_statusFilter
=== PAUSE TestAccOutpostsAssetsDataSource_statusFilter
=== RUN   TestAccOutpostsAssetsDataSource_hostFilter
=== PAUSE TestAccOutpostsAssetsDataSource_hostFilter
=== CONT  TestAccOutpostsAssetsDataSource_id
=== CONT  TestAccOutpostsAssetsDataSource_hostFilter
=== CONT  TestAccOutpostsAssetsDataSource_statusFilter
--- PASS: TestAccOutpostsAssetsDataSource_id (11.78s)
--- PASS: TestAccOutpostsAssetsDataSource_hostFilter (12.64s)
--- PASS: TestAccOutpostsAssetsDataSource_statusFilter (12.86s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/outposts   16.543s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/outposts Issues and PRs that pertain to the outposts service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Oct 18, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @kpena027 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 18, 2022
@kpena027 kpena027 marked this pull request as ready for review October 18, 2022 18:56
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 18, 2022
Copy link
Contributor

@ddericco ddericco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR @kpena027 - looks good! Made a few suggestions.

internal/service/outposts/outpost_assets_data_source.go Outdated Show resolved Hide resolved
internal/service/outposts/outpost_assets_data_source.go Outdated Show resolved Hide resolved
internal/service/outposts/outpost_assets_data_source.go Outdated Show resolved Hide resolved
internal/service/outposts/outpost_assets_data_source.go Outdated Show resolved Hide resolved
internal/service/outposts/outpost_assets_data_source.go Outdated Show resolved Hide resolved
internal/service/outposts/outpost_assets_data_source.go Outdated Show resolved Hide resolved
.changelog/27303.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Oct 18, 2022
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, recommending some styling changes to pass the CI checks. In addition, we will also need a test for host_id_filter. Would be great if we can add the data sources with both filters as examples in the documentation as well.

website/docs/d/outposts_assets.html.markdown Outdated Show resolved Hide resolved
website/docs/d/outposts_assets.html.markdown Outdated Show resolved Hide resolved
kpena027 and others added 2 commits October 20, 2022 15:30
Co-authored-by: Glenn <[email protected]>
Co-authored-by: Glenn <[email protected]>
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 🚀

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@kpena027 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b2f49a0 into hashicorp:main Oct 24, 2022
@github-actions github-actions bot added this to the v4.37.0 milestone Oct 24, 2022
@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/outposts Issues and PRs that pertain to the outposts service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: add HostIdFilter and StatusFilter to aws_outposts_assets data source
6 participants