-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_outposts_assets - add host id and status filters #27303
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @kpena027 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR @kpena027 - looks good! Made a few suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, recommending some styling changes to pass the CI checks. In addition, we will also need a test for host_id_filter
. Would be great if we can add the data sources with both filters as examples in the documentation as well.
Co-authored-by: Glenn <[email protected]>
Co-authored-by: Glenn <[email protected]>
Co-authored-by: Glenn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@kpena027 Thanks for the contribution 🎉 👏. |
…h a single newline character'.
This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Provides the ability to query data source aws_outposts_assets by host id and status filters. Outpost assets API does not implement filters in the standard way e.g. aws_ami data source.
Relations
Closes #27133
References
https://docs.aws.amazon.com/outposts/latest/APIReference/API_ListAssets.html
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/outposts/list-assets.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/ami
Output from Acceptance Testing