Add primary_name_server attribute to aws_route53_zone

[sjparkinson]

Description

This attribute is set before sorting the list in the resource so that the value aligns to the first NS record returned by the Route 53 API.

I'm not certain that this is the way to go, but wanted to raise this to highlight the issue and discuss the different logic between the data source and the resource.

Relations

Closes #21965.

References

Previously stale issue, #3447.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @sjparkinson 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53Zone' PKG=route53 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 2  -run=TestAccRoute53Zone -timeout 180m
=== RUN   TestAccRoute53ZoneAssociation_basic
=== PAUSE TestAccRoute53ZoneAssociation_basic
=== RUN   TestAccRoute53ZoneAssociation_disappears
=== PAUSE TestAccRoute53ZoneAssociation_disappears
=== RUN   TestAccRoute53ZoneAssociation_Disappears_vpc
=== PAUSE TestAccRoute53ZoneAssociation_Disappears_vpc
=== RUN   TestAccRoute53ZoneAssociation_Disappears_zone
=== PAUSE TestAccRoute53ZoneAssociation_Disappears_zone
=== RUN   TestAccRoute53ZoneAssociation_crossAccount
=== PAUSE TestAccRoute53ZoneAssociation_crossAccount
=== RUN   TestAccRoute53ZoneAssociation_crossRegion
=== PAUSE TestAccRoute53ZoneAssociation_crossRegion
=== RUN   TestAccRoute53ZoneDataSource_id
=== PAUSE TestAccRoute53ZoneDataSource_id
=== RUN   TestAccRoute53ZoneDataSource_name
=== PAUSE TestAccRoute53ZoneDataSource_name
=== RUN   TestAccRoute53ZoneDataSource_tags
=== PAUSE TestAccRoute53ZoneDataSource_tags
=== RUN   TestAccRoute53ZoneDataSource_vpc
=== PAUSE TestAccRoute53ZoneDataSource_vpc
=== RUN   TestAccRoute53ZoneDataSource_serviceDiscovery
=== PAUSE TestAccRoute53ZoneDataSource_serviceDiscovery
=== RUN   TestAccRoute53Zone_basic
=== PAUSE TestAccRoute53Zone_basic
=== RUN   TestAccRoute53Zone_disappears
=== PAUSE TestAccRoute53Zone_disappears
=== RUN   TestAccRoute53Zone_multiple
=== PAUSE TestAccRoute53Zone_multiple
=== RUN   TestAccRoute53Zone_comment
=== PAUSE TestAccRoute53Zone_comment
=== RUN   TestAccRoute53Zone_delegationSetID
=== PAUSE TestAccRoute53Zone_delegationSetID
=== RUN   TestAccRoute53Zone_forceDestroy
=== PAUSE TestAccRoute53Zone_forceDestroy
=== RUN   TestAccRoute53Zone_ForceDestroy_trailingPeriod
=== PAUSE TestAccRoute53Zone_ForceDestroy_trailingPeriod
=== RUN   TestAccRoute53Zone_tags
=== PAUSE TestAccRoute53Zone_tags
=== RUN   TestAccRoute53Zone_VPC_single
=== PAUSE TestAccRoute53Zone_VPC_single
=== RUN   TestAccRoute53Zone_VPC_multiple
=== PAUSE TestAccRoute53Zone_VPC_multiple
=== RUN   TestAccRoute53Zone_VPC_updates
=== PAUSE TestAccRoute53Zone_VPC_updates
=== CONT  TestAccRoute53ZoneAssociation_basic
=== CONT  TestAccRoute53Zone_VPC_updates
--- PASS: TestAccRoute53ZoneAssociation_basic (168.92s)
--- PASS: TestAccRoute53Zone_basic (64.53s)
=== CONT  TestAccRoute53Zone_VPC_multiple
--- PASS: TestAccRoute53Zone_VPC_updates (242.12s)
=== CONT  TestAccRoute53Zone_VPC_single
--- PASS: TestAccRoute53Zone_VPC_single (81.73s)
=== CONT  TestAccRoute53Zone_tags
--- PASS: TestAccRoute53Zone_VPC_multiple (155.93s)
=== CONT  TestAccRoute53Zone_ForceDestroy_trailingPeriod
--- PASS: TestAccRoute53Zone_tags (93.21s)
=== CONT  TestAccRoute53Zone_forceDestroy
--- PASS: TestAccRoute53Zone_forceDestroy (203.17s)
=== CONT  TestAccRoute53Zone_delegationSetID
--- PASS: TestAccRoute53Zone_ForceDestroy_trailingPeriod (264.89s)
=== CONT  TestAccRoute53Zone_comment
--- PASS: TestAccRoute53Zone_delegationSetID (48.47s)
=== CONT  TestAccRoute53Zone_multiple
--- PASS: TestAccRoute53Zone_comment (62.40s)
=== CONT  TestAccRoute53Zone_disappears
--- PASS: TestAccRoute53Zone_multiple (60.21s)
=== CONT  TestAccRoute53ZoneDataSource_id
--- PASS: TestAccRoute53Zone_disappears (57.59s)
=== CONT  TestAccRoute53ZoneDataSource_serviceDiscovery
--- PASS: TestAccRoute53ZoneDataSource_id (56.43s)
=== CONT  TestAccRoute53ZoneDataSource_vpc
--- PASS: TestAccRoute53ZoneDataSource_serviceDiscovery (109.46s)
=== CONT  TestAccRoute53ZoneDataSource_tags
--- PASS: TestAccRoute53ZoneDataSource_vpc (108.65s)
=== CONT  TestAccRoute53ZoneDataSource_name
--- PASS: TestAccRoute53ZoneDataSource_name (66.62s)
=== CONT  TestAccRoute53ZoneAssociation_Disappears_zone
--- PASS: TestAccRoute53ZoneDataSource_tags (100.06s)
=== CONT  TestAccRoute53ZoneAssociation_crossRegion
--- PASS: TestAccRoute53ZoneAssociation_Disappears_zone (174.83s)
=== CONT  TestAccRoute53ZoneAssociation_crossAccount
    acctest.go:645: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ZoneAssociation_crossAccount (0.00s)
=== CONT  TestAccRoute53ZoneAssociation_Disappears_vpc
--- PASS: TestAccRoute53ZoneAssociation_crossRegion (163.30s)
=== CONT  TestAccRoute53ZoneAssociation_disappears
--- PASS: TestAccRoute53ZoneAssociation_Disappears_vpc (159.87s)
--- PASS: TestAccRoute53ZoneAssociation_disappears (155.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	1299.979s

[ewbankkit]

@sjparkinson Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.