Private Registry Access for Lightsail container services

[bschaatsbergen]

Description

Adds Private Registry Access, see tagged issue for more information.

Relations

Closes #27201

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccLightsailContainerService_ PKG=lightsail 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailContainerService_'  -timeout 180m
=== RUN   TestAccLightsailContainerService_basic
=== PAUSE TestAccLightsailContainerService_basic
=== RUN   TestAccLightsailContainerService_disappears
=== PAUSE TestAccLightsailContainerService_disappears
=== RUN   TestAccLightsailContainerService_Name
=== PAUSE TestAccLightsailContainerService_Name
=== RUN   TestAccLightsailContainerService_IsDisabled
=== PAUSE TestAccLightsailContainerService_IsDisabled
=== RUN   TestAccLightsailContainerService_Power
=== PAUSE TestAccLightsailContainerService_Power
=== RUN   TestAccLightsailContainerService_PublicDomainNames
=== PAUSE TestAccLightsailContainerService_PublicDomainNames
=== RUN   TestAccLightsailContainerService_PrivateRegistryAccess
=== PAUSE TestAccLightsailContainerService_PrivateRegistryAccess
=== RUN   TestAccLightsailContainerService_Scale
=== PAUSE TestAccLightsailContainerService_Scale
=== RUN   TestAccLightsailContainerService_tags
=== PAUSE TestAccLightsailContainerService_tags
=== CONT  TestAccLightsailContainerService_basic
=== CONT  TestAccLightsailContainerService_PublicDomainNames
=== CONT  TestAccLightsailContainerService_Scale
=== CONT  TestAccLightsailContainerService_tags
=== CONT  TestAccLightsailContainerService_PrivateRegistryAccess
=== CONT  TestAccLightsailContainerService_IsDisabled
=== CONT  TestAccLightsailContainerService_Power
=== CONT  TestAccLightsailContainerService_Name
=== CONT  TestAccLightsailContainerService_disappears
--- PASS: TestAccLightsailContainerService_PublicDomainNames (13.47s)
--- PASS: TestAccLightsailContainerService_PrivateRegistryAccess (79.05s)
--- PASS: TestAccLightsailContainerService_disappears (94.44s)
--- PASS: TestAccLightsailContainerService_Scale (120.85s)
--- PASS: TestAccLightsailContainerService_basic (135.28s)
--- PASS: TestAccLightsailContainerService_tags (141.43s)
--- PASS: TestAccLightsailContainerService_Power (171.34s)
--- PASS: TestAccLightsailContainerService_IsDisabled (229.41s)
--- PASS: TestAccLightsailContainerService_Name (245.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  247.315s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[bschaatsbergen]

Note to self; add computed attribute 'principalArn'

[bschaatsbergen]

Ready for review 🚀

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailContainerService_' PKG=lightsail ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 3  -run=TestAccLightsailContainerService_ -timeout 180m
=== RUN   TestAccLightsailContainerService_basic
=== PAUSE TestAccLightsailContainerService_basic
=== RUN   TestAccLightsailContainerService_disappears
=== PAUSE TestAccLightsailContainerService_disappears
=== RUN   TestAccLightsailContainerService_Name
=== PAUSE TestAccLightsailContainerService_Name
=== RUN   TestAccLightsailContainerService_IsDisabled
=== PAUSE TestAccLightsailContainerService_IsDisabled
=== RUN   TestAccLightsailContainerService_Power
=== PAUSE TestAccLightsailContainerService_Power
=== RUN   TestAccLightsailContainerService_PublicDomainNames
=== PAUSE TestAccLightsailContainerService_PublicDomainNames
=== RUN   TestAccLightsailContainerService_PrivateRegistryAccess
=== PAUSE TestAccLightsailContainerService_PrivateRegistryAccess
=== RUN   TestAccLightsailContainerService_Scale
=== PAUSE TestAccLightsailContainerService_Scale
=== RUN   TestAccLightsailContainerService_tags
=== PAUSE TestAccLightsailContainerService_tags
=== CONT  TestAccLightsailContainerService_basic
=== CONT  TestAccLightsailContainerService_PublicDomainNames
=== CONT  TestAccLightsailContainerService_IsDisabled
--- PASS: TestAccLightsailContainerService_PublicDomainNames (25.10s)
=== CONT  TestAccLightsailContainerService_Scale
--- PASS: TestAccLightsailContainerService_basic (130.00s)
=== CONT  TestAccLightsailContainerService_tags
--- PASS: TestAccLightsailContainerService_IsDisabled (132.57s)
=== CONT  TestAccLightsailContainerService_Name
--- PASS: TestAccLightsailContainerService_Scale (109.73s)
=== CONT  TestAccLightsailContainerService_PrivateRegistryAccess
--- PASS: TestAccLightsailContainerService_PrivateRegistryAccess (79.39s)
=== CONT  TestAccLightsailContainerService_disappears
--- PASS: TestAccLightsailContainerService_tags (111.10s)
=== CONT  TestAccLightsailContainerService_Power
--- PASS: TestAccLightsailContainerService_disappears (88.02s)
--- PASS: TestAccLightsailContainerService_Name (173.56s)
--- PASS: TestAccLightsailContainerService_Power (108.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	353.149s

[ewbankkit]

@bschaatsbergen Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.