Fix MaxItems for batch/compute_environments ec2_configuration

[ekini]

Description

Fix MaxItems for batch/compute_environments ec2_configuration.
There can be one or two configurations as per https://docs.aws.amazon.com/batch/latest/APIReference/API_ComputeResource.html

ec2Configuration

    Provides information used to select Amazon Machine Images (AMIs) for EC2 instances in the compute environment. If Ec2Configuration isn't specified, the default is ECS_AL2.

    One or two values can be provided.

Relations

Relates to pulumi/pulumi-aws#1920

References

The reference is in the documentation: https://docs.aws.amazon.com/batch/latest/APIReference/API_ComputeResource.html
Additionally, if you take the EC2 example from https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/batch_compute_environment with one little change: set instance types to

 instance_type = [
      "g5",
      "g4ad",
    ]

(pick the region that supports these types of instances, i.e. us-west-2), then after creating the Batch compute environment, you'll get 2 objects of ec2_configuration in the state:

$terragrunt state show aws_batch_compute_environment.sample | grep ec2_configuration -A3    
        ec2_configuration {
            image_type = "ECS_AL2"
        }
        ec2_configuration {
            image_type = "ECS_AL2_NVIDIA"
        }
    }

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[bschaatsbergen]

Hi @ekini, could you please add a changelog entry and write a test that contains 2 ec2_configuration entries.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBatchComputeEnvironment_ec2Configuration' PKG=batch ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 3  -run=TestAccBatchComputeEnvironment_ec2Configuration -timeout 180m
=== RUN   TestAccBatchComputeEnvironment_ec2Configuration
=== PAUSE TestAccBatchComputeEnvironment_ec2Configuration
=== CONT  TestAccBatchComputeEnvironment_ec2Configuration
--- PASS: TestAccBatchComputeEnvironment_ec2Configuration (55.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	64.528s

[ewbankkit]

@ekini Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[ekini]

Sorry for being too slow and thank you very much for adding the tests and merging!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.