Add support for AWS GlobalAccelerator BYOIP.

[coolfrood]

Description

This PR adds support for BYOIP IP addresses for creating AWS GlobalAccelerator accelerators

References

API reference

Relations

Closes #14002

Output from Acceptance Testing

(Changed IP address because of security reasons)

$ GLOBALACCELERATOR_BYOIP_IPV4_ADDRESS=127.0.0.1 make testacc TESTS=TestAccGlobalAcceleratorAccelerator_byoip PKG=globalaccelerator
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20 -run='TestAccGlobalAcceleratorAccelerator_byoip'  -timeout 180m
=== RUN   TestAccGlobalAcceleratorAccelerator_byoip
=== PAUSE TestAccGlobalAcceleratorAccelerator_byoip
=== CONT  TestAccGlobalAcceleratorAccelerator_byoip
--- PASS: TestAccGlobalAcceleratorAccelerator_byoip (59.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	59.571s

$ make testacc TESTS=TestAccGlobalAcceleratorAccelerator_byoip PKG=globalaccelerator
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20 -run='TestAccGlobalAcceleratorAccelerator_byoip'  -timeout 180m
=== RUN   TestAccGlobalAcceleratorAccelerator_byoip
=== PAUSE TestAccGlobalAcceleratorAccelerator_byoip
=== CONT  TestAccGlobalAcceleratorAccelerator_byoip
    accelerator_test.go:337: Environment variable GLOBALACCELERATOR_BYOIP_IPV4_ADDRESS not set
--- SKIP: TestAccGlobalAcceleratorAccelerator_byoip (0.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	0.604s

I am a member of AWS Global Accelerator engineering team.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @coolfrood 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@coolfrood Thanks for the contribution 👏.
I've left some review comments.
Please also update the documentation page in website/docs/r/globalaccelerator_accelerator.html.markdown.

[coolfrood]

Thanks @ewbankkit. I'll address your comments in next commit.

[coolfrood]

@ewbankkit I have addressed all except one of your review comments.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlobalAcceleratorAccelerator_' PKG=globalaccelerator ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 2  -run=TestAccGlobalAcceleratorAccelerator_ -timeout 180m
=== RUN   TestAccGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccGlobalAcceleratorAccelerator_basic
=== RUN   TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== PAUSE TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== RUN   TestAccGlobalAcceleratorAccelerator_byoip
=== PAUSE TestAccGlobalAcceleratorAccelerator_byoip
=== RUN   TestAccGlobalAcceleratorAccelerator_disappears
=== PAUSE TestAccGlobalAcceleratorAccelerator_disappears
=== RUN   TestAccGlobalAcceleratorAccelerator_update
=== PAUSE TestAccGlobalAcceleratorAccelerator_update
=== RUN   TestAccGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccGlobalAcceleratorAccelerator_tags
=== CONT  TestAccGlobalAcceleratorAccelerator_basic
=== CONT  TestAccGlobalAcceleratorAccelerator_update
--- PASS: TestAccGlobalAcceleratorAccelerator_basic (84.03s)
=== CONT  TestAccGlobalAcceleratorAccelerator_byoip
    accelerator_test.go:338: Environment variable GLOBALACCELERATOR_BYOIP_IPV4_ADDRESS not set
--- SKIP: TestAccGlobalAcceleratorAccelerator_byoip (0.15s)
=== CONT  TestAccGlobalAcceleratorAccelerator_disappears
--- PASS: TestAccGlobalAcceleratorAccelerator_update (192.70s)
=== CONT  TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
--- PASS: TestAccGlobalAcceleratorAccelerator_disappears (115.87s)
=== CONT  TestAccGlobalAcceleratorAccelerator_tags
--- PASS: TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack (80.25s)
=== CONT  TestAccGlobalAcceleratorAccelerator_attributes
--- PASS: TestAccGlobalAcceleratorAccelerator_tags (106.83s)
--- PASS: TestAccGlobalAcceleratorAccelerator_attributes (274.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	551.881s

[coolfrood]

Thanks for fixing the terrafmt error, @ewbankkit. Is there anything else you need?

[ewbankkit]

@coolfrood Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.