Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: provide importer for aws_network_interface_sg_attachment #27076

Closed
trajano opened this issue Oct 3, 2022 · 3 comments · Fixed by #27785
Closed

[Enhancement]: provide importer for aws_network_interface_sg_attachment #27076

trajano opened this issue Oct 3, 2022 · 3 comments · Fixed by #27785
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpc Issues and PRs that pertain to the vpc service.
Milestone

Comments

@trajano
Copy link

trajano commented Oct 3, 2022

Description

I can't find the code that sets the importer in https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/ec2/vpc_network_interface_sg_attachment.go so I presume it wasn't written out.

It would be beneficial to have it as it will allow transitioning existing states to use the new mapping rather than performing a taint to build without it.

https://stackoverflow.com/questions/73940278/how-do-i-import-aws-network-interface-sg-attachment

Affected Resource(s) and/or Data Source(s)

  • aws_network_interface_sg_attachment

Potential Terraform Configuration

No response

References

terraform import aws_network_interface_sg_attachment.foo i-abcdef/sg-1234567

Would you like to implement a fix?

No

@trajano trajano added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Oct 3, 2022
@github-actions github-actions bot added the service/vpc Issues and PRs that pertain to the vpc service. label Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 31, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 15, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpc Issues and PRs that pertain to the vpc service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants