Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source] d/aws_vpc_ipam_pool_cidrs #27051

Merged
merged 7 commits into from
Oct 3, 2022

Conversation

drewmullen
Copy link
Collaborator

Description

Adds a new data source to list all cidrs provisioned into a pool. This is especially helpful for those who receive a pool via ram sharing and want to add all CIDRs from a pool to route tables.

Relations

Closes #27040

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccIPAMPoolCidrsDataSource_basic PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolCidrsDataSource_basic'  -timeout 180m
=== RUN   TestAccIPAMPoolCidrsDataSource_basic
=== PAUSE TestAccIPAMPoolCidrsDataSource_basic
=== CONT  TestAccIPAMPoolCidrsDataSource_basic
--- PASS: TestAccIPAMPoolCidrsDataSource_basic (123.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        127.394s

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ipam Issues and PRs that pertain to the ipam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 1, 2022
@drewmullen drewmullen removed the needs-triage Waiting for first response or review from a maintainer. label Oct 3, 2022
@drewmullen
Copy link
Collaborator Author

added pagination

make testacc TESTS=TestAccIPAMPoolCIDRsDataSource_basic PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolCIDRsDataSource_basic'  -timeout 180m
=== RUN   TestAccIPAMPoolCIDRsDataSource_basic
=== PAUSE TestAccIPAMPoolCIDRsDataSource_basic
=== CONT  TestAccIPAMPoolCIDRsDataSource_basic
--- PASS: TestAccIPAMPoolCIDRsDataSource_basic (124.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        126.806s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Oct 3, 2022
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIPAMPoolCIDRsDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccIPAMPoolCIDRsDataSource_ -timeout 180m
=== RUN   TestAccIPAMPoolCIDRsDataSource_basic
=== PAUSE TestAccIPAMPoolCIDRsDataSource_basic
=== CONT  TestAccIPAMPoolCIDRsDataSource_basic
--- PASS: TestAccIPAMPoolCIDRsDataSource_basic (94.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	98.742s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 17e4705 into hashicorp:main Oct 3, 2022
@github-actions github-actions bot added this to the v4.34.0 milestone Oct 3, 2022
@drewmullen drewmullen deleted the f-ds_aws_vpc_ipam_pool_cidrs branch October 3, 2022 19:39
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/ipam Issues and PRs that pertain to the ipam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_vpc_ipam_pool_cidrs
4 participants