-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Adding 'upgrade' cloudwatch log export type for AWS RDS Cluster #26792
Fix: Adding 'upgrade' cloudwatch log export type for AWS RDS Cluster #26792
Conversation
…sterExportableLogType_Values
…th 'postgresql' and 'upgrade'
…ptance test configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql' PKG=rds ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 1 -run=TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql -timeout 360m
=== RUN TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== CONT TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (1739.28s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 1743.501s
@matharoo Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
This PR adds the
upgrade
cloudwatch log export type which is supported by AWS for RDS clusters with Postgres engine.Affected resource:
aws_rds_cluster
Closes #26791
Output from acceptance testing:
[ Need help with running test make testacc TESTS=TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql PKG=rds ]: