Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS VPC Traffic Mirroring - enable GWLB as a valid traffic mirror target #26767

Closed
meetreks opened this issue Sep 12, 2022 · 6 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/vpc Issues and PRs that pertain to the vpc service.

Comments

@meetreks
Copy link
Contributor

meetreks commented Sep 12, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The resource aws_ec2_traffic_mirror_target currently supports network_load_balancer_arn and network_interface_id as its valid input parameters. AWS Introduced GWLB as a valid Traffic Mirror target in May 2022 and hence this new input must be enabled in this resource.

New or Affected Resource(s)

  • aws_ec2_traffic_mirror_target

Potential Terraform Configuration

resource "aws_ec2_traffic_mirror_target" "gwlb" {
  description          = "GWLB target"
  gateway_load_balancer_endpoint = aws_vpc_endpoint.example.id
}

References

https://aws.amazon.com/blogs/networking-and-content-delivery/introduction-to-traffic-mirroring-to-gwlb-endpoints-as-target/
https://docs.aws.amazon.com/vpc/latest/mirroring/tm-example-glb-endpoints.html

  • #0000
@meetreks meetreks added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 12, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/vpc Issues and PRs that pertain to the vpc service. labels Sep 12, 2022
@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 13, 2022
@meetreks
Copy link
Contributor Author

I have done the resource part, updated the testing package and currently testing it. Watch this space.

@meetreks
Copy link
Contributor Author

meetreks commented Sep 19, 2022

Acceptance Test Results:

:~/terraform-provider-aws (f-aws_ec2_traffic_mirror_target) $ make testacc PKG=ec2 TESTS=TestAccVPCTrafficMirrorTarget_gwlb ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCTrafficMirrorTarget_gwlb' -timeout 180m === RUN TestAccVPCTrafficMirrorTarget_gwlb === PAUSE TestAccVPCTrafficMirrorTarget_gwlb === CONT TestAccVPCTrafficMirrorTarget_gwlb --- PASS: TestAccVPCTrafficMirrorTarget_gwlb (339.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 339.869s :~/terraform-provider-aws (f-aws_ec2_traffic_mirror_target) $

@meetreks
Copy link
Contributor Author

PR raised to cover this change -- #26864
Next Steps: PR to be reviewed and merged.

@meetreks
Copy link
Contributor Author

PR Review complete and request submitted for final approval and merge.

@meetreks
Copy link
Contributor Author

We can close this issue, PR now approved and merged to main.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/vpc Issues and PRs that pertain to the vpc service.
Projects
None yet
Development

No branches or pull requests

2 participants