Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing anonymous_auth_enabled parameter #26746

Merged
merged 7 commits into from
Mar 13, 2023

Conversation

dpattmann
Copy link
Contributor

@dpattmann dpattmann commented Sep 9, 2022

Description

The function flattenAdvancedSecurityOptions, used from the aws_opensearch_domain resource, tries to set anonymous_auth_enabled to a boolean value but the field is missing in the data resource model. This PR adds this field to the data resource.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26668

Output from acceptance testing:

$ make testacc TESTS=TestAccOpenSearchDomainDataSource_ PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomainDataSource_ -timeout 180m
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (1597.77s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (1856.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	1858.491s
...

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/opensearch Issues and PRs that pertain to the opensearch service. needs-triage Waiting for first response or review from a maintainer. labels Sep 9, 2022
@dpattmann dpattmann marked this pull request as ready for review September 12, 2022 19:33
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Sep 12, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 12, 2022
@fmartinou
Copy link

Hi,

Any news regarding this PR?
Is something missing to get it merged and available in the next release?

.changelog/26746.txt Outdated Show resolved Hide resolved
@anithapriyanatarajan
Copy link

Hi, can someone please confirm if this issue is fixed?

@neovatar
Copy link

We encountered the same problem and are stuck with an old provider version - a merge and release of the PR would really be appreciated!

@ltdeoliveira
Copy link

Any ETA for merging this PR? This fixes a critical issue for my team.

@barthel
Copy link

barthel commented Mar 8, 2023

@justinretzolk help would be appreciated, thanks.

@ewbankkit ewbankkit self-assigned this Mar 13, 2023
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 13, 2023
@barthel
Copy link

barthel commented Mar 13, 2023

Thanks @ewbankkit for take over and pushing this issue.

@ewbankkit ewbankkit force-pushed the b-aws_opensearch_domain-26668 branch from 727df7e to 31c5113 Compare March 13, 2023 15:18
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_advanced' PKG=opensearch ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 3  -run=TestAccOpenSearchDomainDataSource_Data_advanced -timeout 180m
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2452.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2457.830s

@ewbankkit
Copy link
Contributor

@dpattmann Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5741a87 into hashicorp:main Mar 13, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 13, 2023
@dpattmann dpattmann deleted the b-aws_opensearch_domain-26668 branch March 13, 2023 20:07
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/opensearch Issues and PRs that pertain to the opensearch service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasource aws_opensearch_domain fails when advanced_security_options is enabled
9 participants