Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_medialive_input and aws_medialive_input_security_group #26550

Merged
merged 25 commits into from
Aug 31, 2022
Merged

New Resource: aws_medialive_input and aws_medialive_input_security_group #26550

merged 25 commits into from
Aug 31, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Aug 30, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4936
Supersedes and Closes #12681

Output from acceptance testing:

AWS Commercial - Input Security Group

$ make testacc TESTS=TestAccMediaLiveInputSecurityGroup_ PKG=medialive
 ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveInputSecurityGroup_'  -timeout 180m
=== RUN   TestAccMediaLiveInputSecurityGroup_basic
=== PAUSE TestAccMediaLiveInputSecurityGroup_basic
=== RUN   TestAccMediaLiveInputSecurityGroup_updateCidr
=== PAUSE TestAccMediaLiveInputSecurityGroup_updateCidr
=== RUN   TestAccMediaLiveInputSecurityGroup_updateTags
=== PAUSE TestAccMediaLiveInputSecurityGroup_updateTags
=== RUN   TestAccMediaLiveInputSecurityGroup_disappears
=== PAUSE TestAccMediaLiveInputSecurityGroup_disappears
=== CONT  TestAccMediaLiveInputSecurityGroup_basic
=== CONT  TestAccMediaLiveInputSecurityGroup_updateTags
=== CONT  TestAccMediaLiveInputSecurityGroup_disappears
=== CONT  TestAccMediaLiveInputSecurityGroup_updateCidr
--- PASS: TestAccMediaLiveInputSecurityGroup_disappears (15.26s)
--- PASS: TestAccMediaLiveInputSecurityGroup_basic (16.04s)
--- PASS: TestAccMediaLiveInputSecurityGroup_updateCidr (24.89s)
--- PASS: TestAccMediaLiveInputSecurityGroup_updateTags (33.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	35.825s
...

AWS Gov Cloud - Input Security Group

$ make testacc TESTS=TestAccMediaLiveInputSecurityGroup_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveInputSecurityGroup_'  -timeout 180m
=== RUN   TestAccMediaLiveInputSecurityGroup_basic
=== PAUSE TestAccMediaLiveInputSecurityGroup_basic
=== RUN   TestAccMediaLiveInputSecurityGroup_updateCidr
=== PAUSE TestAccMediaLiveInputSecurityGroup_updateCidr
=== RUN   TestAccMediaLiveInputSecurityGroup_updateTags
=== PAUSE TestAccMediaLiveInputSecurityGroup_updateTags
=== RUN   TestAccMediaLiveInputSecurityGroup_disappears
=== PAUSE TestAccMediaLiveInputSecurityGroup_disappears
=== CONT  TestAccMediaLiveInputSecurityGroup_basic
=== CONT  TestAccMediaLiveInputSecurityGroup_updateTags
=== CONT  TestAccMediaLiveInputSecurityGroup_disappears
=== CONT  TestAccMediaLiveInputSecurityGroup_updateCidr
=== CONT  TestAccMediaLiveInputSecurityGroup_basic
    acctest.go:654: skipping tests; partition aws-us-gov does not support medialive service
--- SKIP: TestAccMediaLiveInputSecurityGroup_basic (0.85s)
=== CONT  TestAccMediaLiveInputSecurityGroup_disappears
    acctest.go:654: skipping tests; partition aws-us-gov does not support medialive service
--- SKIP: TestAccMediaLiveInputSecurityGroup_disappears (0.85s)
=== CONT  TestAccMediaLiveInputSecurityGroup_updateCidr
    acctest.go:654: skipping tests; partition aws-us-gov does not support medialive service
--- SKIP: TestAccMediaLiveInputSecurityGroup_updateCidr (0.85s)
=== CONT  TestAccMediaLiveInputSecurityGroup_updateTags
    acctest.go:654: skipping tests; partition aws-us-gov does not support medialive service
--- SKIP: TestAccMediaLiveInputSecurityGroup_updateTags (0.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	3.315s

AWS Commercial - Input

$ make testacc TESTS=TestAccMediaLiveInput_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveInput_'  -timeout 180m
=== RUN   TestAccMediaLiveInput_basic
=== PAUSE TestAccMediaLiveInput_basic
=== RUN   TestAccMediaLiveInput_update
=== PAUSE TestAccMediaLiveInput_update
=== RUN   TestAccMediaLiveInput_updateTags
=== PAUSE TestAccMediaLiveInput_updateTags
=== RUN   TestAccMediaLiveInput_disappears
=== PAUSE TestAccMediaLiveInput_disappears
=== CONT  TestAccMediaLiveInput_basic
=== CONT  TestAccMediaLiveInput_update
=== CONT  TestAccMediaLiveInput_updateTags
=== CONT  TestAccMediaLiveInput_disappears
--- PASS: TestAccMediaLiveInput_disappears (58.32s)
--- PASS: TestAccMediaLiveInput_basic (58.83s)
--- PASS: TestAccMediaLiveInput_updateTags (80.55s)
--- PASS: TestAccMediaLiveInput_update (98.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	101.687s

AWS Gov Cloud - Input

make testacc TESTS=TestAccMediaLiveInput_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveInput_'  -timeout 180m
=== RUN   TestAccMediaLiveInput_basic
=== PAUSE TestAccMediaLiveInput_basic
=== RUN   TestAccMediaLiveInput_update
=== PAUSE TestAccMediaLiveInput_update
=== RUN   TestAccMediaLiveInput_updateTags
=== PAUSE TestAccMediaLiveInput_updateTags
=== RUN   TestAccMediaLiveInput_disappears
=== PAUSE TestAccMediaLiveInput_disappears
=== CONT  TestAccMediaLiveInput_basic
=== CONT  TestAccMediaLiveInput_updateTags
=== CONT  TestAccMediaLiveInput_update
=== CONT  TestAccMediaLiveInput_disappears
=== CONT  TestAccMediaLiveInput_updateTags
    acctest.go:654: skipping tests; partition aws-us-gov does not support medialive service
--- SKIP: TestAccMediaLiveInput_updateTags (0.83s)
=== CONT  TestAccMediaLiveInput_update
    acctest.go:654: skipping tests; partition aws-us-gov does not support medialive service
--- SKIP: TestAccMediaLiveInput_update (0.83s)
=== CONT  TestAccMediaLiveInput_disappears
    acctest.go:654: skipping tests; partition aws-us-gov does not support medialive service
--- SKIP: TestAccMediaLiveInput_disappears (0.83s)
=== CONT  TestAccMediaLiveInput_basic
    acctest.go:654: skipping tests; partition aws-us-gov does not support medialive service
--- SKIP: TestAccMediaLiveInput_basic (0.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	3.298s

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/medialive Issues and PRs that pertain to the medialive service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Aug 30, 2022
@johnsonaj johnsonaj added the new-resource Introduces a new resource. label Aug 30, 2022
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Aug 30, 2022
@johnsonaj johnsonaj marked this pull request as ready for review August 30, 2022 22:40
@johnsonaj johnsonaj force-pushed the f-aws_medialive_input branch 2 times, most recently from 392869c to 124a58a Compare August 31, 2022 15:48
ewbankkit
ewbankkit approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMediaLive' PKG=medialive ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 2  -run=TestAccMediaLive -timeout 180m
go: downloading github.com/aws/aws-sdk-go-v2/service/medialive v1.22.5
=== RUN   TestAccMediaLiveInputSecurityGroup_basic
=== PAUSE TestAccMediaLiveInputSecurityGroup_basic
=== RUN   TestAccMediaLiveInputSecurityGroup_updateCIDR
=== PAUSE TestAccMediaLiveInputSecurityGroup_updateCIDR
=== RUN   TestAccMediaLiveInputSecurityGroup_updateTags
=== PAUSE TestAccMediaLiveInputSecurityGroup_updateTags
=== RUN   TestAccMediaLiveInputSecurityGroup_disappears
=== PAUSE TestAccMediaLiveInputSecurityGroup_disappears
=== RUN   TestAccMediaLiveInput_basic
=== PAUSE TestAccMediaLiveInput_basic
=== RUN   TestAccMediaLiveInput_update
=== PAUSE TestAccMediaLiveInput_update
=== RUN   TestAccMediaLiveInput_updateTags
=== PAUSE TestAccMediaLiveInput_updateTags
=== RUN   TestAccMediaLiveInput_disappears
=== PAUSE TestAccMediaLiveInput_disappears
=== CONT  TestAccMediaLiveInputSecurityGroup_basic
=== CONT  TestAccMediaLiveInput_basic
--- PASS: TestAccMediaLiveInputSecurityGroup_basic (32.78s)
=== CONT  TestAccMediaLiveInputSecurityGroup_updateTags
--- PASS: TestAccMediaLiveInput_basic (66.54s)
=== CONT  TestAccMediaLiveInputSecurityGroup_disappears
--- PASS: TestAccMediaLiveInputSecurityGroup_disappears (26.51s)
=== CONT  TestAccMediaLiveInput_updateTags
--- PASS: TestAccMediaLiveInputSecurityGroup_updateTags (70.90s)
=== CONT  TestAccMediaLiveInput_disappears
--- PASS: TestAccMediaLiveInput_disappears (63.12s)
=== CONT  TestAccMediaLiveInputSecurityGroup_updateCIDR
--- PASS: TestAccMediaLiveInput_updateTags (109.04s)
=== CONT  TestAccMediaLiveInput_update
--- PASS: TestAccMediaLiveInputSecurityGroup_updateCIDR (50.80s)
--- PASS: TestAccMediaLiveInput_update (115.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	329.811s

@johnsonaj johnsonaj merged commit b57ab19 into main Aug 31, 2022
@johnsonaj johnsonaj deleted the f-aws_medialive_input branch August 31, 2022 21:36
@github-actions github-actions bot added this to the v4.29.0 milestone Aug 31, 2022
github-actions bot pushed a commit that referenced this pull request Aug 31, 2022
Update CHANGELOG.md for #26550
1c88ac7
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/medialive Issues and PRs that pertain to the medialive service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsonaj @ewbankkit