Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_eks_node_group: Add capacity_type attribute #26521

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

Vrtak-CZ
Copy link
Contributor

@Vrtak-CZ Vrtak-CZ commented Aug 29, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccEKSNodeGroupDataSource_basic PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSNodeGroupDataSource_basic'  -timeout 180m
=== RUN   TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (958.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        960.380s...

@github-actions
Copy link

Hey @Vrtak-CZ 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Aug 29, 2022
@Vrtak-CZ Vrtak-CZ force-pushed the eks-node-group-capacity-type branch from 4a73b4b to 44f30cb Compare August 29, 2022 14:10
@Vrtak-CZ Vrtak-CZ changed the title Draft: d/aws_eks_node_group: Add capacity_type attribute d/aws_eks_node_group: Add capacity_type attribute Aug 29, 2022
@Vrtak-CZ
Copy link
Contributor Author

your organization may not allow you to change this setting. If that is the case, let us know.

I'm letting you know I do not know how to enable this in our organization.

@Vrtak-CZ Vrtak-CZ force-pushed the eks-node-group-capacity-type branch from 44f30cb to bea2db6 Compare August 29, 2022 14:58
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 29, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 30, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSNodeGroupDataSource_' PKG=eks ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 3  -run=TestAccEKSNodeGroupDataSource_ -timeout 180m
=== RUN   TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (1033.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1037.207s

@ewbankkit
Copy link
Contributor

@Vrtak-CZ Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit af608d0 into hashicorp:main Aug 30, 2022
@github-actions github-actions bot added this to the v4.29.0 milestone Aug 30, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants