Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redshiftserverless workgroup resource #26467

Merged
merged 13 commits into from
Aug 25, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 24, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #24501

Output from acceptance testing:

$ make testacc TESTS=TestAccRedshiftServerlessWorkgroup_  PKG=redshiftserverless
--- PASS: TestAccRedshiftServerlessWorkgroup_disappears (476.81s)
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (489.51s)
--- PASS: TestAccRedshiftServerlessWorkgroup_tags (512.88s)

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 24, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Aug 24, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 24, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 24, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review August 24, 2022 16:01
@github-actions github-actions bot added generators Relates to code generators. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Aug 25, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftServerlessWorkgroup_' PKG=redshiftserverless ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 2  -run=TestAccRedshiftServerlessWorkgroup_ -timeout 180m
=== RUN   TestAccRedshiftServerlessWorkgroup_basic
=== PAUSE TestAccRedshiftServerlessWorkgroup_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_tags
=== PAUSE TestAccRedshiftServerlessWorkgroup_tags
=== RUN   TestAccRedshiftServerlessWorkgroup_disappears
=== PAUSE TestAccRedshiftServerlessWorkgroup_disappears
=== CONT  TestAccRedshiftServerlessWorkgroup_basic
=== CONT  TestAccRedshiftServerlessWorkgroup_disappears
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (511.29s)
=== CONT  TestAccRedshiftServerlessWorkgroup_tags
--- PASS: TestAccRedshiftServerlessWorkgroup_disappears (517.23s)
--- PASS: TestAccRedshiftServerlessWorkgroup_tags (848.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	1364.018s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit mentioned this pull request Aug 25, 2022
3 tasks
@ewbankkit ewbankkit merged commit 690d654 into hashicorp:main Aug 25, 2022
@github-actions github-actions bot added this to the v4.28.0 milestone Aug 25, 2022
@github-actions
Copy link

This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants