Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_chime_voice_connector_logging - Enable Media Metrics Logging #26283

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

breathingdust
Copy link
Member

@breathingdust breathingdust commented Aug 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Adds an attribute to allow control of media metric monitoring.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccChimeVoiceConnectorLogging_' PKG=chime
go test ./internal/service/chime/... -v -count 1 -parallel 20  -run=TestAccChimeVoiceConnectorLogging_ -timeout 180m
=== RUN   TestAccChimeVoiceConnectorLogging_basic
=== PAUSE TestAccChimeVoiceConnectorLogging_basic
=== RUN   TestAccChimeVoiceConnectorLogging_disappears
=== PAUSE TestAccChimeVoiceConnectorLogging_disappears
=== RUN   TestAccChimeVoiceConnectorLogging_update
=== PAUSE TestAccChimeVoiceConnectorLogging_update
=== CONT  TestAccChimeVoiceConnectorLogging_basic
=== CONT  TestAccChimeVoiceConnectorLogging_update
=== CONT  TestAccChimeVoiceConnectorLogging_disappears
--- PASS: TestAccChimeVoiceConnectorLogging_basic (16.20s)
--- PASS: TestAccChimeVoiceConnectorLogging_update (24.40s)
--- PASS: TestAccChimeVoiceConnectorLogging_disappears (33.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	38.704s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Aug 12, 2022
@breathingdust breathingdust marked this pull request as ready for review August 12, 2022 22:26
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccChimeVoiceConnectorLogging_' PKG=chime
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20  -run=TestAccChimeVoiceConnectorLogging_ -timeout 180m
=== RUN   TestAccChimeVoiceConnectorLogging_basic
=== PAUSE TestAccChimeVoiceConnectorLogging_basic
=== RUN   TestAccChimeVoiceConnectorLogging_disappears
=== PAUSE TestAccChimeVoiceConnectorLogging_disappears
=== RUN   TestAccChimeVoiceConnectorLogging_update
=== PAUSE TestAccChimeVoiceConnectorLogging_update
=== CONT  TestAccChimeVoiceConnectorLogging_basic
=== CONT  TestAccChimeVoiceConnectorLogging_update
=== CONT  TestAccChimeVoiceConnectorLogging_disappears
--- PASS: TestAccChimeVoiceConnectorLogging_disappears (16.84s)
--- PASS: TestAccChimeVoiceConnectorLogging_basic (19.37s)
--- PASS: TestAccChimeVoiceConnectorLogging_update (30.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	33.916s

@breathingdust breathingdust merged commit 8ba2eb8 into main Aug 15, 2022
@breathingdust breathingdust deleted the f-chime-vc-media-metrics branch August 15, 2022 14:32
@github-actions github-actions bot added this to the v4.27.0 milestone Aug 15, 2022
github-actions bot pushed a commit that referenced this pull request Aug 15, 2022
@github-actions
Copy link

This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/chime Issues and PRs that pertain to the chime service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants