Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_acm_certificate - Add validity dates #26281

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Conversation

breathingdust
Copy link
Member

@breathingdust breathingdust commented Aug 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccACMCertificate_' PKG=acm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acm/... -v -count 1 -parallel 20 -run='TestAccACMCertificate_'  -timeout 180m
=== RUN   TestAccACMCertificate_Imported_domainName
=== PAUSE TestAccACMCertificate_Imported_domainName
=== RUN   TestAccACMCertificate_Imported_validityDates
=== PAUSE TestAccACMCertificate_Imported_validityDates
=== RUN   TestAccACMCertificate_Imported_ipAddress
=== PAUSE TestAccACMCertificate_Imported_ipAddress
=== RUN   TestAccACMCertificate_PrivateKey_tags
=== PAUSE TestAccACMCertificate_PrivateKey_tags
=== CONT  TestAccACMCertificate_privateCert
=== CONT  TestAccACMCertificate_Imported_ipAddress
=== CONT  TestAccACMCertificate_Imported_validityDates
=== CONT  TestAccACMCertificate_Imported_domainName
=== CONT  TestAccACMCertificate_PrivateKey_tags
--- PASS: TestAccACMCertificate_Imported_ipAddress (16.85s)
--- PASS: TestAccACMCertificate_Imported_validityDates (18.46s)
--- PASS: TestAccACMCertificate_privateCert (22.96s)
--- PASS: TestAccACMCertificate_Imported_domainName (33.10s)
--- PASS: TestAccACMCertificate_PrivateKey_tags (40.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	44.662s

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/acm Issues and PRs that pertain to the acm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 12, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Aug 15, 2022
@breathingdust breathingdust marked this pull request as ready for review August 15, 2022 17:27
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

--- PASS: TestAccACMCertificate_SubjectAlternativeNames_emptyString (3.97s)
--- PASS: TestAccACMCertificate_Root_trailingPeriod (4.02s)
--- PASS: TestAccACMCertificate_Imported_ipAddress (22.81s)
--- PASS: TestAccACMCertificate_Imported_validityDates (23.20s)
--- PASS: TestAccACMCertificate_root (34.31s)
--- PASS: TestAccACMCertificate_privateCert (35.57s)
--- PASS: TestAccACMCertificate_wildcardAndRootSan (37.51s)
--- PASS: TestAccACMCertificate_wildcard (37.52s)
--- PASS: TestAccACMCertificate_disableCTLogging (40.00s)
--- PASS: TestAccACMCertificate_validationOptions (40.47s)
--- PASS: TestAccACMCertificate_San_trailingPeriod (41.16s)
--- PASS: TestAccACMCertificate_San_single (41.72s)
--- PASS: TestAccACMCertificate_emailValidation (42.04s)
--- PASS: TestAccACMCertificate_rootAndWildcardSan (42.33s)
--- PASS: TestAccACMCertificate_dnsValidation (42.44s)
--- PASS: TestAccACMCertificate_San_matches_domain (47.40s)
--- PASS: TestAccACMCertificate_San_multiple (47.95s)
--- PASS: TestAccACMCertificate_Imported_domainName (60.72s)
--- PASS: TestAccACMCertificate_PrivateKey_tags (69.97s)

@breathingdust breathingdust merged commit c8dacb0 into main Aug 16, 2022
@breathingdust breathingdust deleted the f-acm-cert-validity-dates branch August 16, 2022 15:15
@github-actions github-actions bot added this to the v4.27.0 milestone Aug 16, 2022
@github-actions
Copy link

This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/acm Issues and PRs that pertain to the acm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants