Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodb_table: Fix replica.*propagate_tags bug #26257

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26255

Output from acceptance testing:

% make testacc TESTS=TestAccDynamoDBTable_ PKG=dynamodb 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_'  -timeout 180m
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (48.61s)
--- PASS: TestAccDynamoDBTable_basic (109.48s)
--- PASS: TestAccDynamoDBTable_TTL_enabled (120.01s)
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (125.09s)
--- PASS: TestAccDynamoDBTable_tags (128.46s)
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (17.56s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (175.98s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (185.77s)
--- PASS: TestAccDynamoDBTable_tableClassInfrequentAccess (187.02s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (210.47s)
--- PASS: TestAccDynamoDBTable_encryption (281.11s)
--- PASS: TestAccDynamoDBTable_streamSpecification (141.11s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (141.17s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (136.45s)
--- PASS: TestAccDynamoDBTable_backupEncryption (375.33s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisionedIgnoreChanges (94.56s)
--- PASS: TestAccDynamoDBTable_enablePITR (110.65s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (190.46s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (90.11s)
--- PASS: TestAccDynamoDBTable_disappears (36.92s)
--- PASS: TestAccDynamoDBTable_Replica_tagsOneOfTwo (396.85s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (126.71s)
--- PASS: TestAccDynamoDBTable_Replica_single (508.68s)
--- PASS: TestAccDynamoDBTable_Replica_tagsTwoOfTwo (417.11s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (531.46s)
--- PASS: TestAccDynamoDBTable_Replica_pitr (433.89s)
--- PASS: TestAccDynamoDBTable_Replica_tagsUpdate (559.72s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges (414.54s)
--- PASS: TestAccDynamoDBTable_Replica_tagsNext (755.16s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (797.66s)
--- PASS: TestAccDynamoDBTable_backup_overrideEncryption (981.96s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (983.83s)
--- PASS: TestAccDynamoDBTable_extended (612.88s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (990.37s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (997.41s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (915.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	1042.457s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 11, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDynamoDBTable_Replica' PKG=dynamodb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 3  -run=TestAccDynamoDBTable_Replica -timeout 180m
=== RUN   TestAccDynamoDBTable_Replica_multiple
=== PAUSE TestAccDynamoDBTable_Replica_multiple
=== RUN   TestAccDynamoDBTable_Replica_single
=== PAUSE TestAccDynamoDBTable_Replica_single
=== RUN   TestAccDynamoDBTable_Replica_singleWithCMK
=== PAUSE TestAccDynamoDBTable_Replica_singleWithCMK
=== RUN   TestAccDynamoDBTable_Replica_pitr
=== PAUSE TestAccDynamoDBTable_Replica_pitr
=== RUN   TestAccDynamoDBTable_Replica_tagsOneOfTwo
=== PAUSE TestAccDynamoDBTable_Replica_tagsOneOfTwo
=== RUN   TestAccDynamoDBTable_Replica_tagsTwoOfTwo
=== PAUSE TestAccDynamoDBTable_Replica_tagsTwoOfTwo
=== RUN   TestAccDynamoDBTable_Replica_tagsNext
=== PAUSE TestAccDynamoDBTable_Replica_tagsNext
=== RUN   TestAccDynamoDBTable_Replica_tagsUpdate
=== PAUSE TestAccDynamoDBTable_Replica_tagsUpdate
=== CONT  TestAccDynamoDBTable_Replica_multiple
=== CONT  TestAccDynamoDBTable_Replica_tagsOneOfTwo
=== CONT  TestAccDynamoDBTable_Replica_singleWithCMK
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (199.27s)
=== CONT  TestAccDynamoDBTable_Replica_pitr
--- PASS: TestAccDynamoDBTable_Replica_tagsOneOfTwo (295.39s)
=== CONT  TestAccDynamoDBTable_Replica_single
--- PASS: TestAccDynamoDBTable_Replica_pitr (333.43s)
=== CONT  TestAccDynamoDBTable_Replica_tagsNext
--- PASS: TestAccDynamoDBTable_Replica_multiple (553.94s)
=== CONT  TestAccDynamoDBTable_Replica_tagsUpdate
--- PASS: TestAccDynamoDBTable_Replica_single (494.05s)
=== CONT  TestAccDynamoDBTable_Replica_tagsTwoOfTwo
--- PASS: TestAccDynamoDBTable_Replica_tagsUpdate (350.65s)
--- PASS: TestAccDynamoDBTable_Replica_tagsNext (493.95s)
--- PASS: TestAccDynamoDBTable_Replica_tagsTwoOfTwo (353.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	1147.334s

@YakDriver YakDriver changed the title dynamodb_table: Fix replica propagate_tags bug dynamodb_table: Fix replica.*propagate_tags bug Aug 11, 2022
@YakDriver YakDriver merged commit 4b0d589 into main Aug 11, 2022
@YakDriver YakDriver deleted the b-dynamodb-table-replica-propagate-tags branch August 11, 2022 21:47
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 11, 2022
github-actions bot pushed a commit that referenced this pull request Aug 11, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_dynamodb_table: Replica propagate_tags not working properly
2 participants