td/aws_connect - associate disassociate type sets #26151

GlennChia · 2022-08-06T04:11:46Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Instead of disassociating all the currently associated elements and re-associating them, we get the diffs instead and do individual associations and disassociations only for those diffs (additions or subtractions)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnectRoutingProfile_serial/updateQueues\|TestAccConnectQueue_serial/updateQuickConnectIDs' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectRoutingProfile_serial/updateQueues\|TestAccConnectQueue_serial/updateQuickConnectIDs -timeout 180m
=== RUN   TestAccConnectQueue_serial
=== RUN   TestAccConnectQueue_serial/updateQuickConnectIDs
--- PASS: TestAccConnectQueue_serial (218.67s)
    --- PASS: TestAccConnectQueue_serial/updateQuickConnectIDs (218.67s)
=== RUN   TestAccConnectRoutingProfile_serial
=== RUN   TestAccConnectRoutingProfile_serial/updateQueues
--- PASS: TestAccConnectRoutingProfile_serial (196.90s)
    --- PASS: TestAccConnectRoutingProfile_serial/updateQueues (196.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    415.676s

...

drewmullen

LGTM

dttung2905 · 2023-02-15T11:49:00Z

Hey @GlennChia , can this be merged already ?

GlennChia · 2023-02-15T14:03:28Z

Hi @dttung2905, PR is ready on my end. I'm a community contributor as well so I don't have merge permissions. I believe the team has a prioritization guide for PRs here: https://hashicorp.github.io/terraform-provider-aws/prioritization/.

ewbankkit · 2023-02-25T18:27:52Z

We can only remove attributes as part of a major release.
Instead, mark quick_connect_ids_associated as deprecated and it can be removed as part of v5.0.0.
Please also add a CHANGELOG entry and update documentation.
Thanks.

associate new elements and disassoicate only those removed

disassociate updated elements and assoicate only those updated

GlennChia · 2023-02-26T01:43:27Z

Thanks @ewbankkit, attributes have been listed as deprecated with changelog introduced. For documentation, since this attribute was never written in the website documentation before this PR, should it be introduced with the deprecation notice? Thanks!

Reference:

terraform-provider-aws/website/docs/r/connect_routing_profile.html.markdown

Lines 66 to 79 in 5acce42

    
           ## Attributes Reference 
        
           In addition to all arguments above, the following attributes are exported: 
        
           * `arn` - The Amazon Resource Name (ARN) of the Routing Profile. 
        
           * `id` - The identifier of the hosting Amazon Connect Instance and identifier of the Routing Profile separated by a colon (`:`). 
        
           * `queue_configs` - In addition to the arguments used in the `queue_configs` argument block, there are additional attributes exported within the `queue_configs` block. These additional attributes are documented below. 
        
           * `routing_profile_id` - The identifier for the Routing Profile. 
        
           * `tags_all` - A map of tags assigned to the resource, including those inherited from the provider [`default_tags` configuration block](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags-configuration-block). 
        
           A `queue_configs` block supports the following attributes in addition to the arguments defined earlier: 
        
           * `queue_arn` - ARN for the queue. 
        
           * `queue_name` - Name for the queue.

Reference:

terraform-provider-aws/website/docs/r/connect_queue.html.markdown

Lines 93 to 100 in 5acce42

    
           ## Attributes Reference 
        
           In addition to all arguments above, the following attributes are exported: 
        
           * `arn` - The Amazon Resource Name (ARN) of the Queue. 
        
           * `queue_id` - The identifier for the Queue. 
        
           * `id` - The identifier of the hosting Amazon Connect Instance and identifier of the Queue separated by a colon (`:`). 
        
           * `tags_all` - A map of tags assigned to the resource, including those inherited from the provider [`default_tags` configuration block](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags-configuration-block).

GlennChia · 2023-02-26T02:49:59Z

I'm also getting errors when the tests are run (these are related to this PR):

$ make testacc TESTARGS='-run=TestAccConnect_serial/RoutingProfile/queues\|TestAccConnect_serial/Queue/quickConnectIds' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnect_serial/RoutingProfile/queues\|TestAccConnect_serial/Queue/quickConnectIds -timeout 180m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/RoutingProfile
=== RUN   TestAccConnect_serial/RoutingProfile/queues
    routing_profile_test.go:225: Step 1/7 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
         <= read (data resources)
        
        Terraform will perform the following actions:
        
          # data.aws_connect_hours_of_operation.test will be read during apply
          # (config refers to values not yet known)
         <= data "aws_connect_hours_of_operation" "test"  {
              ~ arn                    = "arn:aws:connect:us-west-2:ACCOUNT-ID:instance/EXAMPLE-ID/operating-hours/EXAMPLE-ID" -> (known after apply)
              ~ config                 = [
                  - {
                      - day        = "FRIDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "MONDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "SATURDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "SUNDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "THURSDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "TUESDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "WEDNESDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                ] -> (known after apply)
              ~ description            = "Always open hours" -> (known after apply)
              ~ hours_of_operation_arn = "arn:aws:connect:us-west-2:ACCOUNT-ID:instance/EXAMPLE-ID/operating-hours/EXAMPLE-ID" -> (known after apply)
              ~ hours_of_operation_id  = "EXAMPLE-ID" -> (known after apply)
              ~ id                     = "EXAMPLE-ID" -> (known after apply)
                name                   = "Basic Hours"
              ~ tags                   = {} -> (known after apply)
              ~ time_zone              = "America/New_York" -> (known after apply)
                # (1 unchanged attribute hidden)
            }
        
          # aws_connect_instance.test will be updated in-place
          ~ resource "aws_connect_instance" "test" {
                id                               = "EXAMPLE-ID"
              ~ multi_party_conference_enabled   = true -> false
                # (12 unchanged attributes hidden)
            }
        
          # aws_connect_queue.default_outbound_queue will be updated in-place
          ~ resource "aws_connect_queue" "default_outbound_queue" {
              ~ hours_of_operation_id        = "EXAMPLE-ID" -> (known after apply)
                id                           = "EXAMPLE-ID"
                name                         = "EXAMPLE-NAME"
                # (8 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 2 to change, 0 to destroy.
=== RUN   TestAccConnect_serial/Queue
=== RUN   TestAccConnect_serial/Queue/quickConnectIds
    queue_test.go:354: Step 1/7 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
         <= read (data resources)
        
        Terraform will perform the following actions:
        
          # data.aws_connect_hours_of_operation.test will be read during apply
          # (config refers to values not yet known)
         <= data "aws_connect_hours_of_operation" "test"  {
              ~ arn                    = "arn:aws:connect:us-west-2:ACCOUNT-ID:instance/EXAMPLE-ID/operating-hours/EXAMPLE-ID" -> (known after apply)
              ~ config                 = [
                  - {
                      - day        = "FRIDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "MONDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "SATURDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "SUNDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "THURSDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "TUESDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                  - {
                      - day        = "WEDNESDAY"
                      - end_time   = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                      - start_time = [
                          - {
                              - hours   = 0
                              - minutes = 0
                            },
                        ]
                    },
                ] -> (known after apply)
              ~ description            = "Always open hours" -> (known after apply)
              ~ hours_of_operation_arn = "arn:aws:connect:us-west-2:ACCOUNT-ID:instance/EXAMPLE-ID/operating-hours/EXAMPLE-ID" -> (known after apply)
              ~ hours_of_operation_id  = "EXAMPLE-ID" -> (known after apply)
              ~ id                     = "EXAMPLE-ID" -> (known after apply)
                name                   = "Basic Hours"
              ~ tags                   = {} -> (known after apply)
              ~ time_zone              = "America/New_York" -> (known after apply)
                # (1 unchanged attribute hidden)
            }
        
          # aws_connect_instance.test will be updated in-place
          ~ resource "aws_connect_instance" "test" {
                id                               = "EXAMPLE-ID"
              ~ multi_party_conference_enabled   = true -> false
                # (12 unchanged attributes hidden)
            }
        
          # aws_connect_queue.test will be updated in-place
          ~ resource "aws_connect_queue" "test" {
              ~ hours_of_operation_id        = "EXAMPLE-ID" -> (known after apply)
                id                           = "EXAMPLE-ID"
                name                         = "EXAMPLE-NAME"
                tags                         = {
                    "Name" = "Test Queue"
                }
                # (8 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 2 to change, 0 to destroy.
--- FAIL: TestAccConnect_serial (172.55s)
    --- FAIL: TestAccConnect_serial/RoutingProfile (87.28s)
        --- FAIL: TestAccConnect_serial/RoutingProfile/queues (87.28s)
    --- FAIL: TestAccConnect_serial/Queue (85.27s)
        --- FAIL: TestAccConnect_serial/Queue/quickConnectIds (85.27s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/connect    172.661s
FAIL
make: *** [testacc] Error 1

Upon further investigation, I found that it had to do with the multi_party_conference_enabled argument of the aws_connect_instance. From the code, it is set to a default value of false but somehow when created, it's being created as true. To validate this hypothesis, for the tests above I tried setting multi_party_conference_enabled of the aws_connect_instance to true and the test cases pass:

$ make testacc TESTARGS='-run=TestAccConnect_serial/RoutingProfile/queues\|TestAccConnect_serial/Queue/quickConnectIds' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnect_serial/RoutingProfile/queues\|TestAccConnect_serial/Queue/quickConnectIds -timeout 180m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/Queue
=== RUN   TestAccConnect_serial/Queue/quickConnectIds
=== RUN   TestAccConnect_serial/RoutingProfile
=== RUN   TestAccConnect_serial/RoutingProfile/queues
--- PASS: TestAccConnect_serial (343.79s)
    --- PASS: TestAccConnect_serial/Queue (170.45s)
        --- PASS: TestAccConnect_serial/Queue/quickConnectIds (170.45s)
    --- PASS: TestAccConnect_serial/RoutingProfile (173.34s)
        --- PASS: TestAccConnect_serial/RoutingProfile/queues (173.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    343.892s

On a fresh Connect instance, I ran the list-instance-attributes CLI command and the MULTI_PARTY_CONFERENCE shows as true and not false.

aws connect list-instance-attributes --instance-id EXAMPLE-ID
{
    "Attributes": [
        {
            "AttributeType": "AUTO_RESOLVE_BEST_VOICES",
            "Value": "true"
        },
        {
            "AttributeType": "CONTACTFLOW_LOGS",
            "Value": "true"
        },
        {
            "AttributeType": "CONTACT_LENS",
            "Value": "true"
        },
        {
            "AttributeType": "EARLY_MEDIA",
            "Value": "true"
        },
        {
            "AttributeType": "ENHANCED_CONTACT_MONITORING",
            "Value": "true"
        },
        {
            "AttributeType": "INBOUND_CALLS",
            "Value": "true"
        },
        {
            "AttributeType": "MULTI_PARTY_CONFERENCE",
            "Value": "true"
        },
        {
            "AttributeType": "OUTBOUND_CALLS",
            "Value": "true"
        },
        {
            "AttributeType": "USE_CUSTOM_TTS_VOICES",
            "Value": "false"
        }
    ]
}

Proposed fix: change default of multi_party_conference_enabled to true. @ewbankkit, should I change this default in this PR or raise a new PR for it? Thanks!

terraform-provider-aws/internal/service/connect/instance.go

Lines 91 to 95 in 5acce42

    
           "multi_party_conference_enabled": { 
        
           	Type:     schema.TypeBool, 
        
           	Optional: true, 
        
           	Default:  false, //verified default result from ListInstanceAttributes() 
        
           },

ewbankkit · 2023-03-14T20:04:17Z

@GlennChia I think the problem with Connect Instance attributes is that they are only getting set on Create if the value is true (that's what d.GetOk() does):

terraform-provider-aws/internal/service/connect/instance.go

Lines 149 to 161 in 33151ab

    
           for att := range InstanceAttributeMapping() { 
        
           	rKey := InstanceAttributeMapping()[att] 
        
           	if v, ok := d.GetOk(rKey); ok { 
        
           		err := resourceInstanceUpdateAttribute(ctx, conn, d.Id(), att, strconv.FormatBool(v.(bool))) 
        
           		//Pre-release attribute, user/account/instance now allow-listed 
        
           		if err != nil && tfawserr.ErrCodeEquals(err, ErrCodeAccessDeniedException) || tfawserr.ErrMessageContains(err, ErrCodeAccessDeniedException, "not authorized to update") { 
        
           			log.Printf("[WARN] error setting Connect instance (%s) attribute (%s): %s", d.Id(), att, err) 
        
           		} else if err != nil { 
        
           			return diag.FromErr(fmt.Errorf("error setting Connect instance (%s) attribute (%s): %w", d.Id(), att, err)) 
        
           		} 
        
           	} 
        
           }

.

I am testing with always sending the value, (true or `false).

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConnect_serial/RoutingProfile' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/RoutingProfile -timeout 180m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/RoutingProfile
=== RUN   TestAccConnect_serial/RoutingProfile/concurrency
=== RUN   TestAccConnect_serial/RoutingProfile/defaultOutboundQueue
=== RUN   TestAccConnect_serial/RoutingProfile/queues
=== RUN   TestAccConnect_serial/RoutingProfile/dataSource_id
=== RUN   TestAccConnect_serial/RoutingProfile/dataSource_name
=== RUN   TestAccConnect_serial/RoutingProfile/basic
=== RUN   TestAccConnect_serial/RoutingProfile/disappears
    routing_profile_test.go:77: Routing Profiles do not support deletion today
=== RUN   TestAccConnect_serial/RoutingProfile/tags
--- PASS: TestAccConnect_serial (1310.81s)
    --- PASS: TestAccConnect_serial/RoutingProfile (1310.81s)
        --- PASS: TestAccConnect_serial/RoutingProfile/concurrency (139.62s)
        --- PASS: TestAccConnect_serial/RoutingProfile/defaultOutboundQueue (117.00s)
        --- PASS: TestAccConnect_serial/RoutingProfile/queues (219.99s)
        --- PASS: TestAccConnect_serial/RoutingProfile/dataSource_id (190.94s)
        --- PASS: TestAccConnect_serial/RoutingProfile/dataSource_name (190.85s)
        --- PASS: TestAccConnect_serial/RoutingProfile/basic (218.37s)
        --- SKIP: TestAccConnect_serial/RoutingProfile/disappears (0.00s)
        --- PASS: TestAccConnect_serial/RoutingProfile/tags (234.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	1319.749s
% make testacc TESTARGS='-run=TestAccConnect_serial/Queue' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/Queue -timeout 180m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/Queue
=== RUN   TestAccConnect_serial/Queue/disappears
    queue_test.go:74: Queues do not support deletion today
=== RUN   TestAccConnect_serial/Queue/hoursOfOperationId
=== RUN   TestAccConnect_serial/Queue/maxContacts
    queue_test.go:174: A bug in the service API has been reported
=== RUN   TestAccConnect_serial/Queue/outboundCallerConfig
=== RUN   TestAccConnect_serial/Queue/status
=== RUN   TestAccConnect_serial/Queue/basic
=== RUN   TestAccConnect_serial/Queue/tags
=== RUN   TestAccConnect_serial/Queue/quickConnectIds
=== RUN   TestAccConnect_serial/Queue/dataSource_id
=== RUN   TestAccConnect_serial/Queue/dataSource_name
--- PASS: TestAccConnect_serial (940.35s)
    --- PASS: TestAccConnect_serial/Queue (940.35s)
        --- SKIP: TestAccConnect_serial/Queue/disappears (0.00s)
        --- PASS: TestAccConnect_serial/Queue/hoursOfOperationId (147.12s)
        --- SKIP: TestAccConnect_serial/Queue/maxContacts (0.00s)
        --- PASS: TestAccConnect_serial/Queue/outboundCallerConfig (112.10s)
        --- PASS: TestAccConnect_serial/Queue/status (118.21s)
        --- PASS: TestAccConnect_serial/Queue/basic (108.01s)
        --- PASS: TestAccConnect_serial/Queue/tags (120.82s)
        --- PASS: TestAccConnect_serial/Queue/quickConnectIds (148.38s)
        --- PASS: TestAccConnect_serial/Queue/dataSource_id (88.72s)
        --- PASS: TestAccConnect_serial/Queue/dataSource_name (96.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	951.070s
% make testacc TESTARGS='-run=TestAccConnect_serial/^Instance$$' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/^Instance$ -timeout 180m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/Instance
=== RUN   TestAccConnect_serial/Instance/dataSource_basic
=== RUN   TestAccConnect_serial/Instance/basic
=== RUN   TestAccConnect_serial/Instance/directory
=== RUN   TestAccConnect_serial/Instance/saml
--- PASS: TestAccConnect_serial (1015.19s)
    --- PASS: TestAccConnect_serial/Instance (1015.18s)
        --- PASS: TestAccConnect_serial/Instance/dataSource_basic (120.84s)
        --- PASS: TestAccConnect_serial/Instance/basic (97.86s)
        --- PASS: TestAccConnect_serial/Instance/directory (660.04s)
        --- PASS: TestAccConnect_serial/Instance/saml (136.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	1020.538s

…ust if they're 'true'.

ewbankkit · 2023-03-14T21:00:28Z

@GlennChia Thanks for the contribution 🎉 👏.

github-actions · 2023-03-16T21:32:58Z

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-04-16T02:14:46Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added service/connect Issues and PRs that pertain to the connect service. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Aug 6, 2022

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 18, 2022

GlennChia force-pushed the td-aws_connect branch from c03449b to d702356 Compare January 30, 2023 14:26

drewmullen approved these changes Jan 30, 2023

View reviewed changes

GlennChia mentioned this pull request Feb 3, 2023

aws_connect_routing_profile: increase the hardcoded queue limit to AWS default value of 50 #27573

Closed

ewbankkit added this to the v5.0.0 milestone Feb 25, 2023

ewbankkit added the waiting-response Maintainers are waiting on response from community or contributor. label Feb 25, 2023

GlennChia added 6 commits February 26, 2023 01:27

refactor(connect): update to quick_connect_ids

5568f2b

associate new elements and disassoicate only those removed

refactor(connect): update to queue_configs

16ff769

disassociate updated elements and assoicate only those updated

chore(connect): routing profile update comment

a73fdc0

refactor(connect): err message

66fbd11

chore(connect): deprecate unused attributes

9d4ef63

ci(connect): changelog deprecate unused attributes

bacdf7d

GlennChia force-pushed the td-aws_connect branch from d702356 to bacdf7d Compare February 26, 2023 01:40

github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Feb 26, 2023

GlennChia added 2 commits February 26, 2023 01:50

refactor(connect): use diag.Errorf context errs

8a955a8

ci(connect): semgrep ignore WithContext

f349e43

ewbankkit removed this from the v5.0.0 milestone Feb 28, 2023

Merge branch 'main' into HEAD

145c4e1

ewbankkit self-assigned this Mar 14, 2023

ewbankkit approved these changes Mar 14, 2023

View reviewed changes

r/aws_connect_instance: Always send attribute values on Create, not j…

c738b83

…ust if they're 'true'.

ewbankkit merged commit cd3a61c into hashicorp:main Mar 14, 2023

github-actions bot added this to the v4.59.0 milestone Mar 14, 2023

GlennChia deleted the td-aws_connect branch March 15, 2023 03:42

github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

td/aws_connect - associate disassociate type sets #26151

td/aws_connect - associate disassociate type sets #26151

GlennChia commented Aug 6, 2022

drewmullen left a comment

dttung2905 commented Feb 15, 2023

GlennChia commented Feb 15, 2023

ewbankkit commented Feb 25, 2023

GlennChia commented Feb 26, 2023

GlennChia commented Feb 26, 2023

ewbankkit commented Mar 14, 2023

ewbankkit left a comment •

edited

Loading

ewbankkit commented Mar 14, 2023

github-actions bot commented Mar 16, 2023

github-actions bot commented Apr 16, 2023

td/aws_connect - associate disassociate type sets #26151

td/aws_connect - associate disassociate type sets #26151

Conversation

GlennChia commented Aug 6, 2022

Community Note

drewmullen left a comment

Choose a reason for hiding this comment

dttung2905 commented Feb 15, 2023

GlennChia commented Feb 15, 2023

ewbankkit commented Feb 25, 2023

GlennChia commented Feb 26, 2023

GlennChia commented Feb 26, 2023

ewbankkit commented Mar 14, 2023

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

ewbankkit commented Mar 14, 2023

github-actions bot commented Mar 16, 2023

github-actions bot commented Apr 16, 2023

ewbankkit left a comment •

edited

Loading