Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_location_tracker_association: new resource #26061

Merged

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19629.

Output from acceptance testing:

$ make testacc PKG=location TESTS="TestAccLocationTrackerAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 20 -run='TestAccLocationTrackerAssociation_'  -timeout 180m
=== RUN   TestAccLocationTrackerAssociation_basic
=== PAUSE TestAccLocationTrackerAssociation_basic
=== RUN   TestAccLocationTrackerAssociation_disappears
=== PAUSE TestAccLocationTrackerAssociation_disappears
=== CONT  TestAccLocationTrackerAssociation_basic
=== CONT  TestAccLocationTrackerAssociation_disappears
--- PASS: TestAccLocationTrackerAssociation_disappears (25.01s)
--- PASS: TestAccLocationTrackerAssociation_basic (29.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/location   31.114s
TEST=./internal/service/location TESTARGS="-run=TestTrackerAssociationParseId" make test
==> Checking that code complies with gofmt requirements...
go test ./internal/service/location -run=TestTrackerAssociationParseId -timeout=5m
ok      github.com/hashicorp/terraform-provider-aws/internal/service/location   (cached)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jul 31, 2022
@kamilturek kamilturek force-pushed the f-aws-location-tracker-association branch from a85d2e4 to 71707bf Compare July 31, 2022 11:48
@kamilturek kamilturek force-pushed the f-aws-location-tracker-association branch from ea17647 to ecac43f Compare August 4, 2022 19:33
@kamilturek kamilturek marked this pull request as ready for review August 5, 2022 19:29
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 8, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLocationTrackerAssociation_' PKG=location ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 2  -run=TestAccLocationTrackerAssociation_ -timeout 180m
=== RUN   TestAccLocationTrackerAssociation_basic
=== PAUSE TestAccLocationTrackerAssociation_basic
=== RUN   TestAccLocationTrackerAssociation_disappears
=== PAUSE TestAccLocationTrackerAssociation_disappears
=== CONT  TestAccLocationTrackerAssociation_basic
=== CONT  TestAccLocationTrackerAssociation_disappears
--- PASS: TestAccLocationTrackerAssociation_disappears (18.42s)
--- PASS: TestAccLocationTrackerAssociation_basic (21.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	26.160s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b272df5 into hashicorp:main Aug 8, 2022
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 8, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kamilturek kamilturek deleted the f-aws-location-tracker-association branch August 13, 2022 19:00
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants