New Service: AWS Recycle Bin

[rlizzo]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23160

Output from acceptance testing:

$ make testacc TESTS='TestAccRBinRBinRule_' PKG=rbin
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rbin/... -v -count 1 -parallel 20 -run='TestAccRBinRBinRule_'  -timeout 180m
=== RUN   TestAccRBinRBinRule_basic
=== PAUSE TestAccRBinRBinRule_basic
=== RUN   TestAccRBinRBinRule_disappears
=== PAUSE TestAccRBinRBinRule_disappears
=== CONT  TestAccRBinRBinRule_basic
=== CONT  TestAccRBinRBinRule_disappears
--- PASS: TestAccRBinRBinRule_disappears (9.95s)
--- PASS: TestAccRBinRBinRule_basic (13.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rbin	13.826s

Notes:

• This is my first time writing a Terraform provider, and while I'm sure there are many improvements to make I would specifically ask that the reviewers suggest more acceptance tests which should be written. The testing is really on the "light" side right now.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[rlizzo]

Question for the maintainer team about the bot note:

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

The github.com/aws/aws-sdk-go-v2/service/rbin package is required for this PR to be merged. If I roll back these changes the code no longer compiles. How are these situations handled?

[github-actions]

Welcome @rlizzo 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[sahaqaa]

Hello, is there any update on this? This feature would be good to have :-) Looking forward to seeing it implemented

[jar-b]

The github.com/aws/aws-sdk-go-v2/service/rbin package is required for this PR to be merged. If I roll back these changes the code no longer compiles. How are these situations handled?

Hey @rlizzo 👋, thanks for opening this! For a new service, we typically split the client registration into it's own PR. This prevents the constant merge conflicts in the generated files.

Would you mind opening a separate PR to add the new recycle bin client (you'll get the same automated note as above, but it's fine for this situation), leaving this PR with just the new resource implementation?

[jar-b]

LGTM 🎉

$ make testacc PKG=rbin
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rbin/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestAccRBinRule_basic
=== PAUSE TestAccRBinRule_basic
=== RUN   TestAccRBinRule_disappears
=== PAUSE TestAccRBinRule_disappears
=== RUN   TestAccRBinRule_tags
=== PAUSE TestAccRBinRule_tags
=== RUN   TestAccRBinRule_lock_config
=== PAUSE TestAccRBinRule_lock_config
=== CONT  TestAccRBinRule_basic
=== CONT  TestAccRBinRule_lock_config
=== CONT  TestAccRBinRule_tags
=== CONT  TestAccRBinRule_disappears
--- PASS: TestAccRBinRule_disappears (10.98s)
--- PASS: TestAccRBinRule_lock_config (12.86s)
--- PASS: TestAccRBinRule_basic (14.88s)
--- PASS: TestAccRBinRule_tags (31.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rbin       35.008s

[github-actions]

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.