Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_transcribe_vocabulary_filter #25918

Merged
merged 10 commits into from
Jul 21, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jul 21, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #18865

Output from acceptance testing:

Commercial

$ make testacc TESTS=TestAccTranscribeVocabularyFilter_ PKG=transcribe

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 20 -run='TestAccTranscribeVocabularyFilter_'  -timeout 180m
=== RUN   TestAccTranscribeVocabularyFilter_basic
=== PAUSE TestAccTranscribeVocabularyFilter_basic
=== RUN   TestAccTranscribeVocabularyFilter_basicWords
=== PAUSE TestAccTranscribeVocabularyFilter_basicWords
=== RUN   TestAccTranscribeVocabularyFilter_update
=== PAUSE TestAccTranscribeVocabularyFilter_update
=== RUN   TestAccTranscribeVocabularyFilter_updateTags
=== PAUSE TestAccTranscribeVocabularyFilter_updateTags
=== RUN   TestAccTranscribeVocabularyFilter_disappears
=== PAUSE TestAccTranscribeVocabularyFilter_disappears
=== CONT  TestAccTranscribeVocabularyFilter_basic
=== CONT  TestAccTranscribeVocabularyFilter_updateTags
=== CONT  TestAccTranscribeVocabularyFilter_update
=== CONT  TestAccTranscribeVocabularyFilter_disappears
=== CONT  TestAccTranscribeVocabularyFilter_basicWords
--- PASS: TestAccTranscribeVocabularyFilter_basicWords (21.99s)
--- PASS: TestAccTranscribeVocabularyFilter_disappears (25.00s)
--- PASS: TestAccTranscribeVocabularyFilter_basic (26.76s)
--- PASS: TestAccTranscribeVocabularyFilter_update (39.72s)
--- PASS: TestAccTranscribeVocabularyFilter_updateTags (56.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	58.898s
...

Gov Cloud

$ make testacc TESTS=TestAccTranscribeVocabularyFilter_ PKG=transcribe

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 20 -run='TestAccTranscribeVocabularyFilter_'  -timeout 180m
=== RUN   TestAccTranscribeVocabularyFilter_basic
=== PAUSE TestAccTranscribeVocabularyFilter_basic
=== RUN   TestAccTranscribeVocabularyFilter_basicWords
=== PAUSE TestAccTranscribeVocabularyFilter_basicWords
=== RUN   TestAccTranscribeVocabularyFilter_update
=== PAUSE TestAccTranscribeVocabularyFilter_update
=== RUN   TestAccTranscribeVocabularyFilter_updateTags
=== PAUSE TestAccTranscribeVocabularyFilter_updateTags
=== RUN   TestAccTranscribeVocabularyFilter_disappears
=== PAUSE TestAccTranscribeVocabularyFilter_disappears
=== CONT  TestAccTranscribeVocabularyFilter_basic
=== CONT  TestAccTranscribeVocabularyFilter_updateTags
=== CONT  TestAccTranscribeVocabularyFilter_disappears
=== CONT  TestAccTranscribeVocabularyFilter_update
=== CONT  TestAccTranscribeVocabularyFilter_basicWords
--- PASS: TestAccTranscribeVocabularyFilter_basicWords (16.89s)
--- PASS: TestAccTranscribeVocabularyFilter_disappears (21.37s)
--- PASS: TestAccTranscribeVocabularyFilter_basic (24.37s)
--- PASS: TestAccTranscribeVocabularyFilter_update (37.06s)
--- PASS: TestAccTranscribeVocabularyFilter_updateTags (52.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	55.299s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/transcribe Issues and PRs that pertain to the transcribe service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jul 21, 2022
@johnsonaj johnsonaj added the new-resource Introduces a new resource. label Jul 21, 2022
@johnsonaj johnsonaj marked this pull request as ready for review July 21, 2022 17:58
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

AWS Commercial
% make testacc TESTARGS='-run=TestAccTranscribeVocabularyFilter_' PKG=transcribe ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 2  -run=TestAccTranscribeVocabularyFilter_ -timeout 180m
=== RUN   TestAccTranscribeVocabularyFilter_basic
=== PAUSE TestAccTranscribeVocabularyFilter_basic
=== RUN   TestAccTranscribeVocabularyFilter_basicWords
=== PAUSE TestAccTranscribeVocabularyFilter_basicWords
=== RUN   TestAccTranscribeVocabularyFilter_update
=== PAUSE TestAccTranscribeVocabularyFilter_update
=== RUN   TestAccTranscribeVocabularyFilter_updateTags
=== PAUSE TestAccTranscribeVocabularyFilter_updateTags
=== RUN   TestAccTranscribeVocabularyFilter_disappears
=== PAUSE TestAccTranscribeVocabularyFilter_disappears
=== CONT  TestAccTranscribeVocabularyFilter_basic
=== CONT  TestAccTranscribeVocabularyFilter_updateTags
--- PASS: TestAccTranscribeVocabularyFilter_basic (29.65s)
=== CONT  TestAccTranscribeVocabularyFilter_update
--- PASS: TestAccTranscribeVocabularyFilter_updateTags (64.28s)
=== CONT  TestAccTranscribeVocabularyFilter_basicWords
--- PASS: TestAccTranscribeVocabularyFilter_update (42.57s)
=== CONT  TestAccTranscribeVocabularyFilter_disappears
--- PASS: TestAccTranscribeVocabularyFilter_basicWords (23.16s)
--- PASS: TestAccTranscribeVocabularyFilter_disappears (24.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	103.736s
AWS US GovCloud
% make testacc TESTARGS='-run=TestAccTranscribeVocabularyFilter_' PKG=transcribe ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 2  -run=TestAccTranscribeVocabularyFilter_ -timeout 180m
=== RUN   TestAccTranscribeVocabularyFilter_basic
=== PAUSE TestAccTranscribeVocabularyFilter_basic
=== RUN   TestAccTranscribeVocabularyFilter_basicWords
=== PAUSE TestAccTranscribeVocabularyFilter_basicWords
=== RUN   TestAccTranscribeVocabularyFilter_update
=== PAUSE TestAccTranscribeVocabularyFilter_update
=== RUN   TestAccTranscribeVocabularyFilter_updateTags
=== PAUSE TestAccTranscribeVocabularyFilter_updateTags
=== RUN   TestAccTranscribeVocabularyFilter_disappears
=== PAUSE TestAccTranscribeVocabularyFilter_disappears
=== CONT  TestAccTranscribeVocabularyFilter_basic
=== CONT  TestAccTranscribeVocabularyFilter_updateTags
--- PASS: TestAccTranscribeVocabularyFilter_basic (26.38s)
=== CONT  TestAccTranscribeVocabularyFilter_disappears
--- PASS: TestAccTranscribeVocabularyFilter_disappears (18.78s)
=== CONT  TestAccTranscribeVocabularyFilter_update
--- PASS: TestAccTranscribeVocabularyFilter_updateTags (55.72s)
=== CONT  TestAccTranscribeVocabularyFilter_basicWords
--- PASS: TestAccTranscribeVocabularyFilter_basicWords (17.39s)
--- PASS: TestAccTranscribeVocabularyFilter_update (33.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	85.300s

@johnsonaj johnsonaj merged commit 56b24b7 into main Jul 21, 2022
@johnsonaj johnsonaj deleted the f-aws_transcribe_vocabulary_filter branch July 21, 2022 18:57
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 21, 2022
github-actions bot pushed a commit that referenced this pull request Jul 21, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/transcribe Issues and PRs that pertain to the transcribe service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants