Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max size of html in cognito risk config and typo in docs #25645

Conversation

TakumiHaruta
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25644

Output from acceptance testing:

$ make testacc TESTS=TestAccCognitoIDPRiskConfiguration_ PKG=cognitoidp AWS_PROFILE=my-profile AWS_REGION=ap-northeast-1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPRiskConfiguration_'  -timeout 180m
=== RUN   TestAccCognitoIDPRiskConfiguration_exception
=== PAUSE TestAccCognitoIDPRiskConfiguration_exception
=== RUN   TestAccCognitoIDPRiskConfiguration_client
=== PAUSE TestAccCognitoIDPRiskConfiguration_client
=== RUN   TestAccCognitoIDPRiskConfiguration_compromised
=== PAUSE TestAccCognitoIDPRiskConfiguration_compromised
=== RUN   TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== PAUSE TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== CONT  TestAccCognitoIDPRiskConfiguration_exception
=== CONT  TestAccCognitoIDPRiskConfiguration_compromised
=== CONT  TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== CONT  TestAccCognitoIDPRiskConfiguration_client
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears_userPool (10.04s)
--- PASS: TestAccCognitoIDPRiskConfiguration_compromised (13.57s)
--- PASS: TestAccCognitoIDPRiskConfiguration_client (14.05s)
--- PASS: TestAccCognitoIDPRiskConfiguration_exception (22.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 23.891s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jul 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @TakumiHaruta 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPRiskConfiguration_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPRiskConfiguration_ -timeout 180m
=== RUN   TestAccCognitoIDPRiskConfiguration_exception
=== PAUSE TestAccCognitoIDPRiskConfiguration_exception
=== RUN   TestAccCognitoIDPRiskConfiguration_client
=== PAUSE TestAccCognitoIDPRiskConfiguration_client
=== RUN   TestAccCognitoIDPRiskConfiguration_compromised
=== PAUSE TestAccCognitoIDPRiskConfiguration_compromised
=== RUN   TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== PAUSE TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== CONT  TestAccCognitoIDPRiskConfiguration_exception
=== CONT  TestAccCognitoIDPRiskConfiguration_disappears_userPool
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears_userPool (20.99s)
=== CONT  TestAccCognitoIDPRiskConfiguration_compromised
--- PASS: TestAccCognitoIDPRiskConfiguration_exception (40.00s)
=== CONT  TestAccCognitoIDPRiskConfiguration_client
--- PASS: TestAccCognitoIDPRiskConfiguration_compromised (19.75s)
--- PASS: TestAccCognitoIDPRiskConfiguration_client (19.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	67.601s

@ewbankkit
Copy link
Contributor

@TakumiHaruta Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b6931d3 into hashicorp:main Jul 1, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max size of html_body in Cognito Risk config is 20000, not 2000
2 participants