Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spread_level to aws_placement_group resource #25615

Merged
merged 12 commits into from
Jul 1, 2022

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Jun 29, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25614

Output from acceptance testing:

$ make testacc TESTS='TestAccEC2PlacementGroup_basic' PKG=ec2 TESTARGS=-short 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2PlacementGroup_basic' -short -timeout 180m
=== RUN   TestAccEC2PlacementGroup_basic
=== PAUSE TestAccEC2PlacementGroup_basic
=== CONT  TestAccEC2PlacementGroup_basic
--- PASS: TestAccEC2PlacementGroup_basic (79.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	83.440s

$ make testacc TESTS='TestAccEC2PlacementGroup_spreadLevel' PKG=ec2 TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2PlacementGroup_spreadLevel' -short -timeout 180m
=== RUN   TestAccEC2PlacementGroup_spreadLevel
=== PAUSE TestAccEC2PlacementGroup_spreadLevel
=== CONT  TestAccEC2PlacementGroup_spreadLevel
--- PASS: TestAccEC2PlacementGroup_spreadLevel (6.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	8.574s

...

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 29, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jun 29, 2022
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Jun 29, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 29, 2022
@silvaalbert silvaalbert changed the title wip: add spread_level to aws_placement_group resource add spread_level to aws_placement_group resource Jun 29, 2022
@silvaalbert silvaalbert marked this pull request as ready for review June 29, 2022 12:41
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2PlacementGroup_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2PlacementGroup_ -timeout 180m
=== RUN   TestAccEC2PlacementGroup_basic
=== PAUSE TestAccEC2PlacementGroup_basic
=== RUN   TestAccEC2PlacementGroup_disappears
=== PAUSE TestAccEC2PlacementGroup_disappears
=== RUN   TestAccEC2PlacementGroup_tags
=== PAUSE TestAccEC2PlacementGroup_tags
=== RUN   TestAccEC2PlacementGroup_partitionCount
=== PAUSE TestAccEC2PlacementGroup_partitionCount
=== RUN   TestAccEC2PlacementGroup_spreadLevel
=== PAUSE TestAccEC2PlacementGroup_spreadLevel
=== CONT  TestAccEC2PlacementGroup_basic
=== CONT  TestAccEC2PlacementGroup_partitionCount
--- PASS: TestAccEC2PlacementGroup_basic (17.84s)
=== CONT  TestAccEC2PlacementGroup_tags
--- PASS: TestAccEC2PlacementGroup_partitionCount (18.93s)
=== CONT  TestAccEC2PlacementGroup_disappears
--- PASS: TestAccEC2PlacementGroup_disappears (11.92s)
=== CONT  TestAccEC2PlacementGroup_spreadLevel
--- PASS: TestAccEC2PlacementGroup_spreadLevel (15.57s)
--- PASS: TestAccEC2PlacementGroup_tags (37.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	58.965s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4d69ced into hashicorp:main Jul 1, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add spread_level to aws_placement_group resource
4 participants