Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent iso-tagging precautions from eating legit errors #25549

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jun 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24930

Output from acceptance testing:

% go test ./...
?   	github.com/hashicorp/terraform-provider-aws	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	8.498s
?   	github.com/hashicorp/terraform-provider-aws/internal/attrmap	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/conns	1.184s
ok  	github.com/hashicorp/terraform-provider-aws/internal/create	1.779s
ok  	github.com/hashicorp/terraform-provider-aws/internal/experimental/nullable	2.190s
?   	github.com/hashicorp/terraform-provider-aws/internal/experimental/sync	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/flex	2.153s
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/allowsubcats	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/checknames	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/customends	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/issuelabels	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/namescapslist	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters	2.460s
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/prlabels	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/servicelabels	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/servicesemgrep	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/sweepimp	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/provider	0.543s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	4.376s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	6.959s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	12.670s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	16.941s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	10.695s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amplify	11.476s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	15.613s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	15.367s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	13.071s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	11.576s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	11.667s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations	13.052s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/applicationinsights	15.435s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	16.640s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	4.183s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	9.450s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	10.871s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	3.718s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	15.894s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans	8.098s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	17.129s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	18.102s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	6.354s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	11.944s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	13.663s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloud9	16.284s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol	15.079s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	17.554s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	21.184s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	17.088s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch	4.118s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	11.064s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	19.889s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact	13.523s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	12.171s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codecommit	6.511s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	14.669s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections	8.528s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarnotifications	9.701s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	18.655s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	19.949s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	15.154s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	16.856s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cur	17.761s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	18.793s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline	18.865s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	4.010s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dax	2.581s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	8.493s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/detective	7.165s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm	10.032s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	10.567s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm	5.736s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	11.331s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	13.737s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	10.456s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	12.127s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	17.189s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	9.109s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic	12.597s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	5.352s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	3.263s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	8.915s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	5.199s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	4.976s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch	6.478s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder	3.507s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	5.474s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	7.626s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	3.445s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers	7.848s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrserverless	8.351s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	7.406s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	8.338s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	5.403s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	5.252s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	4.002s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glacier	6.513s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	7.823s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	8.653s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	10.669s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/greengrass	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/guardduty	9.380s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	9.120s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	11.778s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	12.914s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector	12.923s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	9.787s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotevents	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	7.996s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	11.466s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	3.409s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	2.373s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	10.205s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalytics	4.963s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2	12.625s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo	6.629s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	5.748s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	11.530s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	2.558s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels	13.891s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager	14.057s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	10.705s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	6.962s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	11.163s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie	3.463s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	5.075s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert	8.911s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage	2.284s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediastore	6.181s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	7.454s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	10.383s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mq	11.538s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	12.550s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	4.915s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	13.431s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	13.451s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	3.243s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opsworks	5.182s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	7.126s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/outposts	4.612s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint	8.343s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pricing	3.041s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	6.158s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	7.443s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	3.419s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	5.359s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	2.966s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftdata	9.049s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	10.463s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstaggingapi	6.554s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	6.774s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	3.614s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig	3.520s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness	5.039s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	7.534s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	1.926s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	14.538s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	9.169s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts	10.405s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	7.345s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/schemas	7.520s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	3.239s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securityhub	11.059s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/serverlessrepo	12.012s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	7.781s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	11.602s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas	6.096s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	10.564s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	11.396s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	4.193s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/signer	9.191s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	2.602s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	12.464s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	11.716s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	11.192s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin	13.557s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	10.330s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	3.268s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/swf	13.956s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	1.874s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite	1.575s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	6.168s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/waf	3.048s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafregional	3.860s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	6.962s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/worklink	4.505s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	3.069s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/xray	8.630s
ok  	github.com/hashicorp/terraform-provider-aws/internal/tags	1.087s
ok  	github.com/hashicorp/terraform-provider-aws/internal/tfresource	40.474s
ok  	github.com/hashicorp/terraform-provider-aws/internal/vault/helper/pgpkeys	2.644s
ok  	github.com/hashicorp/terraform-provider-aws/internal/vault/sdk/helper/jsonutil	0.954s
ok  	github.com/hashicorp/terraform-provider-aws/internal/verify	0.445s
ok  	github.com/hashicorp/terraform-provider-aws/names	1.597s
?   	github.com/hashicorp/terraform-provider-aws/version	[no test files]
% make testacc TESTS=TestAccIAMUser_tags PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMUser_tags'  -timeout 180m
--- PASS: TestAccIAMUser_tags (58.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	59.753s
% make testacc TESTS=TestAccECRRepository_tags PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepository_tags'  -timeout 180m
--- PASS: TestAccECRRepository_tags (53.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	54.569s
% make testacc TESTS=TestAccCloudWatchMetricAlarm_tags PKG=cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchMetricAlarm_tags'  -timeout 180m
--- PASS: TestAccCloudWatchMetricAlarm_tags (83.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	84.884s
% make testacc TESTS=TestAccECSCluster_tags PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSCluster_tags'  -timeout 180m
--- PASS: TestAccECSCluster_tags (93.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	94.490s
% make testacc TESTS=TestAccSQSQueue_tags PKG=sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20 -run='TestAccSQSQueue_tags'  -timeout 180m
--- PASS: TestAccSQSQueue_tags (125.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	127.064s
% make testacc TESTS=TestAccSNSTopic_tags PKG=sns
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopic_tags'  -timeout 180m
--- PASS: TestAccSNSTopic_tags (84.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	85.647s
% make testacc TESTS=TestAccEventsBus_tags PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBus_tags'  -timeout 180m
--- PASS: TestAccEventsBus_tags (107.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	108.511s
% make testacc TESTS=TestAccELBV2TargetGroup_tags PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_tags'  -timeout 180m
--- PASS: TestAccELBV2TargetGroup_tags (89.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	91.249s
% make testacc TESTS=TestAccElastiCacheUser_tags PKG=elasticache
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUser_tags'  -timeout 180m
--- PASS: TestAccElastiCacheUser_tags (116.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	117.958s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/events Issues and PRs that pertain to the events service. service/iam Issues and PRs that pertain to the iam service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Jun 23, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 23, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

AWS Commercial

% make testacc TESTS=TestAccIAMUser_tags PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMUser_tags'  -timeout 180m
=== RUN   TestAccIAMUser_tags
=== PAUSE TestAccIAMUser_tags
=== CONT  TestAccIAMUser_tags
--- PASS: TestAccIAMUser_tags (28.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	32.311s

AWS GovCloud

% make testacc TESTS=TestAccIAMUser_tags PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMUser_tags'  -timeout 180m
=== RUN   TestAccIAMUser_tags
=== PAUSE TestAccIAMUser_tags
=== CONT  TestAccIAMUser_tags
--- PASS: TestAccIAMUser_tags (26.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	31.109s

@YakDriver YakDriver merged commit 8a04c06 into main Jun 23, 2022
@YakDriver YakDriver deleted the b-tags-access-denied-fail branch June 23, 2022 20:52
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 23, 2022
github-actions bot pushed a commit that referenced this pull request Jun 23, 2022
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/events Issues and PRs that pertain to the events service. service/iam Issues and PRs that pertain to the iam service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. size/XL Managed by automation to categorize the size of a PR. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TF does not fail on inability to tag IAM Policy Resources with default tags
2 participants