Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query ami by id #25521

Closed
sayurin opened this issue Jun 21, 2022 · 3 comments · Fixed by #25566
Closed

Query ami by id #25521

sayurin opened this issue Jun 21, 2022 · 3 comments · Fixed by #25566
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@sayurin
Copy link

sayurin commented Jun 21, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

aws_ami data source requires owners argument. Buf if image-id is known, it should be query without owners.

Motivation

aws_imagebuilder_image data source can query latest ami. It returns image and account_id. But sometimes account_id is empty. Or AMI public parameters can get image-id only.

Then aws_imagebuilder_image_recipe resource can set ebs parameters. When specify root volume, device_name is required. But root's device_name is not fixed, and it depends on ami. It can query only aws_ami data source.

New or Affected Resource(s)

  • aws_ami (data source)
  • aws_ami_by_id (data source)

Potential Terraform Configuration

data "aws_ami" "parent" {
  owners = null
  filter {
    name   = "image-id"
    values = ["ami-XXX"]
  }
}

# or simply,

data "aws_ami_by_id" "parent" {
  image_id = "ami-XXX"
}

References

@sayurin sayurin added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 21, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jun 21, 2022
@DrFaust92 DrFaust92 self-assigned this Jun 24, 2022
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Jun 24, 2022
@DrFaust92
Copy link
Collaborator

i was able to test the owners arg is not required, ill take this + add a few more improvements

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants