created network firewall data source

[awsaxeman]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18026

Output from acceptance testing:

$ make testacc TESTS=TestAccNetworkFirewallFirewallDataSource PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallFirewallDataSource'  -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallDataSource_arn
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arn
=== RUN   TestAccNetworkFirewallFirewallDataSource_name
=== PAUSE TestAccNetworkFirewallFirewallDataSource_name
=== RUN   TestAccNetworkFirewallFirewallDataSource_arnandname
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arnandname
=== CONT  TestAccNetworkFirewallFirewallDataSource_arn
=== CONT  TestAccNetworkFirewallFirewallDataSource_arnandname
=== CONT  TestAccNetworkFirewallFirewallDataSource_name
--- PASS: TestAccNetworkFirewallFirewallDataSource_name (676.03s)
--- PASS: TestAccNetworkFirewallFirewallDataSource_arn (697.58s)
--- PASS: TestAccNetworkFirewallFirewallDataSource_arnandname (705.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    719.733s
...

[ddericco]

Hi @awsaxeman - good first PR! I took a first pass and have some recommended changes. I see @AdamTylerLynch self-assigned this as well and may have other suggestions.

[AdamTylerLynch]

Asked about addition attributes to expose.

[AdamTylerLynch]

LGTM 🚀

P.S. I see the service has exposed additional response data, I will file a corresponding GitHub issue as an enhancement for those.

[AdamTylerLynch]

There is two items that I don't believe the author of this PR needs to address:

1. The CI/CD chain is breaking on files that they did not change. A simple rerun of the build should fix them?
2. The AWS service has exposed new response objects, I have filed an enhancement request Add new attributes to AWS Network Firewall Datasource #26148.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallDataSource_' PKG=networkfirewall ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 3  -run=TestAccNetworkFirewallFirewallDataSource_ -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallDataSource_arn
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arn
=== RUN   TestAccNetworkFirewallFirewallDataSource_name
=== PAUSE TestAccNetworkFirewallFirewallDataSource_name
=== RUN   TestAccNetworkFirewallFirewallDataSource_arnandname
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arnandname
=== CONT  TestAccNetworkFirewallFirewallDataSource_arn
=== CONT  TestAccNetworkFirewallFirewallDataSource_arnandname
=== CONT  TestAccNetworkFirewallFirewallDataSource_name
--- PASS: TestAccNetworkFirewallFirewallDataSource_arn (637.11s)
--- PASS: TestAccNetworkFirewallFirewallDataSource_name (646.08s)
--- PASS: TestAccNetworkFirewallFirewallDataSource_arnandname (677.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	681.683s

[ewbankkit]

@awsaxeman Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.