Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data source for aws_route53_resolver_firewall_domain_list #25492

Closed
silvaalbert opened this issue Jun 20, 2022 · 5 comments · Fixed by #25509
Closed

add data source for aws_route53_resolver_firewall_domain_list #25492

silvaalbert opened this issue Jun 20, 2022 · 5 comments · Fixed by #25509
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/route53resolver Issues and PRs that pertain to the route53resolver service.
Milestone

Comments

@silvaalbert
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add a data source for the aws_route53_resolver_firewall_domain_list resource.

New or Affected Resource(s)

  • aws_route53_resolver_firewall_domain_list

Potential Terraform Configuration

data "aws_route53_resolver_firewall_domain_list" "this {
  firewall_domain_list_id = "examplexxx"
}

References

@silvaalbert silvaalbert added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 20, 2022
@silvaalbert
Copy link
Contributor Author

I am currently working on this.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/route53resolver Issues and PRs that pertain to the route53resolver service. labels Jun 20, 2022
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2022
@posquit0
Copy link
Contributor

Duplicated Issue: #21020

@loganbest
Copy link

loganbest commented Aug 31, 2022

I am currently working on this.

I would recommend using name lookup in the datasource instead of ID as it changes per region at the very least. Having name lookup is better and more DRY since the list name in AWS never changes.

@github-actions github-actions bot added this to the v4.39.0 milestone Nov 9, 2022
@github-actions
Copy link

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/route53resolver Issues and PRs that pertain to the route53resolver service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants