r/aws_ce_cost_category Add tags to cost category

[danquack]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25422

Output from acceptance testing:

$ make testacc TESTS=TestAccCECostCategory_ PKG=ce
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 20 -run='TestAccCECostCategory_'  -timeout 180m
=== RUN   TestAccCECostCategory_tagRemove
=== PAUSE TestAccCECostCategory_tagRemove
=== RUN   TestAccCECostCategory_tagAdd
=== PAUSE TestAccCECostCategory_tagAdd
=== CONT  TestAccCECostCategory_tagRemove
=== CONT  TestAccCECostCategory_tagAdd
--- PASS: TestAccCECostCategory_tagRemove (36.02s)
--- PASS: TestAccCECostCategory_tagAdd (36.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	38.812s

[danquack]

Its unclear what the test name should be. I had it as testAccCostCategoryConfig_WithTag and semgrep told me it should be testAcc<Resource>Config_<testDetail> But when I change to testAccCECostCategoryConfig_WithTag it says Do not use "CE" in func name inside ce package. The test themselves pass, it is only a semgrep build error.

[YakDriver]

I think you also need a rebase because of a weird thing with the base semgrep check.

[jjshoe]

Was able to confirm all tests pass locally

[drewmullen]

LGTM! Nice work! 🚀

[jjshoe]

@YakDriver can I get you to review this when you get a second? Should be good to go.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCECostCategory' PKG=ce ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 3  -run=TestAccCECostCategory -timeout 180m
=== RUN   TestAccCECostCategoryDataSource_basic
=== PAUSE TestAccCECostCategoryDataSource_basic
=== RUN   TestAccCECostCategory_basic
=== PAUSE TestAccCECostCategory_basic
=== RUN   TestAccCECostCategory_disappears
=== PAUSE TestAccCECostCategory_disappears
=== RUN   TestAccCECostCategory_complete
=== PAUSE TestAccCECostCategory_complete
=== RUN   TestAccCECostCategory_splitCharge
=== PAUSE TestAccCECostCategory_splitCharge
=== RUN   TestAccCECostCategory_tags
=== PAUSE TestAccCECostCategory_tags
=== CONT  TestAccCECostCategoryDataSource_basic
=== CONT  TestAccCECostCategory_tags
=== CONT  TestAccCECostCategory_complete
--- PASS: TestAccCECostCategoryDataSource_basic (23.96s)
=== CONT  TestAccCECostCategory_disappears
--- PASS: TestAccCECostCategory_disappears (16.15s)
=== CONT  TestAccCECostCategory_basic
--- PASS: TestAccCECostCategory_complete (43.84s)
=== CONT  TestAccCECostCategory_splitCharge
--- PASS: TestAccCECostCategory_tags (57.21s)
--- PASS: TestAccCECostCategory_basic (23.35s)
--- PASS: TestAccCECostCategory_splitCharge (39.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	91.494s

[ewbankkit]

@danquack Thanks for the contribution 🎉 👏.

[ewbankkit]

% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

[github-actions]

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.