Creating a fully configured s3 bucket unnecessarily complex

[dan-petty]

Creating something as simple as a replication configuration now requires explicitly adding depends_on to various elements in order get a working implementation. Where one could previously fully define an s3 bucket as a single element that could manage the order of it's own configuration, one now has to manage the order of buckets, policies, versioning resources, etc. Resources outside of the s3 bucket that need to be able to use the bucket, now have to also manage dependency to all of these sub-elements of the single s3 bucket, now a fractured set of resources. This is cumbersome both to develop and to use the documentation

[dan-petty]

Maybe we should break all terraform resources out so that each resource accepts a single configuration parameter.... 🗑️

[justinretzolk]

Hey @dan-petty 👋 Thank you for taking the time to raise this and provide some feedback. We had a pretty length discussion with the community around changes made to the S3 bucket resource with version 4.0.0 over on this issue, which may clarify the reasoning for breaking out these resources a bit more.

That said, I'm interested in the depends_on references you're needing to make. I know there are situations where you need to add a depends_on for aws_s3_bucket_replication_configuration resource(s), but it sounds like you're seeing behavior where you need to add depends_on to significantly more resources. Can you give me an idea of what that's looking like for you in practice? I'd love to pass that information along to the team so that we can take a look over it.

[dan-petty]

@justinretzolk I also left my feedback on that thread regarding this regressive design decision. From my brief search, there are half a dozen other open issues created by the entirely unnecessary act of breaking up resources that have a 1-to-1 relationship and exist only as configuration sub-elements by their very nature.

[dan-petty]

Should have just left the s3_bucket alone and called this change s3_bucket_v6...

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.