Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_lightsail_certificate #25283

Merged
merged 13 commits into from
Oct 17, 2022
Merged

New Resource: aws_lightsail_certificate #25283

merged 13 commits into from
Oct 17, 2022
+723 −33

Conversation

brittandeyoung
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

➜ terraform-provider-aws (f-aws_lightsail_certificate) ✗ make testacc TESTARGS='-run=TestAccLightsailCertificate_' PKG_NAME=internal/service/lightsail 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailCertificate_ -timeout 180m
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailCertificate_SubjectAlternativeNames
=== PAUSE TestAccLightsailCertificate_SubjectAlternativeNames
=== RUN   TestAccLightsailCertificate_DomainValidationOptions
=== PAUSE TestAccLightsailCertificate_DomainValidationOptions
=== RUN   TestAccLightsailCertificate_Tags
=== PAUSE TestAccLightsailCertificate_Tags
=== RUN   TestAccLightsailCertificate_disappears
=== PAUSE TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_basic
=== CONT  TestAccLightsailCertificate_Tags
=== CONT  TestAccLightsailCertificate_DomainValidationOptions
=== CONT  TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_SubjectAlternativeNames
--- PASS: TestAccLightsailCertificate_disappears (41.36s)
--- PASS: TestAccLightsailCertificate_SubjectAlternativeNames (43.55s)
--- PASS: TestAccLightsailCertificate_basic (44.90s)
--- PASS: TestAccLightsailCertificate_DomainValidationOptions (46.00s)
--- PASS: TestAccLightsailCertificate_Tags (92.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  95.668s

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jun 11, 2022
@brittandeyoung brittandeyoung mentioned this pull request Jun 11, 2022
Merged
@brittandeyoung
Copy link
Collaborator Author

This pull request includes commits from #18663 to utilize the waiter.

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 13, 2022
@brittandeyoung
Copy link
Collaborator Author

Resolved new merge conflicts. New test run:

➜ terraform-provider-aws (f-aws_lightsail_certificate) ✗ make testacc TESTARGS='-run=TestAccLightsailCertificate_' PKG_NAME=internal/service/lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailCertificate_ -timeout 180m
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailCertificate_SubjectAlternativeNames
=== PAUSE TestAccLightsailCertificate_SubjectAlternativeNames
=== RUN   TestAccLightsailCertificate_DomainValidationOptions
=== PAUSE TestAccLightsailCertificate_DomainValidationOptions
=== RUN   TestAccLightsailCertificate_Tags
=== PAUSE TestAccLightsailCertificate_Tags
=== RUN   TestAccLightsailCertificate_disappears
=== PAUSE TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_basic
=== CONT  TestAccLightsailCertificate_Tags
=== CONT  TestAccLightsailCertificate_DomainValidationOptions
=== CONT  TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_SubjectAlternativeNames
--- PASS: TestAccLightsailCertificate_DomainValidationOptions (42.42s)
--- PASS: TestAccLightsailCertificate_disappears (42.97s)
--- PASS: TestAccLightsailCertificate_SubjectAlternativeNames (43.51s)
--- PASS: TestAccLightsailCertificate_basic (44.59s)
--- PASS: TestAccLightsailCertificate_Tags (92.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  95.950s

@brittandeyoung
Copy link
Collaborator Author

Updated PR to resolve new conflicts. Passing tests:

➜ terraform-provider-aws (f-aws_lightsail_certificate) ✗ make testacc TESTARGS='-run=TestAccLightsailCertificate_' PKG_NAME=internal/service/lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailCertificate_ -timeout 180m
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailCertificate_SubjectAlternativeNames
=== PAUSE TestAccLightsailCertificate_SubjectAlternativeNames
=== RUN   TestAccLightsailCertificate_DomainValidationOptions
=== PAUSE TestAccLightsailCertificate_DomainValidationOptions
=== RUN   TestAccLightsailCertificate_Tags
=== PAUSE TestAccLightsailCertificate_Tags
=== RUN   TestAccLightsailCertificate_disappears
=== PAUSE TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_basic
=== CONT  TestAccLightsailCertificate_Tags
=== CONT  TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_DomainValidationOptions
=== CONT  TestAccLightsailCertificate_SubjectAlternativeNames
--- PASS: TestAccLightsailCertificate_basic (33.91s)
--- PASS: TestAccLightsailCertificate_disappears (34.38s)
--- PASS: TestAccLightsailCertificate_SubjectAlternativeNames (35.49s)
--- PASS: TestAccLightsailCertificate_DomainValidationOptions (37.10s)
--- PASS: TestAccLightsailCertificate_Tags (80.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  82.223s

ewbankkit
ewbankkit approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailCertificate_' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsailCertificate_ -timeout 180m
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailCertificate_subjectAlternativeNames
=== PAUSE TestAccLightsailCertificate_subjectAlternativeNames
=== RUN   TestAccLightsailCertificate_DomainValidationOptions
=== PAUSE TestAccLightsailCertificate_DomainValidationOptions
=== RUN   TestAccLightsailCertificate_tags
=== PAUSE TestAccLightsailCertificate_tags
=== RUN   TestAccLightsailCertificate_disappears
=== PAUSE TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_basic
=== CONT  TestAccLightsailCertificate_tags
--- PASS: TestAccLightsailCertificate_basic (41.15s)
=== CONT  TestAccLightsailCertificate_disappears
--- PASS: TestAccLightsailCertificate_disappears (34.87s)
=== CONT  TestAccLightsailCertificate_DomainValidationOptions
--- PASS: TestAccLightsailCertificate_tags (87.53s)
=== CONT  TestAccLightsailCertificate_subjectAlternativeNames
--- PASS: TestAccLightsailCertificate_DomainValidationOptions (40.07s)
--- PASS: TestAccLightsailCertificate_subjectAlternativeNames (36.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	133.252s

@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8168ba3 into hashicorp:main Oct 17, 2022
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 17, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.36.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brittandeyoung @ewbankkit @justinretzolk