Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/kendra_query_suggestions_block_list: new resource #25198

Merged
merged 3 commits into from
Jun 21, 2022
Merged

r/kendra_query_suggestions_block_list: new resource #25198

merged 3 commits into from
Jun 21, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 7, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13367

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKendra_serial/QuerySuggestionsBlockList' PKG=kendra ACCTEST_TIMEOUT=220m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/QuerySuggestionsBlockList -timeout 220m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/Name
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/RoleARN
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/SourceS3Path
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/basic
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/disappears
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/tags
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/Description
--- PASS: TestAccKendra_serial (12965.08s)
    --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList (12965.08s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/Name (1766.01s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/RoleARN (1754.50s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/SourceS3Path (1739.38s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/basic (1862.29s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/disappears (1727.01s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/tags (1619.41s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/Description (2496.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	12968.285s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. labels Jun 7, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 7, 2022
anGie44 added a commit that referenced this pull request Jun 7, 2022
@anGie44
Update CHANGELOG for #25198
4b1e481
@anGie44 anGie44 force-pushed the f-kendra-query-suggestion-block-list branch from 6bdd6bc to 4b1e481 Compare June 7, 2022 01:55
@anGie44 anGie44 mentioned this pull request Jun 7, 2022
Closed
@anGie44 anGie44 added the new-resource Introduces a new resource. label Jun 7, 2022
anGie44 added a commit that referenced this pull request Jun 14, 2022
@anGie44
Update CHANGELOG for #25198
1bb0648
@anGie44 anGie44 force-pushed the f-kendra-query-suggestion-block-list branch 8 times, most recently from 3a7a1f2 to 443128e Compare June 15, 2022 01:10
@anGie44 anGie44 marked this pull request as ready for review June 15, 2022 02:13
@anGie44 anGie44 force-pushed the f-kendra-query-suggestion-block-list branch from 443128e to 62c6391 Compare June 15, 2022 03:11
@anGie44 anGie44 force-pushed the f-kendra-query-suggestion-block-list branch from 62c6391 to 39526d2 Compare June 18, 2022 18:47
@anGie44 anGie44 force-pushed the f-kendra-query-suggestion-block-list branch 2 times, most recently from 2370074 to 86998cd Compare June 18, 2022 18:52
@anGie44 anGie44 force-pushed the f-kendra-query-suggestion-block-list branch from a1712b2 to 252455b Compare June 18, 2022 23:51
anGie44 added a commit that referenced this pull request Jun 19, 2022
@anGie44
Update CHANGELOG for #25198
bafc74b
@anGie44 anGie44 force-pushed the f-kendra-query-suggestion-block-list branch from 2aeaff6 to bafc74b Compare June 19, 2022 00:19
@anGie44 anGie44 force-pushed the f-kendra-query-suggestion-block-list branch from bafc74b to c1f0890 Compare June 21, 2022 01:31
@ewbankkit ewbankkit self-assigned this Jun 21, 2022
ewbankkit
ewbankkit approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccKendra_serial/QuerySuggestionsBlockList' PKG=kendra
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/QuerySuggestionsBlockList -timeout 360m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/tags
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/Description
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/Name
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/RoleARN
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/SourceS3Path
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/basic
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/disappears
--- PASS: TestAccKendra_serial (12066.27s)
    --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList (12066.27s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/tags (1619.69s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/Description (1918.85s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/Name (1604.41s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/RoleARN (1831.96s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/SourceS3Path (2255.67s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/basic (1427.41s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/disappears (1408.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	12070.297s

@anGie44 anGie44 added this to the v4.20.0 milestone Jun 21, 2022
@anGie44 anGie44 merged commit d0b8dc2 into main Jun 21, 2022
@anGie44 anGie44 deleted the f-kendra-query-suggestion-block-list branch June 21, 2022 16:34
github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
Update CHANGELOG.md for #25198
ff0ce52
@ewbankkit
Copy link
Contributor 

% make providerlint
==> Checking source code with providerlint...

@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit